Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2014-01-17 Thread reviewboard
Updates: Status: Fixed Comment #12 on issue 3171 by chip...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 Fixed for 0.5.6 on release-0.5.x (4c39641) -- You received this message because this project is configur

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2014-01-17 Thread reviewboard
Updates: Status: PendingReview Owner: chip...@gmail.com Labels: Milestone-RBTools-Release0.5 Component-RBTools Comment #11 on issue 3171 by chip...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 F

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-18 Thread reviewboard
Comment #10 on issue 3171 by eyuw...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 I'm currently also one of the two guys working on the Git infrastructure. I don't think we drop this file in any of the bare repos on

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-18 Thread reviewboard
Comment #9 on issue 3171 by chip...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 How are you linking up repositories today? The .reviewboardrc method is what every company we know is using. When I was working there,

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-18 Thread reviewboard
Comment #8 on issue 3171 by eyuw...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 Thanks for this confirmation! For now, I'd just use OrderedDict() and stripping off the unused SCM types in our installation. I hope

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-17 Thread reviewboard
Comment #7 on issue 3171 by chip...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 Yep, it'll take both into account. Any user configuration will also override the repository configuration. -- You received this messa

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-17 Thread reviewboard
Comment #6 on issue 3171 by eyuw...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 Sounds good to me. I haven't read the code to find this out, but I want to confirm this following case with you: If user has a .revie

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-17 Thread reviewboard
Comment #5 on issue 3171 by trowb...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 Yes, we recommend putting a .reviewboardrc in the root of each repository. There are definitely improvements we can make to the SCM det

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-17 Thread reviewboard
Comment #4 on issue 3171 by eyuw...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 OK, let me confirm if I understand your suggestion. You meant when we provision a git repo, we should drop in a .reviewboardrc file in

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-17 Thread reviewboard
Comment #3 on issue 3171 by chip...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 I'm talking about the repositories, not for individual users. A Git repository using Review Board needs a .reviewboardrc file to link i

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-17 Thread reviewboard
Comment #2 on issue 3171 by eyuw...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 What you suggest might work for a small group, but doesn't really scale for a company with 13K+ employees. You are suggesting to ask

Re: Issue 3171 in reviewboard: RBTools: A critical bug for determining SCM type?

2013-12-17 Thread reviewboard
Comment #1 on issue 3171 by chip...@gmail.com: RBTools: A critical bug for determining SCM type? http://code.google.com/p/reviewboard/issues/detail?id=3171 We can use an OrderedDict, but it's not a guaranteed fix, as we can't expect a certain order from Python Entrypoints. The recommendat