Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Updates: Status: ThirdParty Comment #7 on issue 3312 by trowb...@gmail.com: Diffs without embedded commit IDs can not be used http://code.google.com/p/reviewboard/issues/detail?id=3312 Yeah, there's a lot that rbtools does in order to create diffs that contain enough information for various different SCMs and hosting services. You'll either have to switch to using it to post (you could also use 'rbt diff' if you really want to use the API yourself) or re-implement some of that logic. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Comment #6 on issue 3312 by bruce.c...@gmail.com: Diffs without embedded
commit IDs can not be used
http://code.google.com/p/reviewboard/issues/detail?id=3312
Sorry - I just installed 2.0.1 and found that uploading the same diff
*does* work - it shows 'Revision UNKNOWN' but still works. So it's not
something that's changed between 2.0.1 and 2.0.2
The hg postreview code handles git diffs by adding a header:
if opts.get('git') or ui.configbool('diff', 'git'):
# Git diffs don't include the revision numbers with each file,
so
# we have to put them in the header instead.
output += "# Node ID " + node.hex(r.node()) + "\n"
output += "# Parent " + node.hex(parent.node()) + "\n"
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Comment #5 on issue 3312 by gmiroshn...@rebbix.com: Diffs without embedded commit IDs can not be used http://code.google.com/p/reviewboard/issues/detail?id=3312 That's right, dropping "--git" does generate a diff acceptable for Review Board. While diffs without commit IDs are still broken and base_commit_id param is a bit misleading, that workaround works for me. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Comment #4 on issue 3312 by bruce.c...@gmail.com: Diffs without embedded commit IDs can not be used http://code.google.com/p/reviewboard/issues/detail?id=3312 I think this problem is (was?) caused by using git diffs by default, with the following in mercurial.ini/.hgrc: [diff] git = True However, I've just tried posting with this configuration on an instance with the base commit id fix that's in 2.0.2 and the diff does display correctly, with the revision shown as "Revision UNKNOWN". -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Comment #3 on issue 3312 by george.m...@gmail.com: Diffs without embedded commit IDs can not be used http://code.google.com/p/reviewboard/issues/detail?id=3312 Just tried to use "rbt post" which failed too, but maybe this is a separate issue: https://gist.github.com/laggyluke/cf1c8885948621a4afa2 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Comment #2 on issue 3312 by george.m...@gmail.com: Diffs without embedded commit IDs can not be used http://code.google.com/p/reviewboard/issues/detail?id=3312 Unfortunately I'm not using RBTools, I talk directly to Web API. I've looked into how this is handled by RBTools and I couldn't find anything - just some bits for handling empty files, but that doesn't seem relevant. I've also checked this bug against the latest master (9469487cff4e6e1353080581f808cd0f43a39a0d) and it's still there. Maybe I misunderstood how base_commit_id should work, so I've posted the question on mailing list (pending moderation). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Updates: Status: NeedInfo Comment #1 on issue 3312 by trowb...@gmail.com: Diffs without embedded commit IDs can not be used http://code.google.com/p/reviewboard/issues/detail?id=3312 The base commit ID is generally different from the file IDs embedded in the diffs (one is the revision of the commit, the others are the specific hashes of the file data). Can you do a little investigation and see how your method differs from what RBTools does for bitbucket mercurial repositories? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
