Re: Issue 3824 in reviewboard: Git hooks not working

Comment #12 on issue 3824 by kdari...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 I found the problem it was with the git log --pretty=format in function get_commit_message. Where git_command was using --pretty=format:%B which I have changed

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #11 on issue 3824 by kdari...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 Yes I did here is the git log output $ git log -2 commit a47d5832b1da763e9c9940a678eecd0357c767c2 Author: Pratap Date: Wed Jun 3 09:52:16 2015 +0530 foo12

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #10 on issue 3824 by trowb...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 Are you stamping your commit messages with 'rbt stamp' before pushing? -- You received this message because this project is configured to send all issue notificat

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #9 on issue 3824 by kdari...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 I am using the same model as described here https://www.reviewboard.org/docs/manual/2.5/users/getting-started/workflow/ .. Is there anything I am missing here? Wh

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #8 on issue 3824 by kdari...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 Review request exist (used "rbt post" command to create it) and already created but not sure why it is still taking the "review_request_id" as "0" -- You received

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #7 on issue 3824 by trowb...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 the git-hook-check-approval hook verifies that there's an existing review request for the pushed change, which is listed in the commit message, and that said revi

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #6 on issue 3824 by kdari...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 Thanks, I have updated to 0.7.3 but now I get "review_request_id" as "0" all the time by default. Its not reading the commit message as defined in the function "g

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #5 on issue 3824 by trowb...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 This bug fix will ship in 0.7.3 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust yo

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #4 on issue 3824 by kdari...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 I am facing the same issue RBT version is as below $ rbt --version RBTools 0.7.2 (RBTools-0.7.2-1.el6.noarch) Upgraded rbtools as well but no luck .. $ git push Co

Re: Issue 3824 in reviewboard: Git hooks not working

Updates: Status: Fixed Comment #3 on issue 3824 by trowb...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 Fixed in release-0.7.x (b349fb7). Thanks! -- You received this message because this project is configured to send all issue notifica

Re: Issue 3824 in reviewboard: Git hooks not working

Comment #2 on issue 3824 by tienv2...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 I got this one -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification

Re: Issue 3824 in reviewboard: Git hooks not working

Updates: Status: Confirmed Labels: Project-RBTools EasyFix Milestone-RBTools-Release0.7.x Component-RBTools Comment #1 on issue 3824 by chip...@gmail.com: Git hooks not working https://code.google.com/p/reviewboard/issues/detail?id=3824 Looks like there's a second execute() function