Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

that line RequestHeader set X-Forwarded-Port "443" is commented out with #, 
that's why it's bold.. Should have just removed that line.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

The hostname there is correct. The upstream rule refers to a remote server, 
or rather the docker container that's running Review Board, and I only have 
Nginx as reverse proxy, no Apache. A short update, I tried to go back to just 
using Apache again, with my default SSL settings etc.
This is the VirtualHost:

  ServerName our.domain.com
  ProxyRequests Off
  ProxyPreserveHost On

  ProxyPass /rb/ http://rb:8000/rb/
  ProxyPassReverse /rb/ http://rb:8000/rb/
  RequestHeader set X-Forwarded-Proto "https"
#  RequestHeader set X-Forwarded-Port "443"

  
require all granted
  

And now this works. I'm totally confused, because I'm sure I've had this 
setup prior to testing on Nginx.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Username:Password:Forgot your password?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Don't you think it's strange that this works for Firefox, Edge and even 
Chrome logging in using IP


Files:
- nginx.conf
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

It sounds more like the reverse proxy. We test with reverse proxies and the 
latest versions of Google Chrome, and I'm confident this is a setup issue and 
not a bug in Review Board.

What reverse proxy are you using, and what's the configuration? How do you 
have things set up with Nginx?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Figured out this only applies to newer versions of Google Chrome, whereas 
Firefox and Edge both works fine. I think you better look into this.
ReviewBoard on a non-root path behind a reverse proxy.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Ok, so I've been stuck here for a while now. I totally dropped Apache, even 
though I eventually want to go back to it, but I attempted removing SSL for now 
from configuration and running with Nginx instead. I get to login screen at 
both http://my-domain/rb/ and http://my-ip/rb/, but I am only able to login 
from http://my-ip/rb/. Logging in from http://my-domain/rb/ just reloads the 
login view. 

I tried adding the --domain-name="my-domain" flag on site install.
Any previous experience on this issue?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Thank you, I just stumbled upon this while researching django's equivalent 
to tomcat's context path. I guess this will solve all my issues. I haven't 
worked with django applications before.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

You can continue to serve Review Board out of `/rb/`. The trick is the 
links, and fortunately Review Board has you covered here. There's a `SITE_ROOT` 
variable that specifies what the prefix should be to the URL. This is normally 
asked during `rb-site install`, but you can set it manually in 
`$sitedir/conf/settings_local.py` by setting:

```
SITE_ROOT = '/rb/'
```

You should see it already in there as `SITE_ROOT = ''`, meaning no prefix. 
Give that a try, it should take care of the URLs.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Our requirement is that the application isn't served at the root path, so 
I've been trying to get it to work at e.g.: /rb/ using Apache as a reverse 
proxy. If there's another, better way to solve this I'm open to suggestions.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Reason for that is that we have links that we build dynamically in 
JavaScript, and in payloads unparseable by the module, so you're going to have 
links coming from different places that will be in the other format.

What are you needing the module for?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[Christian Hammond]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Ah, mod_proxy_html. That would explain it. We do not support any modules 
that rewrite our HTML, unfortunately. They cannot get it right for all our 
uses, and _will_ fail. You'll have to disable that to properly use Review Board.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

I was able to fix the icon img by adding srcset to the rule for img tags in 
mod_proxy_html:
ProxyHTMLLinks  img  src srcset

original:

result:


Although the second url in srcset is not rewritten.

However, the onclick event in list item elements of the page_sidebar is 
quite a bit different.

All0

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Files:
- virtual-host.txt
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Files:
- view-source-dashboard.html
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.