Re: Binary Files handling in RB 1.0.5

2009-12-02 Thread Kunjal
Chris, I think we have not updated post-review for a while. Where to find it in RB website? Can you point me location? Kunjal On Dec 1, 5:22 pm, Christian Hammond chip...@chipx86.com wrote: Tom is right, they should be filtered so long as Perforce has them listed as binary files. How

Re: ValueError: No JSON object could be decoded

2009-12-02 Thread Christian Hammond
Hi, Is it really reviewboard.com that you're trying to access? Because we don't own that domain :) What's specifying that domain? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 2, 2009 at 4:10

Re: post-review with bypass proxy settings in Internet Explorer

2009-12-02 Thread Christian Hammond
Yeah, modifying postreview.py isn't ideal. It was just one suggestion. What I'd like to see, I think, is an optional configuration variable in the user's .reviewboardrc that allows users to control post-review's proxy settings manually. Christian -- Christian Hammond - chip...@chipx86.com

Re: Binary Files handling in RB 1.0.5

2009-12-02 Thread Christian Hammond
Hi Kunjal, See: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ And the section on nightlies at: http://www.reviewboard.org/docs/manual/dev/admin/installation/development-releases/ Christian -- Christian Hammond - chip...@chipx86.com Review Board -

Re: post-review with bypass proxy settings in Internet Explorer

2009-12-02 Thread Chris Clark
My 2 cents. Modifying the registry and then restoring is not a great idea. I can see why you are doing it but I'd encourage you to NOT do this. There is a potential here for a background web app to fail (e.g. web browser based IM tool). I'd be tempted to monkey patch urllib(2), presumably

Re: ValueError: No JSON object could be decoded

2009-12-02 Thread Chris Clark
Have you tried using the: --server= flag? RE the version of reviewboard, if this is a new install I would go ahead and use 1.0.5.1 this shouldn't impact the error you are seeing but why use an old version when you can use the new stable one ;-) Chris Christian Hammond wrote: Hi, Is

Re: Submitting patches, subversion post-review support for already committed revisions

2009-12-02 Thread Christian Hammond
Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. post-review with Subversion should support renames and