Re: Does Review Board support GitHub Pull Request?

Thanks for the update Christian. Really great to hear progress. What's the rough ETA for 4.0? @vinodkone > On Jun 6, 2017, at 11:18 PM, Christian Hammond > wrote: > > Hi Vinod, > > This is in development for Review Board 4.0. It depends on the DVCS work > being

Re: Does Review Board support GitHub Pull Request?

Hi Vinod, This is in development for Review Board 4.0. It depends on the DVCS work being built in that release. We have a working prototype of the functionality needed to mirror pull requests to Review Board. However, due to the limitations in GitHub's pull requests, we won't be able to mirror

Re: Attachment uploads

We've never allowed arbitrary users to upload files on another review request without them being admins (which is still allowed). It's otherwise not allowed on the API or UI levels. I'd be very curious to learn more about your prior setup. Is there any chance your copy was modified? Christian

Re: Administrative Emails

Christian, We did some testing and it appears that the error is caused when a call is made to the Web API and passes a blank password. Setting the password to an invalid password appear to work correctly. This curl command triggers the issue. curl -u "username":""

Re: Review Board with Mercurial - The file "path/to/file" (revision ) was not found in the repository.

Hi Andrew, Python 2.5.9+ performs SSL certificate validation when performing HTTPS requests. If the SSL certificate is self-signed, expired, or otherwise invalid, the requests will fail. It sounds like this is the case here. I imagine you're using a self-signed certificate? There's unfortunately

Posting a new Review in 2.5.10

Hi, Since upgrading to RB 2.5.10 our developers have noticed they can not post a review without uploading a diff. Previously, using the web interface you were able to create a RB form without a diff – Can we configure RB to allow this again? Thanks Rob -- Supercharge your Review Board with

Re: Posting a new Review in 2.5.10

Hi Rob, This hasn't changed. You can still post review requests in the New Review Request page that don't require diffs by selecting "(None - File attachments only)" on the left. I just verified this on 2.5. Christian On Wed, Jun 7, 2017 at 1:25 AM, 'Rob Backhurst' via reviewboard <

Re: Integrity Error: 1062 Duplicate Entry

Hi Rob, Yeah, setting the field to null. There are unique indexes on (repository_id, commit_id) and (repository_id, changenum). It's fine for there to be multiple review requests with the same changenum or commit_id so long as they have different repository_ids. If there are duplicates, it'd be

Re: Attachment uploads

Hi Rob, It's never been intended for anyone but the owner of the review request to be able to upload attachments to a review request. Review requests are not collaborative in this way. The only users who can modify another user's review request are administrators or those with special permissions

Attachment uploads

Hi, Since we upgraded to RB 2.5.10 there has been a change in the way our developers can upload attachments. Attachments added by anyone other than the submitter do not seem to upload. This is because it puts the RB form into a draft state and only the submitter has visibility

Re: Attachment uploads

Hi Christian, Thanks for the quick reply! So the menu options for other users to upload files shouldn't be available? Is this a bug? We upgraded from 1.7.22 - perhaps also a bug in that version that allowed users to do it? Thanks Rob On Wednesday, 7 June 2017 09:15:16 UTC+1, Christian

Re: Posting a new Review in 2.5.10

Hi Rob, That's correct. The review request is only available for file attachments at that point. That's how it's been since Review Board 1.6. You can't create a review request for a repository without providing a diff. If you have a diff, you can create a review request against the repository

Re: Integrity Error: 1062 Duplicate Entry

Can you look for all review requests with changenum 1701871 (possibly commit_id with that value --it's a string in this case), see what turns up? Christian On Wed, Jun 7, 2017 at 03:37 'Rob Backhurst' via reviewboard < reviewboard@googlegroups.com> wrote: > Hi Christian, > > This is from our

Re: Attachment uploads

Oh and yes, anyone can add comments so thats fine... On Wednesday, 7 June 2017 09:10:01 UTC+1, Rob Backhurst wrote: > > Hi, > > > Since we upgraded to RB 2.5.10 there has been a change in the way our > developers can upload attachments. > > > Attachments added by anyone other than the submitter

Re: Integrity Error: 1062 Duplicate Entry

Hi Christian, This is from our DBA... ok, in that case we either have no problematic dupes or we are not sure how to find them. All dupes mentioned before have same changenum but different repository_id.. All items returned by executing below code have different repository_id: “select

Re: Posting a new Review in 2.5.10

Hi Christian, You'll have to excuse me, i do't use ReviewBoard myself so just relaying messages from our dev team. When you do this then you are unable to add a diff at a later stage. It creates the form as a non-repository form. The workflow we sometimes use is: 1. Create form and fill in