Re: Cache collisions with memcached
On Thursday 08 April 2010 01:18:33 am Christian Hammond wrote: > The very first part of the key contains the site site's domain, so as long > as each reviewboard instance is using a different domain, it should work. > Are you running subdir installs? It's possible that could cause problems. Does this site domain include the port number as well ? Regards. Gilles. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using "remove me" as the subject.
Re: Cache collisions with memcached
That'd be good, yeah. The code would have to look for settings.SITE_ROOT, and it should be optional (as users of Djblets may not use SITE_ROOT). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Apr 7, 2010 at 5:08 PM, Chris Trimble wrote: > On Wed, Apr 7, 2010 at 4:18 PM, Christian Hammond wrote: > >> Are you running subdir installs? It's possible that could cause problems. >> > > Yup, I'm betting that's it. We have a central reviewboard server with > subdirs. Should I look at patching that code in djblets? > > - Chris > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using "remove me" as the subject.
Re: Cache collisions with memcached
On Wed, Apr 7, 2010 at 4:18 PM, Christian Hammond wrote: > Are you running subdir installs? It's possible that could cause problems. > Yup, I'm betting that's it. We have a central reviewboard server with subdirs. Should I look at patching that code in djblets? - Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using "remove me" as the subject.
Re: Cache collisions with memcached
I've never seen that, and we're pretty careful to key off everything with unique data representing a particular diff. It worries me that you're seeing this. The very first part of the key contains the site site's domain, so as long as each reviewboard instance is using a different domain, it should work. Are you running subdir installs? It's possible that could cause problems. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Apr 7, 2010 at 3:39 PM, Chris Trimble wrote: > Have people who have widely deployed reviewboard even seen diffs showing up > in the wrong review? I just have. A random other file would be shown in > the place of a diff section. > > It turned out that memcached was having issues, I imagine a key collision? > I shut it down and the problem went away, restarted and problem stayed > away. > > Anyone ever see anything similar? Sharing a memcached instance between > reviewboards should be doable, shouldn't it? > > - Chris > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using "remove me" as the subject.
Cache collisions with memcached
Have people who have widely deployed reviewboard even seen diffs showing up in the wrong review? I just have. A random other file would be shown in the place of a diff section. It turned out that memcached was having issues, I imagine a key collision? I shut it down and the problem went away, restarted and problem stayed away. Anyone ever see anything similar? Sharing a memcached instance between reviewboards should be doable, shouldn't it? - Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe, reply using "remove me" as the subject.
