Re: Handling of files attached to a review request deleted at a later revision in Subversion

2012-01-10 Thread Thilo-Alexander Ginkel
On Tue, Jan 10, 2012 at 11:22, Thilo-Alexander Ginkel  wrote:
> we are currently struggling with a minor issue with our Review Board
> (v1.6.1) installation: If we reference a file from Subversion (as r1)
> in a given review request that has been deleted in a later revision
> (let's say, r2) along with the directory hosting it, Review Board is
> unable to display the review request (after clearing memcached) as it
> is unable to find the file in the Subversion repository. AFAICS this
> is caused by the fact that Review Board attempts to locate the file
> (using a PROPFIND) in a later revision r2+x, which fails.

Just for completeness: This is the backtrace I am getting (50149 is
the current HEAD revision):

-- 8< --Traceback (most recent call last):
  File "/usr/lib64/python2.6/site-packages/reviewboard/diffviewer/views.py",
line 151, in view_diff
interdiffset, highlighting, True)
  File "/usr/lib64/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",
line 1071, in get_diff_files
large_data=True)
  File "/usr/lib64/python2.6/site-packages/djblets/util/misc.py", line
156, in cache_memoize
data = lookup_callable()
  File "/usr/lib64/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",
line 1070, in 
enable_syntax_highlighting)),
  File "/usr/lib64/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",
line 551, in get_chunks
old = get_original_file(filediff)
  File "/usr/lib64/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",
line 364, in get_original_file
large_data=True)[0]
  File "/usr/lib64/python2.6/site-packages/djblets/util/misc.py", line
156, in cache_memoize
data = lookup_callable()
  File "/usr/lib64/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",
line 363, in 
data = cache_memoize(key, lambda: [fetch_file(file, revision)],
  File "/usr/lib64/python2.6/site-packages/reviewboard/diffviewer/diffutils.py",
line 342, in fetch_file
data = tool.get_file(file, revision)
  File "/usr/lib64/python2.6/site-packages/reviewboard/scmtools/svn.py",
line 138, in get_file
raise FileNotFoundError(path, revision, str(e))
FileNotFoundError: The file '/x/X.java' could not be found in the
repository: '/subversion/x/!svn/bc/50149/x/X.java' path not found
-- 8< --

Regards,
Thilo

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Handling of files attached to a review request deleted at a later revision in Subversion

2012-01-10 Thread Thilo-Alexander Ginkel
Hi there,

we are currently struggling with a minor issue with our Review Board
(v1.6.1) installation: If we reference a file from Subversion (as r1)
in a given review request that has been deleted in a later revision
(let's say, r2) along with the directory hosting it, Review Board is
unable to display the review request (after clearing memcached) as it
is unable to find the file in the Subversion repository. AFAICS this
is caused by the fact that Review Board attempts to locate the file
(using a PROPFIND) in a later revision r2+x, which fails.

Is anyone else seeing this issue?

Thanks,
Thilo

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en