Re: How to customize :: Add a new field to each review comment

2010-02-26 Thread Christian Hammond
Django-tagging would still require a lot of work to implement properly. Once
you're at the point of modifying Review Board to this degree, you may as
well just add this to Review Board directly.

This sort of feature request is fairly common, and we've been discussing to
what degree we want to implement it.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 26, 2010 at 11:36 AM, Stodge  wrote:

> Could you use the django-tagging application? I'm not sure if that
> would help but I thought I'd suggest it.
>
> On Feb 7, 6:53 pm, B S Srinidhi  wrote:
> > Hi,
> >
> > I'm fairly new to ReviewBoard (and Django :) and need some help in
> > customizing RB for an internal deployment.
> >
> > I would like to introduce a "classification" field for each review
> > comment. This field will basically be a dropdown list of classifications
> > - such as "Memory leak", "Return value check", etc. This dropdown should
> > be available to the reviewer in all places where (s)he can enter a
> > review comment.
> >
> > How do I achieve this? I found that the UI changes would go inside
> > reviewboard/templates/reviews/ but can't figure out where and do I need
> > to change for the database update. Do I need to define a new function in
> > reviewboard/reviews/models.py? Ah yes, how do I make an 'admin' page
> > entry for this.
> >
> > Any help on this regard would be great!!
> >
> > Srinidhi.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: How to customize :: Add a new field to each review comment

2010-02-26 Thread Stodge
Could you use the django-tagging application? I'm not sure if that
would help but I thought I'd suggest it.

On Feb 7, 6:53 pm, B S Srinidhi  wrote:
> Hi,
>
> I'm fairly new to ReviewBoard (and Django :) and need some help in
> customizing RB for an internal deployment.
>
> I would like to introduce a "classification" field for each review
> comment. This field will basically be a dropdown list of classifications
> - such as "Memory leak", "Return value check", etc. This dropdown should
> be available to the reviewer in all places where (s)he can enter a
> review comment.
>
> How do I achieve this? I found that the UI changes would go inside
> reviewboard/templates/reviews/ but can't figure out where and do I need
> to change for the database update. Do I need to define a new function in
> reviewboard/reviews/models.py? Ah yes, how do I make an 'admin' page
> entry for this.
>
> Any help on this regard would be great!!
>
> Srinidhi.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: How to customize :: Add a new field to each review comment

2010-02-26 Thread Christian Hammond
Hi Srinidhi,

Sorry for not getting back to you on this.

The data for comments are stored in reviewboard/reviews/models.py. You'd
need to update the API (webapi/) and the UI (htdocs/media/rb/js/*) and the
review request page (reviews/views.py) and probably more things.

You're going to hit a problem down the road where you'll become less and
less compatible with upstream. It's possible that we'd implement similar
functionality in the future, but you guys would have to deal with the
migration.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sun, Feb 7, 2010 at 3:53 PM, B S Srinidhi  wrote:

> Hi,
>
> I'm fairly new to ReviewBoard (and Django :) and need some help in
> customizing RB for an internal deployment.
>
> I would like to introduce a "classification" field for each review
> comment. This field will basically be a dropdown list of classifications
> - such as "Memory leak", "Return value check", etc. This dropdown should
> be available to the reviewer in all places where (s)he can enter a
> review comment.
>
> How do I achieve this? I found that the UI changes would go inside
> reviewboard/templates/reviews/ but can't figure out where and do I need
> to change for the database update. Do I need to define a new function in
> reviewboard/reviews/models.py? Ah yes, how do I make an 'admin' page
> entry for this.
>
> Any help on this regard would be great!!
>
> Srinidhi.
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

How to customize :: Add a new field to each review comment

2010-02-07 Thread B S Srinidhi
Hi,

I'm fairly new to ReviewBoard (and Django :) and need some help in
customizing RB for an internal deployment.

I would like to introduce a "classification" field for each review
comment. This field will basically be a dropdown list of classifications
- such as "Memory leak", "Return value check", etc. This dropdown should
be available to the reviewer in all places where (s)he can enter a
review comment.

How do I achieve this? I found that the UI changes would go inside
reviewboard/templates/reviews/ but can't figure out where and do I need
to change for the database update. Do I need to define a new function in
reviewboard/reviews/models.py? Ah yes, how do I make an 'admin' page
entry for this.

Any help on this regard would be great!!

Srinidhi.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en