Re: Not quite understanding the diff validation

[Christian Hammond]

Hi Galen,

When generating the diff, are you always generating relative to a commit
that's already been pushed upstream, or are you generating relative to a
commit that might not be upstream? If the latter, you'll need to send two
diffs across: A parent diff (from a pushed commit to the base commit you
want to review against), and the diff you want reviewed.

Usually when people see things like this, it's due to the lack of a parent
diff in an upload when one is needed.

As for the revisions, they should be specified on the 'diff -r' line in the
diff, one per file.

If it's a diff between two commits, it will look like:

diff -r  -r  

If it's a diff between a commit and a working copy:

diff -r  

There are also variants on the diff format. Git-style diffs have other
things going on, but I assume you're not using them?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, Apr 11, 2016 at 1:25 PM, Galen Elfert  wrote:

> Hi,
> In order to incorporate Reviewboard into a slightly unorthodox
> Mercurial-based workflow, I created a script that generates a diff by
> identifying changeset ranges and files using keywords, and then uses this
> diff to post a new review request.
> It's been working pretty well so far, but lately it's failed a few times.
> The problem happens when changes in the diff have not been pushed to the
> server yet. Reviewboard Validation looks for the files on the server using
> a revision (which I assume it gets from the diff) that's not there.
> What's weird is that sometimes it works. My colleague was able to post a
> review request based on changes that had not been pushed. But when he went
> to update the request with a new diff it failed.
>
> I guess my question is, when Reviewboard is validating a diff, where does
> it get the revision number from to build the URL? Is it taking the first
> revision listed in the diff for each file?
>
> Thanks,
> Galen
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Not quite understanding the diff validation

[Galen Elfert]

Hi, 
In order to incorporate Reviewboard into a slightly unorthodox 
Mercurial-based workflow, I created a script that generates a diff by 
identifying changeset ranges and files using keywords, and then uses this 
diff to post a new review request. 
It's been working pretty well so far, but lately it's failed a few times. 
The problem happens when changes in the diff have not been pushed to the 
server yet. Reviewboard Validation looks for the files on the server using 
a revision (which I assume it gets from the diff) that's not there. 
What's weird is that sometimes it works. My colleague was able to post a 
review request based on changes that had not been pushed. But when he went 
to update the request with a new diff it failed. 

I guess my question is, when Reviewboard is validating a diff, where does 
it get the revision number from to build the URL? Is it taking the first 
revision listed in the diff for each file?

Thanks, 
Galen

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.