Re: RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

2015-05-06 Thread Steve
Hi Chris, Just to close the loop on this topic - the problem with the diffs that I mentioned turned out to be a memcache issue. Turns out that using memcache on a test machine where you're continually deleting and recreating a perforce depot and rb site, thus reusing change list numbers, can

Re: RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

2015-05-06 Thread Steve
Issue 3864 created. Thanks! --Steve On Tuesday, May 5, 2015 at 7:14:07 PM UTC-7, Christian Hammond wrote: > > Hi Steve, > > Glad it hear it (with the exception of the diff not being correct). > > I'd appreciate a bug report on it. I won't be able to get to this right > away, so having all thes

Re: RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

2015-05-05 Thread Christian Hammond
Hi Steve, Glad it hear it (with the exception of the diff not being correct). I'd appreciate a bug report on it. I won't be able to get to this right away, so having all these details will help for later. Thanks! Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.r

Re: RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

2015-05-05 Thread Steve
Hi Chris, The good news is, your diagnosis is correct. Use of '-g no' got past the error. The bad news is, the diff posted is not correct. But I found that the diff posted with 0.6.3 is the same incorrect diff (it's incomplete and appears to be a single change instead of a range), so I'm goi

Re: RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

2015-05-05 Thread Christian Hammond
Hi Steve, This looks like a bug with the commit message guessing feature and Perforce revision ranges. Can you try running the same command with '-g no' ? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On

RBTools 0.7.2: posting a review using a range of perforce change lists no longer works

2015-05-05 Thread Steve
I've been doing a fair amount of testing of RBTools in preparation for moving to RB 2.0 and I've come across a few important issues that are preventing us from moving to RBTools 0.7. The 2 most significant ones appear to be regressions as my tests pass in 0.6.3 but fail in 0.7.2. The first iss