Re: --branch argument to post-review

2009-07-24 Thread Christian Hammond
Correct. It has nothing to do with fetching files from the repository.

The repository entry should always be configured to point to the very base
of the SVN tree. That way post-review can ask your current directory in your
checkout for the full SVN path to the directory, and Review Board can use
that to fetch the right file. Manual branch tracking isn't needed for this.

The branch field is useful when some work is being done on trunk, some on a
branch, and you want to communicate that to reviewers. It's free-form, and
can be used in different ways. For example, at VMware, we indicate which
branches the change will automerge down to by doing "branch > parent-branch
> main"

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Fri, Jul 24, 2009 at 3:12 PM, Ronak  wrote:

>
> Hi Eric,
>
> I am new to review board as well but I do not belive "--branch"
> actually refers to branch in the source. It is a field in review board
> which is a plan text.  If you open up review board for one of the
> submitted field you will see it as one of the form item that you can
> modify.
>
> We use perforce and can do the following
> post-review //depot/1.0.0/example.c
> or
> post-review //depot/1.0.1/example.c
>
> I have not used subversion so I am not sure what the syntax will be.
>
> You can find documentation on
> http://www.review-board.org/docs/manual/dev/users/tools/post-review/
> and for --branch it indicates
>
> --branch=
> Sets the review request’s branch field to the specified text.
>
> So I do not believe it is related to the source structure but more for
> documenting it in review board fields.
>
> Ronak
>
> On Jul 22, 3:38 pm, Eric Fung  wrote:
> > I am evaluating Review Board with a Subversion backend. We use the
> > following naming scheme in our repository:
> >
> >
> http://svn/subrep/project/trunkhttp://svn/subrep/project/branches/1.0.0http://svn/subrep/project/branches/1.0.1
> >
> > I've configured Review Board so that my repository URL is specified
> ashttp://svn/subrep/project.
> >
> > When I use post-review for post-commit requests, I've found that the --
> > branch argument does not seem to do anything. I have to specify files
> > like this:
> >
> > % post-review --username=efung --repository-url=http://svn/subrep/
> > project trunk/src/example.c
> >
> > Is --branch implemented? How should I be referring to files on another
> > branch?
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: --branch argument to post-review

2009-07-24 Thread Ronak

Hi Eric,

I am new to review board as well but I do not belive "--branch"
actually refers to branch in the source. It is a field in review board
which is a plan text.  If you open up review board for one of the
submitted field you will see it as one of the form item that you can
modify.

We use perforce and can do the following
post-review //depot/1.0.0/example.c
or
post-review //depot/1.0.1/example.c

I have not used subversion so I am not sure what the syntax will be.

You can find documentation on
http://www.review-board.org/docs/manual/dev/users/tools/post-review/
and for --branch it indicates

--branch=
Sets the review request’s branch field to the specified text.

So I do not believe it is related to the source structure but more for
documenting it in review board fields.

Ronak

On Jul 22, 3:38 pm, Eric Fung  wrote:
> I am evaluating Review Board with a Subversion backend. We use the
> following naming scheme in our repository:
>
> http://svn/subrep/project/trunkhttp://svn/subrep/project/branches/1.0.0http://svn/subrep/project/branches/1.0.1
>
> I've configured Review Board so that my repository URL is specified 
> ashttp://svn/subrep/project.
>
> When I use post-review for post-commit requests, I've found that the --
> branch argument does not seem to do anything. I have to specify files
> like this:
>
> % post-review --username=efung --repository-url=http://svn/subrep/
> project trunk/src/example.c
>
> Is --branch implemented? How should I be referring to files on another
> branch?

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---