Re: Can't add repository on development installation

2009-12-16 Thread Christian Hammond
Hi Ryan,

The Djblets versioning issue is due to our setup.py configuration appending
".dev" to the end by default, despite it not being a development release. We
haven't bumped the version since the last release. I'll do that probably
tomorrow (about to head to bed) but what you could do in the future when
hitting such a problem is run:

   ./setup.py install release

There's nothing special about our django-evolution egg. I don't know why you
hit that issue, but it just sounds like there was some sort of installation
quirk. Any chance you upgraded your distro since installing that? Perhaps it
installed into an older Python.

What we should do is just have prepare-dev.py go ahead and install all
dependencies, or make sure they're installed. It would eliminate the need
for additions to the docs.

I have a fix for the '_' issue that I'll commit tomorrow along with some
other fixes. With the holidays and all, things have been a little busy
around here so I'm a bit behind on some of these issues in the alpha
releases, but will hopefully have time soon to implement the other fixes.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Dec 14, 2009 at 12:19 AM, Ryan Oblak  wrote:

> Yes, this is for the 1.1 development series.  It's the HEAD from
> github.
>
> I tried running "./reviewboard/manage.py registerscmtools", but was
> met with this error:
>
> Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool:
> (Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
> ('Djblets>=0.5.6'))Unable to load SCMTool git =
> reviewboard.scmtools.git:GitTool: (Djblets 0.5.6.dev (/home/rroblak/
> workspace/djblets), Requirement.parse('Djblets>=0.5.6'))Unable to load
> SCMTool bzr = reviewboard.scmtools.bzr:BZRTool: (Djblets 0.5.6.dev (/
> home/rroblak/workspace/djblets), Requirement.parse('Djblets>=0.5.6'))
> Unable to load SCMTool cvs = reviewboard.scmtools.cvs:CVSTool:
> (Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
> ('Djblets>=0.5.6'))Unable to load SCMTool perforce =
> reviewboard.scmtools.perforce:PerforceTool: (Djblets 0.5.6.dev (/home/
> rroblak/workspace/djblets), Requirement.parse('Djblets>=0.5.6'))Unable
> to load SCMTool clearcase =
> reviewboard.scmtools.clearcase:ClearCaseTool: (Djblets 0.5.6.dev (/
> home/rroblak/workspace/djblets), Requirement.parse('Djblets>=0.5.6'))
> Unable to load SCMTool hg = reviewboard.scmtools.hg:HgTool: (Djblets
> 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
> ('Djblets>=0.5.6'))
>
> I tracked this down to the version specified in djblets/Djblets.egg-
> info/PKG-INFO.  I changed the version in this file from 0.5.6.dev to
> 0.5.6 and this error went away.  Seems like either the version should
> be changed so it doesn't kill the Requirement parser, or the
> Requirement parser should be changed so that it doesn't die on non-
> numeric versions.
>
> After changing the version to 0.5.6 in djblets/Djblets.egg-info/PKG-
> INFO, I tried to run registerscmtools again, but was met with this
> error:
>
> Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool: django-
> evolutionUnable to load SCMTool git =
> reviewboard.scmtools.git:GitTool: django-evolutionUnable to load
> SCMTool bzr = reviewboard.scmtools.bzr:BZRTool: django-evolutionUnable
> to load SCMTool cvs = reviewboard.scmtools.cvs:CVSTool: django-
> evolutionUnable to load SCMTool perforce =
> reviewboard.scmtools.perforce:PerforceTool: django-evolutionUnable to
> load SCMTool clearcase = reviewboard.scmtools.clearcase:ClearCaseTool:
> django-evolutionUnable to load SCMTool hg =
> reviewboard.scmtools.hg:HgTool: django-evolution
>
> To fix this I uninstalled my previous django-evolution installation
> (installed via SVN checkout as described here:
> http://code.google.com/p/django-evolution/)
> and reinstalled using your egg (easy_install -f "http://
> downloads.review-board.org/mirror/" django_evolution).  I'm not sure
> why my SVN installation didn't work.  When I uninstalled the SVN
> installation completely I was given a terse 'django-evolution not
> found' error, so it seems as though the django-evolution package was
> installed in some capacity, though somehow incorrectly.  At any rate,
> you may want to make a note of the django-evolution dependency in the
> developer documentation (I realize it's already in the admin
> documentation-- perhaps refactoring a separate 'dependencies' page
> would be helpful?).  Also, publicizing how to install your
> django_evolution egg may be of help to some.
>
> After getting django-evolution installed properly I was able to run
> registerscmtools without a hitch.  However, I am still getting a
> "global name '_' is not defined" validation error on the "Add
> repository" page.  It appears that this error is being caught
> upstream, as it is presented as a form validation error.  Accordingly,
> there is no associated stack trace 

Re: Can't add repository on development installation

2009-12-14 Thread Ryan Oblak
Yes, this is for the 1.1 development series.  It's the HEAD from
github.

I tried running "./reviewboard/manage.py registerscmtools", but was
met with this error:

Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool:
(Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets>=0.5.6'))Unable to load SCMTool git =
reviewboard.scmtools.git:GitTool: (Djblets 0.5.6.dev (/home/rroblak/
workspace/djblets), Requirement.parse('Djblets>=0.5.6'))Unable to load
SCMTool bzr = reviewboard.scmtools.bzr:BZRTool: (Djblets 0.5.6.dev (/
home/rroblak/workspace/djblets), Requirement.parse('Djblets>=0.5.6'))
Unable to load SCMTool cvs = reviewboard.scmtools.cvs:CVSTool:
(Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets>=0.5.6'))Unable to load SCMTool perforce =
reviewboard.scmtools.perforce:PerforceTool: (Djblets 0.5.6.dev (/home/
rroblak/workspace/djblets), Requirement.parse('Djblets>=0.5.6'))Unable
to load SCMTool clearcase =
reviewboard.scmtools.clearcase:ClearCaseTool: (Djblets 0.5.6.dev (/
home/rroblak/workspace/djblets), Requirement.parse('Djblets>=0.5.6'))
Unable to load SCMTool hg = reviewboard.scmtools.hg:HgTool: (Djblets
0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse
('Djblets>=0.5.6'))

I tracked this down to the version specified in djblets/Djblets.egg-
info/PKG-INFO.  I changed the version in this file from 0.5.6.dev to
0.5.6 and this error went away.  Seems like either the version should
be changed so it doesn't kill the Requirement parser, or the
Requirement parser should be changed so that it doesn't die on non-
numeric versions.

After changing the version to 0.5.6 in djblets/Djblets.egg-info/PKG-
INFO, I tried to run registerscmtools again, but was met with this
error:

Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool: django-
evolutionUnable to load SCMTool git =
reviewboard.scmtools.git:GitTool: django-evolutionUnable to load
SCMTool bzr = reviewboard.scmtools.bzr:BZRTool: django-evolutionUnable
to load SCMTool cvs = reviewboard.scmtools.cvs:CVSTool: django-
evolutionUnable to load SCMTool perforce =
reviewboard.scmtools.perforce:PerforceTool: django-evolutionUnable to
load SCMTool clearcase = reviewboard.scmtools.clearcase:ClearCaseTool:
django-evolutionUnable to load SCMTool hg =
reviewboard.scmtools.hg:HgTool: django-evolution

To fix this I uninstalled my previous django-evolution installation
(installed via SVN checkout as described here: 
http://code.google.com/p/django-evolution/)
and reinstalled using your egg (easy_install -f "http://
downloads.review-board.org/mirror/" django_evolution).  I'm not sure
why my SVN installation didn't work.  When I uninstalled the SVN
installation completely I was given a terse 'django-evolution not
found' error, so it seems as though the django-evolution package was
installed in some capacity, though somehow incorrectly.  At any rate,
you may want to make a note of the django-evolution dependency in the
developer documentation (I realize it's already in the admin
documentation-- perhaps refactoring a separate 'dependencies' page
would be helpful?).  Also, publicizing how to install your
django_evolution egg may be of help to some.

After getting django-evolution installed properly I was able to run
registerscmtools without a hitch.  However, I am still getting a
"global name '_' is not defined" validation error on the "Add
repository" page.  It appears that this error is being caught
upstream, as it is presented as a form validation error.  Accordingly,
there is no associated stack trace (unless there is some method of
grabbing stack traces on form validation errors that I am not aware
of).  I've attached a screenshot to a separate email sent to your
email address so that you can see exactly what I'm getting.

Thanks for your help.

Ryan


On Dec 13, 12:48 am, Christian Hammond  wrote:
> Hi Ryan,
>
> Is this using the 1.1 development series?
>
> The BackwardsIncompatibleChanges entry on this is quite old. What's really
> happening is that we're just not importing _ in whatever file we need it.
> Can you send me the backtrace on this?
>
> Since you're seeing the _ error, you're really seeing that it failed to
> create the repository, due to some sort of validation error. Once I have the
> backtrace, I should be able to fix this and let you know roughly what it
> should have reported.
>
> As for the missing entries in the drop-down, you'll need to run:
>
>     ./reviewboard/manage.py registerscmtools
>
> That should register all the SCMTools so you can use them properly. I'll
> make a note to add that to the docs.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Sun, Dec 13, 2009 at 12:36 AM, Ryan Oblak  wrote:
> > Hi all,
>
> > I'm trying to setup a local development installation of Review Board.
> > As per
> >http://www.reviewboard.org/docs/codebase/dev/getting-started/#

Re: Can't add repository on development installation

2009-12-13 Thread Christian Hammond
Hi Ryan,

Is this using the 1.1 development series?

The BackwardsIncompatibleChanges entry on this is quite old. What's really
happening is that we're just not importing _ in whatever file we need it.
Can you send me the backtrace on this?

Since you're seeing the _ error, you're really seeing that it failed to
create the repository, due to some sort of validation error. Once I have the
backtrace, I should be able to fix this and let you know roughly what it
should have reported.

As for the missing entries in the drop-down, you'll need to run:

./reviewboard/manage.py registerscmtools

That should register all the SCMTools so you can use them properly. I'll
make a note to add that to the docs.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sun, Dec 13, 2009 at 12:36 AM, Ryan Oblak  wrote:

> Hi all,
>
> I'm trying to setup a local development installation of Review Board.
> As per
> http://www.reviewboard.org/docs/codebase/dev/getting-started/#review-board
> I ran "python ./contrib/internal/prepare-dev.py".  However, when I
> started the development server and tried to add a repository via the
> admin ui I ran into a couple of problems.
>
> First, there was no "Repository type" option to select (the drop-down
> is empty).  I tracked this down to the scmtools_tool table being
> empty.  So, I inserted ('Git', 'reviewboard.scmtools.git.GitTool') via
> the sqlite3 cli (I copied this info from my production installation).
> Upon reload of the admin ui, Git now shows up in the "Repository type"
> drop-down.  Upon submission, though, I am met with a "global name '_'
> is not defined" error.  It appears that this error is being caught
> somewhere upstream, as this error is returned as a validation error
> (it's prefaced with a "Please correct the error below." message).
>
> It seems that scmtools_tool should be populated when prepare-dev.py is
> executed.  Currently, the data for scmtools_tool resides in /
> setup.py.  Any thoughts on how this data could be refactored so that
> it is inserted when prepare-dev.py is ran?
>
> Regarding the "global name '_' is not defined" error, I found this:
>
> http://code.djangoproject.com/wiki/BackwardsIncompatibleChanges#_nolongerinbuiltins
> Any ideas on how to resolve this error?
>
> Ryan
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en