Re: Can I send full diffs when publishing the review?
Hi Jon. I agree that it could be nice on some setups. We might be able to do something down the road for this but not immediately. As for customization of the e-mail template, this is something I would very much like to do in the future. Not for 1.5, but maybe after that. Christian On Friday, May 14, 2010, Jon wuservi...@gmail.com wrote: Hi Christian, I do realize performance could be a concern so I know this wouldn't be for everyone and it would have to be a setting. But for teams that are small enough (server load) and ones that don't send huge chunks of code I think this would be great. One suggestion would be to limit the size of the email and truncate after that but I realize that may be additional work. It does seem like having templates or the ability to customize each email would make this easy to customize. Thanks! On May 14, 1:11 am, Christian Hammond chip...@chipx86.com wrote: Hi Jon, Including the full diff could certainly lead to overly large e-mails in many setups. For example, on a project I've been doing lately, I've had changes that spanned over 60 files with thousands of inserts, deletes and replaces. This would make for really long e-mails, which could increase the load on Review Board and the mail server. The e-mail today includes a link to the diff viewer. We could include a link to the raw diff as well. Would that be sufficient? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, May 13, 2010 at 8:42 PM, Jon wuservi...@gmail.com wrote: I just setup 1.5 beta 2 with Mercurial and postreview extension and it's working pretty well. However, one thing that people in my group are asking for is a full diff of the entire commit with the diff list in the publish email. I've seen that RB does this when you do a code review so is it easy to make it send the full diffs all the time? I realize they could be big but we tend to do smaller commits and we've been sending out text diffs by email this whole time anyways. Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can I send full diffs when publishing the review?
Thanks Christian! Keep up with good work with 1.5 it's working really well. On May 17, 5:24 pm, Christian Hammond chip...@chipx86.com wrote: Hi Jon. I agree that it could be nice on some setups. We might be able to do something down the road for this but not immediately. As for customization of the e-mail template, this is something I would very much like to do in the future. Not for 1.5, but maybe after that. Christian On Friday, May 14, 2010, Jon wuservi...@gmail.com wrote: Hi Christian, I do realize performance could be a concern so I know this wouldn't be for everyone and it would have to be a setting. But for teams that are small enough (server load) and ones that don't send huge chunks of code I think this would be great. One suggestion would be to limit the size of the email and truncate after that but I realize that may be additional work. It does seem like having templates or the ability to customize each email would make this easy to customize. Thanks! On May 14, 1:11 am, Christian Hammond chip...@chipx86.com wrote: Hi Jon, Including the full diff could certainly lead to overly large e-mails in many setups. For example, on a project I've been doing lately, I've had changes that spanned over 60 files with thousands of inserts, deletes and replaces. This would make for really long e-mails, which could increase the load on Review Board and the mail server. The e-mail today includes a link to the diff viewer. We could include a link to the raw diff as well. Would that be sufficient? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, May 13, 2010 at 8:42 PM, Jon wuservi...@gmail.com wrote: I just setup 1.5 beta 2 with Mercurial and postreview extension and it's working pretty well. However, one thing that people in my group are asking for is a full diff of the entire commit with the diff list in the publish email. I've seen that RB does this when you do a code review so is it easy to make it send the full diffs all the time? I realize they could be big but we tend to do smaller commits and we've been sending out text diffs by email this whole time anyways. Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can I send full diffs when publishing the review?
E-mail templates will solve all kind of this problems. On May 14, 10:11 am, Christian Hammond chip...@chipx86.com wrote: Hi Jon, Including the full diff could certainly lead to overly large e-mails in many setups. For example, on a project I've been doing lately, I've had changes that spanned over 60 files with thousands of inserts, deletes and replaces. This would make for really long e-mails, which could increase the load on Review Board and the mail server. The e-mail today includes a link to the diff viewer. We could include a link to the raw diff as well. Would that be sufficient? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, May 13, 2010 at 8:42 PM, Jon wuservi...@gmail.com wrote: I just setup 1.5 beta 2 with Mercurial and postreview extension and it's working pretty well. However, one thing that people in my group are asking for is a full diff of the entire commit with the diff list in the publish email. I've seen that RB does this when you do a code review so is it easy to make it send the full diffs all the time? I realize they could be big but we tend to do smaller commits and we've been sending out text diffs by email this whole time anyways. Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Can I send full diffs when publishing the review?
Hi Christian, I do realize performance could be a concern so I know this wouldn't be for everyone and it would have to be a setting. But for teams that are small enough (server load) and ones that don't send huge chunks of code I think this would be great. One suggestion would be to limit the size of the email and truncate after that but I realize that may be additional work. It does seem like having templates or the ability to customize each email would make this easy to customize. Thanks! On May 14, 1:11 am, Christian Hammond chip...@chipx86.com wrote: Hi Jon, Including the full diff could certainly lead to overly large e-mails in many setups. For example, on a project I've been doing lately, I've had changes that spanned over 60 files with thousands of inserts, deletes and replaces. This would make for really long e-mails, which could increase the load on Review Board and the mail server. The e-mail today includes a link to the diff viewer. We could include a link to the raw diff as well. Would that be sufficient? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, May 13, 2010 at 8:42 PM, Jon wuservi...@gmail.com wrote: I just setup 1.5 beta 2 with Mercurial and postreview extension and it's working pretty well. However, one thing that people in my group are asking for is a full diff of the entire commit with the diff list in the publish email. I've seen that RB does this when you do a code review so is it easy to make it send the full diffs all the time? I realize they could be big but we tend to do smaller commits and we've been sending out text diffs by email this whole time anyways. Thanks! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
