Re: Code not to review by review requester.
I must confess that I feel compelled to ask: what is the use case you're trying to enforce? I mean, what's the point of limiting someone to see *his own* changes? or the comments? (which the poor sod would receive anyway, unless you suggest to intercept the email...) the only explanation I could come up with is that you give them a 'red pill' (or was it blue?) after the push honestly, I'm curious: I feel like I'm missing out on something that may be big! On Thu, Mar 8, 2012 at 9:15 PM, Christian Hammond wrote: > No, there's no patch. We specifically don't want to introduce this > functionality, as we don't believe there's any value to limiting who can > offer feedback on code, and there would be a lot of work required to make > it work the way you're asking. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > > On Thu, Mar 8, 2012 at 8:59 PM, Nilesh Jaiswal wrote: > >> Hi David, >> >> But this is the issue, how can we do this do you have any patch which >> will help me in this regard >> >> Regards, >> Nilesh J >> >> >> On Thu, Mar 8, 2012 at 10:16 PM, David Trowbridge wrote: >> >>> Review Board has no facilities for enforcing these kinds of policies. >>> >>> -David >>> >>> >>> On Thu, Mar 8, 2012 at 2:29 AM, Nilesh Jaiswal wrote: >>> Hi, In the review board, when user send review request he can review his own changes, But i want this to be restrict this and want only reviewer to whom review request is send can review the code, How to do this? Please suggestion. Regards, Nilesh J -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en >>> >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~--~~~~--~~--~--~--- >>> To unsubscribe from this group, send email to >>> reviewboard+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >> >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Code not to review by review requester.
No, there's no patch. We specifically don't want to introduce this functionality, as we don't believe there's any value to limiting who can offer feedback on code, and there would be a lot of work required to make it work the way you're asking. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Mar 8, 2012 at 8:59 PM, Nilesh Jaiswal wrote: > Hi David, > > But this is the issue, how can we do this do you have any patch which will > help me in this regard > > Regards, > Nilesh J > > > On Thu, Mar 8, 2012 at 10:16 PM, David Trowbridge wrote: > >> Review Board has no facilities for enforcing these kinds of policies. >> >> -David >> >> >> On Thu, Mar 8, 2012 at 2:29 AM, Nilesh Jaiswal wrote: >> >>> Hi, >>> >>> In the review board, when user send review request he can review his own >>> changes, But i want this to be restrict this and want only reviewer to whom >>> review request is send can review the code, How to do this? >>> >>> >>> Please suggestion. >>> >>> Regards, >>> Nilesh J >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~--~~~~--~~--~--~--- >>> To unsubscribe from this group, send email to >>> reviewboard+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >> >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Code not to review by review requester.
Hi David, But this is the issue, how can we do this do you have any patch which will help me in this regard Regards, Nilesh J On Thu, Mar 8, 2012 at 10:16 PM, David Trowbridge wrote: > Review Board has no facilities for enforcing these kinds of policies. > > -David > > > On Thu, Mar 8, 2012 at 2:29 AM, Nilesh Jaiswal wrote: > >> Hi, >> >> In the review board, when user send review request he can review his own >> changes, But i want this to be restrict this and want only reviewer to whom >> review request is send can review the code, How to do this? >> >> >> Please suggestion. >> >> Regards, >> Nilesh J >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en > > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Code not to review by review requester.
Review Board has no facilities for enforcing these kinds of policies. -David On Thu, Mar 8, 2012 at 2:29 AM, Nilesh Jaiswal wrote: > Hi, > > In the review board, when user send review request he can review his own > changes, But i want this to be restrict this and want only reviewer to whom > review request is send can review the code, How to do this? > > > Please suggestion. > > Regards, > Nilesh J > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
