Re: Custom post-review implementations making them easier proposal

2009-06-09 Thread Chris Clark
Christian Hammond wrote: > ...I also would like an rbapi (or something) package for all the > server communication code. This would be separate from RBTools, but > RBTools would use it. post-review would be greatly simplified by these > two changes. That would be awesome, we've had a couple of

Re: Custom post-review implementations making them easier proposal

2009-06-09 Thread Christian Hammond
Yep, sounds good to me. I'm out of town and am not as available as I normally am, so it might still be a few days before I start reviewing code, but the proposal is good. I have some further thoughts for making post-review more extensible, but I'd need the time to do it properly. What I'd like to

Re: Custom post-review implementations making them easier proposal

2009-06-05 Thread Chris Clark
Ritesh Nadhani wrote: > For one, I would be interested. We use Bazaar and and have been slowly > trying to intergrate ReviewBoard in our system. I looked into the > post-review and it does not seem to support Bazaar. I have already > extended it using the Mercurial example and override two or thre

Re: Custom post-review implementations making them easier proposal

2009-06-05 Thread Ritesh Nadhani
For one, I would be interested. We use Bazaar and and have been slowly trying to intergrate ReviewBoard in our system. I looked into the post-review and it does not seem to support Bazaar. I have already extended it using the Mercurial example and override two or three methods that the Mercurial c