subject:"Re\: How to create an initial code review \(post\-commit\)"

Re: How to create an initial code review (post-commit)

2015-06-29 Thread Carel Combrink

Hi Christian,

I have upgraded to 2.0.18 and created a new thread under Issues setting up 
subversion repo (svn+ssh) on Review Board 
 to 
continue the discussion. I think the topic of this thread does not cover 
the issue.

Regards,

On Monday, June 29, 2015 at 9:06:09 PM UTC+2, Christian Hammond wrote:
>
> Hi Carel,
>
> Definitely try 2.0.18. It has some SSH-related fixes that I'd want you to 
> try.
>
> Christian
>
> -- 
> Christian Hammond - chri...@beanbaginc.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
> On Sun, Jun 28, 2015 at 11:32 PM, Carel Combrink  > wrote:
>
>> Any Suggestions?
>>
>> I see version 2.0.18 was released, I am assuming upgrading would be the 
>> place to start for now?
>>
>> Regards
>>
>>
>> On Friday, June 26, 2015 at 10:07:21 AM UTC+2, Carel Combrink wrote:
>>>
>>>
>>> cd /tmp 
 DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh 
  

>>>
>>> From the above I get the following output:
>>> $ DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh 
>>> 
>>> Unable to import settings_local.py: No module named settings_local
>>>
>>> Please see https://www.reviewboard.org/docs/manual/dev/admin/
>>> for help setting up Review Board.
>>>
>>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to create an initial code review (post-commit)

2015-06-29 Thread Christian Hammond

Hi Carel,

Definitely try 2.0.18. It has some SSH-related fixes that I'd want you to
try.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

On Sun, Jun 28, 2015 at 11:32 PM, Carel Combrink 
wrote:

> Any Suggestions?
>
> I see version 2.0.18 was released, I am assuming upgrading would be the
> place to start for now?
>
> Regards
>
>
> On Friday, June 26, 2015 at 10:07:21 AM UTC+2, Carel Combrink wrote:
>>
>>
>> cd /tmp
>>> DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh 
>>>
>>
>> From the above I get the following output:
>> $ DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh
>> 
>> Unable to import settings_local.py: No module named settings_local
>>
>> Please see https://www.reviewboard.org/docs/manual/dev/admin/
>> for help setting up Review Board.
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to create an initial code review (post-commit)

2015-06-28 Thread Carel Combrink

Any Suggestions?

I see version 2.0.18 was released, I am assuming upgrading would be the 
place to start for now?

Regards


On Friday, June 26, 2015 at 10:07:21 AM UTC+2, Carel Combrink wrote:
>
>
> cd /tmp 
>> DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh  
>>
>
> From the above I get the following output:
> $ DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh 
> 
> Unable to import settings_local.py: No module named settings_local
>
> Please see https://www.reviewboard.org/docs/manual/dev/admin/
> for help setting up Review Board.
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to create an initial code review (post-commit)

2015-06-26 Thread Carel Combrink



> cd /tmp 
> DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh  
>

>From the above I get the following output:
$ DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh 

Unable to import settings_local.py: No module named settings_local

Please see https://www.reviewboard.org/docs/manual/dev/admin/
for help setting up Review Board.

Regarding the full/initial review:
The repository that I am testing with is rather small, about 4 files with 
rather low number of LOC. 
I do agree that for larger codebase projects it can be an issue to create 
such a review but unfortunately we are only now integrating tool based code 
reviews into our development process.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to create an initial code review (post-commit)

2015-06-25 Thread Christian Hammond

Oh also, try:

    cd /tmp
    DEBUG_RBSSH=1 DJANGO_SETTINGS_MODULE=reviewboard.settings rbssh 

Christian 

--  
Christian Hammond - christ...@beanbaginc.com  
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: Christian Hammond 
Reply: Christian Hammond >
Date: June 25, 2015 at 11:30:00 PM
To: reviewboard@googlegroups.com >, Carel 
Combrink >
Subject:  Re: How to create an initial code review (post-commit)

> Hi Carel,
>  
> For the manual invocation of rbssh with DEBUG_RBSSH=1, it sounds like you may 
> be running
> this in a directory that www-data can't write in. Can you try:
>  
> cd /tmp
> DEBUG_RBSSH=1 rbssh 
>  
> See if that gives the same error as without debug. I think you may be hitting 
> a bug that I'm
> looking into.
>  
> Normal ssh doesn't come into play at all, as we use a different SSH library 
> for communicating
> that offers us some flexibility in how keys are stored/accessed.
>  
> Regarding your original intent to post your entire repository for review, you 
> will in
> on way or another need to generate a diff. Note that realistically, unless 
> your repository
> is very small, nobody will be able to give it a thorough review, no matter 
> the code review
> tool. People are best able to review code when they can focus on smaller, 
> logical changes
> that work toward one goal. Otherwise, they tend to glance over and miss a lot 
> of things.
> The larger the change, the less they pay attention to details, and the more 
> they miss.
>  
> Christian
>  
> --
> Christian Hammond - christ...@beanbaginc.com
> Review Board - https://www.reviewboard.org
> Beanbag, Inc. - https://www.beanbaginc.com
>  
> -Original Message-
> From: Carel Combrink 
> Reply: reviewboard@googlegroups.com >
> Date: June 25, 2015 at 11:20:14 PM
> To: reviewboard@googlegroups.com >
> Subject: Re: How to create an initial code review (post-commit)
>  
>> If I ssh to the RB server and do the following (some steps I found on this
>> list):
>> $ sudo -s
>> $ sudo -u www-data -s
>> $ DEBUG_RBSSH=1 rbssh 
>>
>> I get the following error:
>> Traceback (most recent call last):
>> File "/usr/local/bin/rbssh", line 9, in 
>> load_entry_point('ReviewBoard==2.0.17', 'console_scripts', 'rbssh')()
>> File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/cmdline/rbssh.py"
>> , line 271, in main
>> filemode='w')
>> File "/usr/lib/python2.7/logging/__init__.py", line 1532, in basicConfig
>> hdlr = FileHandler(filename, mode)
>> File "/usr/lib/python2.7/logging/__init__.py", line 903, in __init__
>> StreamHandler.__init__(self, self._open())
>> File "/usr/lib/python2.7/logging/__init__.py", line 928, in _open
>> stream = open(self.baseFilename, self.mode)
>> IOError: [Errno 13] Permission denied: u'/home/myserver/rbssh-1281.log'
>>
>> Without debug I get:
>> Traceback (most recent call last):
>> File "/usr/local/bin/rbssh", line 9, in 
>> load_entry_point('ReviewBoard==2.0.17', 'console_scripts', 'rbssh')()
>> File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/cmdline/rbssh.py",
>> line 294, in main
>> client = SSHClient(namespace=options.local_site_name)
>> File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/ssh/client.py",
>> line 62, in __init__
>> self._load_storage()
>> File
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/ssh/client.py",
>> line 76, in _load_storage
>> self.DEFAULT_STORAGE)
>> File
>> "/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/conf/__init__.py",
>> line 54, in __getattr__
>> self._setup(name)
>> File
>> "/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/conf/__init__.py",
>> line 47, in _setup
>> % (desc, ENVIRONMENT_VARIABLE))
>> django.core.exceptions.ImproperlyConfigured: Requested setting
>> RBSSH_STORAGE_BACKEND, but settings are not configured. You must either
>> define the environment variable DJANGO_SETTINGS_MODULE or call
>> settings.configure() before accessing settings.
>>
>> But normal SSH works without any problems and logs in with the correct user
>> without asking for a password.
>> ssh svn.server.ip
>>
>> --
>> Supercharge your Review

Re: How to create an initial code review (post-commit)

2015-06-25 Thread Christian Hammond

Hi Carel,

For the manual invocation of rbssh with DEBUG_RBSSH=1, it sounds like you may 
be running this in a directory that www-data can't write in. Can you try:

    cd /tmp
    DEBUG_RBSSH=1 rbssh 

See if that gives the same error as without debug. I think you may be hitting a 
bug that I'm looking into.

Normal ssh doesn't come into play at all, as we use a different SSH library for 
communicating that offers us some flexibility in how keys are stored/accessed.

Regarding your original intent to post your entire repository for review, you 
will in on way or another need to generate a diff. Note that realistically, 
unless your repository is very small, nobody will be able to give it a thorough 
review, no matter the code review tool. People are best able to review code 
when they can focus on smaller, logical changes that work toward one goal. 
Otherwise, they tend to glance over and miss a lot of things. The larger the 
change, the less they pay attention to details, and the more they miss.

Christian 

--  
Christian Hammond - christ...@beanbaginc.com  
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: Carel Combrink 
Reply: reviewboard@googlegroups.com >
Date: June 25, 2015 at 11:20:14 PM
To: reviewboard@googlegroups.com >
Subject:  Re: How to create an initial code review (post-commit)

> If I ssh to the RB server and do the following (some steps I found on this
> list):
> $ sudo -s
> $ sudo -u www-data -s
> $ DEBUG_RBSSH=1 rbssh 
>  
> I get the following error:
> Traceback (most recent call last):
> File "/usr/local/bin/rbssh", line 9, in 
> load_entry_point('ReviewBoard==2.0.17', 'console_scripts', 'rbssh')()
> File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/cmdline/rbssh.py"
> , line 271, in main
> filemode='w')
> File "/usr/lib/python2.7/logging/__init__.py", line 1532, in basicConfig
> hdlr = FileHandler(filename, mode)
> File "/usr/lib/python2.7/logging/__init__.py", line 903, in __init__
> StreamHandler.__init__(self, self._open())
> File "/usr/lib/python2.7/logging/__init__.py", line 928, in _open
> stream = open(self.baseFilename, self.mode)
> IOError: [Errno 13] Permission denied: u'/home/myserver/rbssh-1281.log'
>  
> Without debug I get:
> Traceback (most recent call last):
> File "/usr/local/bin/rbssh", line 9, in 
> load_entry_point('ReviewBoard==2.0.17', 'console_scripts', 'rbssh')()
> File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/cmdline/rbssh.py",
> line 294, in main
> client = SSHClient(namespace=options.local_site_name)
> File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/ssh/client.py",
> line 62, in __init__
> self._load_storage()
> File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/ssh/client.py",
> line 76, in _load_storage
> self.DEFAULT_STORAGE)
> File
> "/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/conf/__init__.py",
> line 54, in __getattr__
> self._setup(name)
> File
> "/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/conf/__init__.py",
> line 47, in _setup
> % (desc, ENVIRONMENT_VARIABLE))
> django.core.exceptions.ImproperlyConfigured: Requested setting
> RBSSH_STORAGE_BACKEND, but settings are not configured. You must either
> define the environment variable DJANGO_SETTINGS_MODULE or call
> settings.configure() before accessing settings.
>  
> But normal SSH works without any problems and logs in with the correct user
> without asking for a password.
> ssh svn.server.ip
>  
> --
> Supercharge your Review Board with Power Pack: 
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons: 
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups 
> "reviewboard"
> group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to create an initial code review (post-commit)

2015-06-25 Thread Carel Combrink

If I ssh to the RB server and do the following (some steps I found on this 
list):
$ sudo -s
$ sudo -u www-data -s
$ DEBUG_RBSSH=1 rbssh 

I get the following error:
Traceback (most recent call last):
  File "/usr/local/bin/rbssh", line 9, in 
load_entry_point('ReviewBoard==2.0.17', 'console_scripts', 'rbssh')()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/cmdline/rbssh.py"
, line 271, in main
filemode='w')
  File "/usr/lib/python2.7/logging/__init__.py", line 1532, in basicConfig
hdlr = FileHandler(filename, mode)
  File "/usr/lib/python2.7/logging/__init__.py", line 903, in __init__
StreamHandler.__init__(self, self._open())
  File "/usr/lib/python2.7/logging/__init__.py", line 928, in _open
stream = open(self.baseFilename, self.mode)
IOError: [Errno 13] Permission denied: u'/home/myserver/rbssh-1281.log'

Without debug I get:
Traceback (most recent call last):
  File "/usr/local/bin/rbssh", line 9, in 
load_entry_point('ReviewBoard==2.0.17', 'console_scripts', 'rbssh')()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/cmdline/rbssh.py",
 
line 294, in main
client = SSHClient(namespace=options.local_site_name)
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/ssh/client.py",
 
line 62, in __init__
self._load_storage()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.17-py2.7.egg/reviewboard/ssh/client.py",
 
line 76, in _load_storage
self.DEFAULT_STORAGE)
  File 
"/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/conf/__init__.py",
 
line 54, in __getattr__
self._setup(name)
  File 
"/usr/local/lib/python2.7/dist-packages/Django-1.6.11-py2.7.egg/django/conf/__init__.py",
 
line 47, in _setup
% (desc, ENVIRONMENT_VARIABLE))
django.core.exceptions.ImproperlyConfigured: Requested setting 
RBSSH_STORAGE_BACKEND, but settings are not configured. You must either 
define the environment variable DJANGO_SETTINGS_MODULE or call 
settings.configure() before accessing settings.

But normal SSH works without any problems and logs in with the correct user 
without asking for a password.
ssh svn.server.ip

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to create an initial code review (post-commit)

Re: How to create an initial code review (post-commit)

Re: How to create an initial code review (post-commit)

Re: How to create an initial code review (post-commit)

Re: How to create an initial code review (post-commit)

Re: How to create an initial code review (post-commit)

Re: How to create an initial code review (post-commit)

7 matches

Site Navigation

Mail list logo

Footer information