Re: I have some problems about Languages.

2011-04-11 Thread Christian Hammond
Hi, Sorry, I've been out the past week so I haven't been around to offer much advice here. I'm glad you found a solution. I think we need a better way to factor this all out, though. Otherwise you'll have to maintain a custom patch for every upgrade. Can you tell me where you placed the first

Re: I have some problems about Languages.

2011-04-11 Thread jh5774....@samsung.com
Hi, My English is not as good as you, so, I'm afraid of talk about question. 1. Can you tell me where you placed the first bit of code (encoding changeset0['desc'])? Well, I don't understand perfectly, but I can tell you about that array. When I debugging problems, this is an sample I found.

Re: I have some problems about Languages.

2011-04-11 Thread Chris Clark
Christian Hammond wrote: I think we need a better way to factor this all out, though. Otherwise you'll have to maintain a custom patch for every upgrade. Can you tell me where you placed the first bit of code (encoding changeset0['desc'])? We probably can reuse the repository's Encoding

Re: I have some problems about Languages.

2011-04-11 Thread Christian Hammond
On Monday, April 11, 2011, Chris Clark chris.cl...@ingres.com wrote: Christian Hammond wrote: I think we need a better way to factor this all out, though. Otherwise you'll have to maintain a custom patch for every upgrade. Can you tell me where you placed the first bit of code (encoding

Re: I have some problems about Languages.

2011-04-10 Thread jh5774....@samsung.com
Well, I find solution about my problems I'm adding codes to /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.4-py2.6.egg/ reviewboard/scmtools/perforce.py class PerforceTool(SCMTool): ... ... def get_changeset(self, changesetid): if not self.p4.charset: # this if

Re: I have some problems about Languages.

2011-04-09 Thread jh5774....@samsung.com
Well, I appliy it to sitecustomize.py like below: import sys sys.setdefaultencoding('euc-kr') Then, my reviewboard's error message is changed. Only that. before: JSONEncoderAdapter.encode: Arguments are: {'stat': 'ok', 'review_request': ReviewRequest: [Bad Unicode data]} after:

Re: I have some problems about Languages.

2011-04-08 Thread jh5774....@samsung.com
of jh5774@samsung.com Sent: Wed 4/6/2011 10:40 PM To: reviewboard Subject: Re: I have some problems about Languages. Our Perforce server is window 2003 server server manager said, he didn't set charset anything. So, maybe perforce server's encoding is euc-kr.. And, my Reviewboard

Re: I have some problems about Languages.

2011-04-08 Thread Chris Clark
jh5774@samsung.com wrote: Well, I found a little clue about encoding. /usr/lib/python2.6/json/__init__.py in this codes, they said python only decode 'ASCII' and 'Unicode'. So, python couldn't decode when encounter like a 'Korean word' I find some solution about decoding. For example,

RE: I have some problems about Languages.

2011-04-07 Thread Chris M. Clark
: Re: I have some problems about Languages. Our Perforce server is window 2003 server server manager said, he didn't set charset anything. So, maybe perforce server's encoding is euc-kr.. And, my Reviewboard, in repository setting, Advanced - Encoding box is empty. How my ReviewBoard settings

Re: I have some problems about Languages.

2011-04-07 Thread jh5774....@samsung.com
Subject: Re: I have some problems about Languages. Our Perforce server is window 2003 server server manager said, he didn't set charset anything. So, maybe perforce server's encoding is euc-kr.. And, my Reviewboard, in repository setting, Advanced - Encoding box is empty. How my ReviewBoard

Re: I have some problems about Languages.

2011-04-06 Thread Min-Woo Lee
maybe you seems to using euc-kr in your perforce 2011. 4. 6. 오후 9:36에 Chris Clark chris.cl...@ingres.com님이 작성: This looks VERY similar in behavior (but different manifestation) to the UnicodeDecode error that another Windows user saw recently with UTF8 encoded files (check the archive for

Re: I have some problems about Languages.

2011-04-06 Thread jh5774....@samsung.com
Our repository is perforce, their P4CHARATERSET=none. Our Reviewboard's database support Unicode(utf-8). And our reviewboard repository setting, Advanced - Encoding box is empty. Please check that... Thank you. On 4월7일, 오전2시24분, Min-Woo Lee mw44@gmail.com wrote: maybe you seems to using

Re: I have some problems about Languages.

2011-04-06 Thread jh5774....@samsung.com
Our Perforce server is window 2003 server server manager said, he didn't set charset anything. So, maybe perforce server's encoding is euc-kr.. How my ReviewBoard settings change to euc-kr?? Please anyone response to me... Thank you. On 4월7일, 오전10시48분, jh5774@samsung.com