You can always look at the old revisions and see those comments, or on the
review request page itself, so I believe we meet that requirement. It's
just not displayed on the new diff, because it doesn't make any sense there.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http
I just remember that when I used it with subversion I did the comments on
the review tab as you said.
Although old comments might not make sense in the new code they should make
sense in the old code. It would be great to be able to see what was
commented on a previous revision of a file.
I'm look
Review Board has never done that though. Was this not an issue with
Subversion?
If you think about it, a comment applying to an old version of a change
doesn't necessarily make sense on new code.
You can always go to the review request and look at the comments there. It
shows the snippets of the
ups :( bad news for me :( I like seing the old comments and being able to
see why something change or not
On Thursday, July 5, 2012 4:20:51 PM UTC-3, Christian Hammond wrote:
>
> Nope, we tie comments to the revision or to the interdiff range. In each
> case, you're looking at different content,
Nope, we tie comments to the revision or to the interdiff range. In each
case, you're looking at different content, and your comments may mean very
different things.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.co
the review number is the same. In an old revision I see the comments.
I thought that when you go to let's say r3 you would see the comments on
that diff but if you select show diff betweet r1 and r3 you would see the
comments done on r1.
I thought reviewboard does that... maybe I'm remembering
Hi ZeoS,
We never show the previous diff's comments on the new diff, as line numbers
and code change and we have no way of knowing what to bring over and what
not to. The comments are always on the review request page in previous
reviews, and you can also see them when selecting the older revision
