Re: Problem seeing comments on diffs with Mercurial

2012-07-05 Thread Christian Hammond 
You can always look at the old revisions and see those comments, or on the
review request page itself, so I believe we meet that requirement. It's
just not displayed on the new diff, because it doesn't make any sense there.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Jul 5, 2012 at 2:17 PM, Fernando O.  wrote:

> I just remember that when I used it with subversion I did the comments on
> the review tab as you said.
>
> Although old comments might not make sense in the new code they should
> make sense in the old code. It would be great to be able to see what was
> commented on a previous revision of a file.
> I'm looking at rietld (since I can't try mondrian now) and they do that:
>
> http://codereview.appspot.com/6346054/diff2/1:8002/src/main/java/contrail/avro/QuickMarkAvro.java
>
> I suppose I was confused :S
>
> On Thu, Jul 5, 2012 at 6:02 PM, Christian Hammond wrote:
>
>> Review Board has never done that though. Was this not an issue with
>> Subversion?
>>
>> If you think about it, a comment applying to an old version of a change
>> doesn't necessarily make sense on new code.
>>
>> You can always go to the review request and look at the comments there.
>> It shows the snippets of the diffs.
>>
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> On Thu, Jul 5, 2012 at 1:12 PM, ZeoS  wrote:
>>
>>> ups :( bad news for me :( I like seing the old comments and being able
>>> to see why something change or not
>>>
>>>
>>> On Thursday, July 5, 2012 4:20:51 PM UTC-3, Christian Hammond wrote:

 Nope, we tie comments to the revision or to the interdiff range. In
 each case, you're looking at different content, and your comments may mean
 very different things.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Thu, Jul 5, 2012 at 12:09 PM, ZeoS  wrote:

> the review number is the same.  In an old revision I see the comments.
>
> I thought that when you go to let's say r3 you would see the comments
> on that diff but if you select show diff betweet r1 and r3 you would see
> the comments done on r1.
>
> I thought reviewboard does that... maybe I'm remembering Mondrian.
>
>
> And if you see
> http://demo.reviewboard.org/r/**54/diff/2-3/#index_headeryou
>  will see in the last file (diff_update.txt) a comment made in
> http://demo.reviewboard.org/**r/54/diff/1-2/#index_header
>
>
>
> On Thursday, July 5, 2012 3:54:25 PM UTC-3, Christian Hammond wrote:
>>
>> Hi ZeoS,
>>
>> We never show the previous diff's comments on the new diff, as line
>> numbers and code change and we have no way of knowing what to bring over
>> and what not to. The comments are always on the review request page in
>> previous reviews, and you can also see them when selecting the older
>> revision in the diff viewer.
>>
>> If you view the older revision, do you see the comments there?
>>
>> Is the review request ID number the same between the two?
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> On Thu, Jul 5, 2012 at 10:18 AM, ZeoS  wrote:
>>
>>> Hi all,
>>> I'm doing a POC with ReviewBoard, seeing if it's good for my
>>> current project. I used sometime ago with SVN and worked great.
>>>
>>> Now I'm using it with Mercurial, the problem I'm facing is that when
>>> I post a new diff I don't see the comments for the previous one.
>>>
>>> The structure: I basically pull from a repo R, do changes in a
>>> branch (B) that I end up pushing to R. after that I run
>>> hg postreview B
>>> Somebody looks at the code, makes some comments, I change the code
>>> on B, push it again to R and run
>>> hg postreview -e ### B
>>>
>>> When I go to reviewboard I see the diff with the previous change but
>>> I can't see the comments.
>>>
>>> I also tried with
>>> hg postreview -e### -p parent_of_both B
>>>
>>> which is more complete but I still can't see the comments.
>>>
>>> Maybe I forgot to enable something?
>>>
>>>
>>> Thanks for your help!
>>>
>>> --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/**don**ate/
>>> Happy user? Let us know at 
>>> http://www.reviewboard.org/**use**rs/

Re: Problem seeing comments on diffs with Mercurial

2012-07-05 Thread Fernando O. 
I just remember that when I used it with subversion I did the comments on
the review tab as you said.

Although old comments might not make sense in the new code they should make
sense in the old code. It would be great to be able to see what was
commented on a previous revision of a file.
I'm looking at rietld (since I can't try mondrian now) and they do that:
http://codereview.appspot.com/6346054/diff2/1:8002/src/main/java/contrail/avro/QuickMarkAvro.java

I suppose I was confused :S

On Thu, Jul 5, 2012 at 6:02 PM, Christian Hammond wrote:

> Review Board has never done that though. Was this not an issue with
> Subversion?
>
> If you think about it, a comment applying to an old version of a change
> doesn't necessarily make sense on new code.
>
> You can always go to the review request and look at the comments there. It
> shows the snippets of the diffs.
>
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Jul 5, 2012 at 1:12 PM, ZeoS  wrote:
>
>> ups :( bad news for me :( I like seing the old comments and being able to
>> see why something change or not
>>
>>
>> On Thursday, July 5, 2012 4:20:51 PM UTC-3, Christian Hammond wrote:
>>>
>>> Nope, we tie comments to the revision or to the interdiff range. In each
>>> case, you're looking at different content, and your comments may mean very
>>> different things.
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond - chip...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com
>>>
>>>
>>> On Thu, Jul 5, 2012 at 12:09 PM, ZeoS  wrote:
>>>
 the review number is the same.  In an old revision I see the comments.

 I thought that when you go to let's say r3 you would see the comments
 on that diff but if you select show diff betweet r1 and r3 you would see
 the comments done on r1.

 I thought reviewboard does that... maybe I'm remembering Mondrian.


 And if you see
 http://demo.reviewboard.org/r/**54/diff/2-3/#index_headeryou
  will see in the last file (diff_update.txt) a comment made in
 http://demo.reviewboard.org/**r/54/diff/1-2/#index_header



 On Thursday, July 5, 2012 3:54:25 PM UTC-3, Christian Hammond wrote:
>
> Hi ZeoS,
>
> We never show the previous diff's comments on the new diff, as line
> numbers and code change and we have no way of knowing what to bring over
> and what not to. The comments are always on the review request page in
> previous reviews, and you can also see them when selecting the older
> revision in the diff viewer.
>
> If you view the older revision, do you see the comments there?
>
> Is the review request ID number the same between the two?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Jul 5, 2012 at 10:18 AM, ZeoS  wrote:
>
>> Hi all,
>> I'm doing a POC with ReviewBoard, seeing if it's good for my
>> current project. I used sometime ago with SVN and worked great.
>>
>> Now I'm using it with Mercurial, the problem I'm facing is that when
>> I post a new diff I don't see the comments for the previous one.
>>
>> The structure: I basically pull from a repo R, do changes in a branch
>> (B) that I end up pushing to R. after that I run
>> hg postreview B
>> Somebody looks at the code, makes some comments, I change the code on
>> B, push it again to R and run
>> hg postreview -e ### B
>>
>> When I go to reviewboard I see the diff with the previous change but
>> I can't see the comments.
>>
>> I also tried with
>> hg postreview -e### -p parent_of_both B
>>
>> which is more complete but I still can't see the comments.
>>
>> Maybe I forgot to enable something?
>>
>>
>> Thanks for your help!
>>
>> --
>> Want to help the Review Board project? Donate today at
>> http://www.reviewboard.org/**don**ate/
>> Happy user? Let us know at 
>> http://www.reviewboard.org/**use**rs/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to
>> reviewboard+unsubscribe@**google**groups.com
>> For more options, visit this group at http://groups.google.com/**
>> group**/reviewboard?hl=en
>
>
>  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/**donate/
 Happy user? Let us know at 
 http://www.reviewboard.org

Re: Problem seeing comments on diffs with Mercurial

2012-07-05 Thread Christian Hammond 
Review Board has never done that though. Was this not an issue with
Subversion?

If you think about it, a comment applying to an old version of a change
doesn't necessarily make sense on new code.

You can always go to the review request and look at the comments there. It
shows the snippets of the diffs.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Jul 5, 2012 at 1:12 PM, ZeoS  wrote:

> ups :( bad news for me :( I like seing the old comments and being able to
> see why something change or not
>
>
> On Thursday, July 5, 2012 4:20:51 PM UTC-3, Christian Hammond wrote:
>>
>> Nope, we tie comments to the revision or to the interdiff range. In each
>> case, you're looking at different content, and your comments may mean very
>> different things.
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> On Thu, Jul 5, 2012 at 12:09 PM, ZeoS  wrote:
>>
>>> the review number is the same.  In an old revision I see the comments.
>>>
>>> I thought that when you go to let's say r3 you would see the comments on
>>> that diff but if you select show diff betweet r1 and r3 you would see the
>>> comments done on r1.
>>>
>>> I thought reviewboard does that... maybe I'm remembering Mondrian.
>>>
>>>
>>> And if you see
>>> http://demo.reviewboard.org/r/**54/diff/2-3/#index_headeryou
>>>  will see in the last file (diff_update.txt) a comment made in
>>> http://demo.reviewboard.org/**r/54/diff/1-2/#index_header
>>>
>>>
>>>
>>> On Thursday, July 5, 2012 3:54:25 PM UTC-3, Christian Hammond wrote:

 Hi ZeoS,

 We never show the previous diff's comments on the new diff, as line
 numbers and code change and we have no way of knowing what to bring over
 and what not to. The comments are always on the review request page in
 previous reviews, and you can also see them when selecting the older
 revision in the diff viewer.

 If you view the older revision, do you see the comments there?

 Is the review request ID number the same between the two?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Thu, Jul 5, 2012 at 10:18 AM, ZeoS  wrote:

> Hi all,
> I'm doing a POC with ReviewBoard, seeing if it's good for my
> current project. I used sometime ago with SVN and worked great.
>
> Now I'm using it with Mercurial, the problem I'm facing is that when I
> post a new diff I don't see the comments for the previous one.
>
> The structure: I basically pull from a repo R, do changes in a branch
> (B) that I end up pushing to R. after that I run
> hg postreview B
> Somebody looks at the code, makes some comments, I change the code on
> B, push it again to R and run
> hg postreview -e ### B
>
> When I go to reviewboard I see the diff with the previous change but I
> can't see the comments.
>
> I also tried with
> hg postreview -e### -p parent_of_both B
>
> which is more complete but I still can't see the comments.
>
> Maybe I forgot to enable something?
>
>
> Thanks for your help!
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/**don**ate/
> Happy user? Let us know at 
> http://www.reviewboard.org/**use**rs/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to reviewboard+unsubscribe@
> **google**groups.com 
> For more options, visit this group at http://groups.google.com/**group
> **/reviewboard?hl=en


  --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/**donate/
>>> Happy user? Let us know at 
>>> http://www.reviewboard.org/**users/
>>> -~--~~~~--**~~--~--~---
>>> To unsubscribe from this group, send email to reviewboard+unsubscribe@**
>>> googlegroups.com 
>>> For more options, visit this group at http://groups.google.com/**
>>> group/reviewboard?hl=en
>>>
>>
>>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more opt

Re: Problem seeing comments on diffs with Mercurial

2012-07-05 Thread ZeoS 
ups :( bad news for me :( I like seing the old comments and being able to 
see why something change or not

On Thursday, July 5, 2012 4:20:51 PM UTC-3, Christian Hammond wrote:
>
> Nope, we tie comments to the revision or to the interdiff range. In each 
> case, you're looking at different content, and your comments may mean very 
> different things.
>
> Christian
>
> -- 
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Jul 5, 2012 at 12:09 PM, ZeoS  wrote:
>
>> the review number is the same.  In an old revision I see the comments.
>>
>> I thought that when you go to let's say r3 you would see the comments on 
>> that diff but if you select show diff betweet r1 and r3 you would see the 
>> comments done on r1.
>>
>> I thought reviewboard does that... maybe I'm remembering Mondrian.
>>
>>
>> And if you see
>> http://demo.reviewboard.org/r/54/diff/2-3/#index_header you will see in 
>> the last file (diff_update.txt) a comment made in  
>> http://demo.reviewboard.org/r/54/diff/1-2/#index_header
>>
>>
>>
>> On Thursday, July 5, 2012 3:54:25 PM UTC-3, Christian Hammond wrote:
>>>
>>> Hi ZeoS,
>>>
>>> We never show the previous diff's comments on the new diff, as line 
>>> numbers and code change and we have no way of knowing what to bring over 
>>> and what not to. The comments are always on the review request page in 
>>> previous reviews, and you can also see them when selecting the older 
>>> revision in the diff viewer.
>>>
>>> If you view the older revision, do you see the comments there?
>>>
>>> Is the review request ID number the same between the two?
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chip...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com
>>>
>>>
>>> On Thu, Jul 5, 2012 at 10:18 AM, ZeoS  wrote:
>>>
 Hi all,
 I'm doing a POC with ReviewBoard, seeing if it's good for my 
 current project. I used sometime ago with SVN and worked great.

 Now I'm using it with Mercurial, the problem I'm facing is that when I 
 post a new diff I don't see the comments for the previous one.

 The structure: I basically pull from a repo R, do changes in a branch 
 (B) that I end up pushing to R. after that I run
 hg postreview B 
 Somebody looks at the code, makes some comments, I change the code on 
 B, push it again to R and run
 hg postreview -e ### B 

 When I go to reviewboard I see the diff with the previous change but I 
 can't see the comments.

 I also tried with 
 hg postreview -e### -p parent_of_both B

 which is more complete but I still can't see the comments.

 Maybe I forgot to enable something?


 Thanks for your help!

 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/**donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to reviewboard+unsubscribe@*
 *googlegroups.com 
 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=en
>>>
>>>
>>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Problem seeing comments on diffs with Mercurial

2012-07-05 Thread Christian Hammond 
Nope, we tie comments to the revision or to the interdiff range. In each
case, you're looking at different content, and your comments may mean very
different things.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Jul 5, 2012 at 12:09 PM, ZeoS  wrote:

> the review number is the same.  In an old revision I see the comments.
>
> I thought that when you go to let's say r3 you would see the comments on
> that diff but if you select show diff betweet r1 and r3 you would see the
> comments done on r1.
>
> I thought reviewboard does that... maybe I'm remembering Mondrian.
>
>
> And if you see
> http://demo.reviewboard.org/r/54/diff/2-3/#index_header you will see in
> the last file (diff_update.txt) a comment made in
> http://demo.reviewboard.org/r/54/diff/1-2/#index_header
>
>
>
> On Thursday, July 5, 2012 3:54:25 PM UTC-3, Christian Hammond wrote:
>>
>> Hi ZeoS,
>>
>> We never show the previous diff's comments on the new diff, as line
>> numbers and code change and we have no way of knowing what to bring over
>> and what not to. The comments are always on the review request page in
>> previous reviews, and you can also see them when selecting the older
>> revision in the diff viewer.
>>
>> If you view the older revision, do you see the comments there?
>>
>> Is the review request ID number the same between the two?
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> On Thu, Jul 5, 2012 at 10:18 AM, ZeoS  wrote:
>>
>>> Hi all,
>>> I'm doing a POC with ReviewBoard, seeing if it's good for my current
>>> project. I used sometime ago with SVN and worked great.
>>>
>>> Now I'm using it with Mercurial, the problem I'm facing is that when I
>>> post a new diff I don't see the comments for the previous one.
>>>
>>> The structure: I basically pull from a repo R, do changes in a branch
>>> (B) that I end up pushing to R. after that I run
>>> hg postreview B
>>> Somebody looks at the code, makes some comments, I change the code on B,
>>> push it again to R and run
>>> hg postreview -e ### B
>>>
>>> When I go to reviewboard I see the diff with the previous change but I
>>> can't see the comments.
>>>
>>> I also tried with
>>> hg postreview -e### -p parent_of_both B
>>>
>>> which is more complete but I still can't see the comments.
>>>
>>> Maybe I forgot to enable something?
>>>
>>>
>>> Thanks for your help!
>>>
>>> --
>>> Want to help the Review Board project? Donate today at
>>> http://www.reviewboard.org/**donate/
>>> Happy user? Let us know at 
>>> http://www.reviewboard.org/**users/
>>> -~--~~~~--**~~--~--~---
>>> To unsubscribe from this group, send email to reviewboard+unsubscribe@**
>>> googlegroups.com 
>>> For more options, visit this group at http://groups.google.com/**
>>> group/reviewboard?hl=en
>>
>>
>>  --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Problem seeing comments on diffs with Mercurial

2012-07-05 Thread ZeoS 
the review number is the same.  In an old revision I see the comments.

I thought that when you go to let's say r3 you would see the comments on 
that diff but if you select show diff betweet r1 and r3 you would see the 
comments done on r1.

I thought reviewboard does that... maybe I'm remembering Mondrian.


And if you see
http://demo.reviewboard.org/r/54/diff/2-3/#index_header you will see in the 
last file (diff_update.txt) a comment made in 
 http://demo.reviewboard.org/r/54/diff/1-2/#index_header



On Thursday, July 5, 2012 3:54:25 PM UTC-3, Christian Hammond wrote:
>
> Hi ZeoS,
>
> We never show the previous diff's comments on the new diff, as line 
> numbers and code change and we have no way of knowing what to bring over 
> and what not to. The comments are always on the review request page in 
> previous reviews, and you can also see them when selecting the older 
> revision in the diff viewer.
>
> If you view the older revision, do you see the comments there?
>
> Is the review request ID number the same between the two?
>
> Christian
>
> -- 
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Thu, Jul 5, 2012 at 10:18 AM, ZeoS  wrote:
>
>> Hi all,
>> I'm doing a POC with ReviewBoard, seeing if it's good for my current 
>> project. I used sometime ago with SVN and worked great.
>>
>> Now I'm using it with Mercurial, the problem I'm facing is that when I 
>> post a new diff I don't see the comments for the previous one.
>>
>> The structure: I basically pull from a repo R, do changes in a branch (B) 
>> that I end up pushing to R. after that I run
>> hg postreview B 
>> Somebody looks at the code, makes some comments, I change the code on B, 
>> push it again to R and run
>> hg postreview -e ### B 
>>
>> When I go to reviewboard I see the diff with the previous change but I 
>> can't see the comments.
>>
>> I also tried with 
>> hg postreview -e### -p parent_of_both B
>>
>> which is more complete but I still can't see the comments.
>>
>> Maybe I forgot to enable something?
>>
>>
>> Thanks for your help!
>>
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Problem seeing comments on diffs with Mercurial

2012-07-05 Thread Christian Hammond 
Hi ZeoS,

We never show the previous diff's comments on the new diff, as line numbers
and code change and we have no way of knowing what to bring over and what
not to. The comments are always on the review request page in previous
reviews, and you can also see them when selecting the older revision in the
diff viewer.

If you view the older revision, do you see the comments there?

Is the review request ID number the same between the two?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Jul 5, 2012 at 10:18 AM, ZeoS  wrote:

> Hi all,
> I'm doing a POC with ReviewBoard, seeing if it's good for my current
> project. I used sometime ago with SVN and worked great.
>
> Now I'm using it with Mercurial, the problem I'm facing is that when I
> post a new diff I don't see the comments for the previous one.
>
> The structure: I basically pull from a repo R, do changes in a branch (B)
> that I end up pushing to R. after that I run
> hg postreview B
> Somebody looks at the code, makes some comments, I change the code on B,
> push it again to R and run
> hg postreview -e ### B
>
> When I go to reviewboard I see the diff with the previous change but I
> can't see the comments.
>
> I also tried with
> hg postreview -e### -p parent_of_both B
>
> which is more complete but I still can't see the comments.
>
> Maybe I forgot to enable something?
>
>
> Thanks for your help!
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en