Re: ReviewBoard 2.0.15 does not like ./ as basedir or as path to file in diff
You shouldn't have to modify the diff files even if the paths include . and .. For patches generated in the root of the repository, the base directory should never have been ./, but / A patch generated in a subdirectory but trying to give a full file path (such as ../../trunk/path/File.java) should use the subdirectory as the base dir (namely /trunk/path/) All of this is handled for you if you use rbtools to post your changes. -David On Thu, Jun 11, 2015 at 8:31 AM Papaswede wrote: > Some more info here as well. > > If I generated a diff in /trunk/path and the patch file then ends up with > ../../trunk/path/File.java in it, reviewboard is not liking the ../../ and > I always get an error that says "../../trunk/path/File.java was not found > in the repository", so it seems that it's not interpreting the ../../ > correctly. > > > On Thursday, June 11, 2015 at 9:22:17 AM UTC-4, Papaswede wrote: > >> I recently upgraded our instance of ReviewBoard from 1.6.11 to 2.0.15. >> Quite a few people have been reporting issues with uploading diffs that >> contain ./ as the beginning of the file path and also using ./ as the base >> directory. They just get an "Unknown Error" on the patch upload screen. For >> example, if the patch file has this >> >> --- ./path/to/File.java >> +++ ./path/to/File.java >> >> that won't work. I've had to ask them to do a find and replace in the >> file and replace ./ with just / and use / as the basedir. So, the patch >> file ends up looking like this: >> >> --- /path/to/File.java >> +++ /path/to/File.java >> >> Should ./ not work anymore? Also, I know that ideally, we should be using >> the RBTools to upload files, but it hasn't been approved by our security >> department as a tool we can have installed yet. So, in the meantime I'm >> trying to make people's lives as simple as possible. >> >> Thanks! >> > -- > Supercharge your Review Board with Power Pack: > https://www.reviewboard.org/powerpack/ > Want us to host Review Board for you? Check out RBCommons: > https://rbcommons.com/ > Happy user? Let us know! https://www.reviewboard.org/users/ > --- > You received this message because you are subscribed to the Google Groups > "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard 2.0.15 does not like ./ as basedir or as path to file in diff
Some more info here as well. If I generated a diff in /trunk/path and the patch file then ends up with ../../trunk/path/File.java in it, reviewboard is not liking the ../../ and I always get an error that says "../../trunk/path/File.java was not found in the repository", so it seems that it's not interpreting the ../../ correctly. On Thursday, June 11, 2015 at 9:22:17 AM UTC-4, Papaswede wrote: > > I recently upgraded our instance of ReviewBoard from 1.6.11 to 2.0.15. > Quite a few people have been reporting issues with uploading diffs that > contain ./ as the beginning of the file path and also using ./ as the base > directory. They just get an "Unknown Error" on the patch upload screen. For > example, if the patch file has this > > --- ./path/to/File.java > +++ ./path/to/File.java > > that won't work. I've had to ask them to do a find and replace in the file > and replace ./ with just / and use / as the basedir. So, the patch file > ends up looking like this: > > --- /path/to/File.java > +++ /path/to/File.java > > Should ./ not work anymore? Also, I know that ideally, we should be using > the RBTools to upload files, but it hasn't been approved by our security > department as a tool we can have installed yet. So, in the meantime I'm > trying to make people's lives as simple as possible. > > Thanks! > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard 2.0.15 does not like ./ as basedir or as path to file in diff
Also got some more emails from other users that are generating paths from the IDE, so the path in those diffs may be something like ../root/path/to/File.java and when they try to submit a diff there is no way to get it to work. They were able to make things work in ReviewBoard 1.6.11 by using . or ./ as the base path. I know that path is a little strange because it's essentially going up one from the root directory and then back into it, but for some reason about 80% of the people here get patch files like that generated from the IDE. Is there any way to make these work? I'm having lots of people freaking out on me today because things are breaking and they're having to do find and replaces in their patch files. On Thursday, June 11, 2015 at 9:22:17 AM UTC-4, Papaswede wrote: > > I recently upgraded our instance of ReviewBoard from 1.6.11 to 2.0.15. > Quite a few people have been reporting issues with uploading diffs that > contain ./ as the beginning of the file path and also using ./ as the base > directory. They just get an "Unknown Error" on the patch upload screen. For > example, if the patch file has this > > --- ./path/to/File.java > +++ ./path/to/File.java > > that won't work. I've had to ask them to do a find and replace in the file > and replace ./ with just / and use / as the basedir. So, the patch file > ends up looking like this: > > --- /path/to/File.java > +++ /path/to/File.java > > Should ./ not work anymore? Also, I know that ideally, we should be using > the RBTools to upload files, but it hasn't been approved by our security > department as a tool we can have installed yet. So, in the meantime I'm > trying to make people's lives as simple as possible. > > Thanks! > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
