Re: Reviewboard post-commit hook for SVN

2009-11-15 Thread Christian Hammond 
It's actually in the source tree.

http://github.com/reviewboard/reviewboard/tree/master/contrib/tools

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sun, Nov 15, 2009 at 3:25 AM, Koen  wrote:

>
> Thanks for your reply;
>
>
> Where can i find this contrib/tools/ directory?
> My reviewboard installation download (ReviewBoard-1.1alpha1-py2.5)
> does not contain such a folder, is this a different download?
>
>
> Thanks!
> Koen
>
>
> On Nov 15, 12:11 pm, Christian Hammond  wrote:
> > Shame on me. Too late at night, not thinking straight.
> >
> > post-review needs to be run from an active source tree, if you're running
> it
> > straight like that. You'll probably want to look in the contrib/tools/
> > directory at the various SVN hooks already provided. As you'll see,
> there's
> > a bit more that you'll need to do than just run post-review.
> Specifically,
> > see svn-hook-postcommit-review.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Sun, Nov 15, 2009 at 3:09 AM, Christian Hammond  >wrote:
> >
> > > Hi Koen,
> >
> > > You may want to try running post-review with the -d (debug) parameter,
> and
> > > output all stdout and stderr to a log file that you could check. This
> should
> > > help provide some idea as to what's going wrong.
> >
> > > Christian
> >
> > > --
> > > Christian Hammond - chip...@chipx86.com
> > > Review Board -http://www.reviewboard.org
> > > VMware, Inc. -http://www.vmware.com
> >
> > > On Sun, Nov 15, 2009 at 2:51 AM, Koen  wrote:
> >
> > >> Hi all,
> >
> > >> I've successfully set up reviewboard 1.1 alpha 1 on a Windows 2003
> > >> server with SVN.
> > >> However, i'd like to automate reviews on every commit (as it is stated
> > >> in the documentation (
> http://www.reviewboard.org/docs/manual/1.0/users/
> > >> tools/post-review/#automating-post-review<
> http://www.reviewboard.org/docs/manual/1.0/users/%0Atools/post-review...>
> > >> ).
> >
> > >> I created a post-commit hook as it is in the documentation:
> >
> > >> post-review --username=SPECIAL_USER --password=PASSWORD --submit-
> > >> as=ANOTHER_USER
> > >> (SPECIAL_USER has been created in reviewboard, ANOTHER_USER exists)
> >
> > >> The OS-user running the post-review has all necessary rights (Manually
> > >> through the command line,
> > >> a review can be submitted with this user). But, the reviews are not
> > >> auto-post on commits.
> >
> > >> - I do not see any errors in neither SVN server logs, neither Apache
> > >> server logs
> > >> - Am I forgetting something here?
> > >> - How does the post-review hook know which revision to use for the
> > >> review?
> >
> > >> Any help is appreciated!
> >
> > >> Thanks,
> > >> Koen
> >
> > >> >> To unsubscribe from this group, send email to
> > >> reviewboard+unsubscr...@googlegroups.com
> 
> >
> > >> For more options, visit this group at
> > >>http://groups.google.com/group/reviewboard?hl=en
> > >> -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> -~--~~~~--~~--~--~---
>
>

--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Reviewboard post-commit hook for SVN

2009-11-15 Thread Koen 

Thanks for your reply;


Where can i find this contrib/tools/ directory?
My reviewboard installation download (ReviewBoard-1.1alpha1-py2.5)
does not contain such a folder, is this a different download?


Thanks!
Koen


On Nov 15, 12:11 pm, Christian Hammond  wrote:
> Shame on me. Too late at night, not thinking straight.
>
> post-review needs to be run from an active source tree, if you're running it
> straight like that. You'll probably want to look in the contrib/tools/
> directory at the various SVN hooks already provided. As you'll see, there's
> a bit more that you'll need to do than just run post-review. Specifically,
> see svn-hook-postcommit-review.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Sun, Nov 15, 2009 at 3:09 AM, Christian Hammond wrote:
>
> > Hi Koen,
>
> > You may want to try running post-review with the -d (debug) parameter, and
> > output all stdout and stderr to a log file that you could check. This should
> > help provide some idea as to what's going wrong.
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Sun, Nov 15, 2009 at 2:51 AM, Koen  wrote:
>
> >> Hi all,
>
> >> I've successfully set up reviewboard 1.1 alpha 1 on a Windows 2003
> >> server with SVN.
> >> However, i'd like to automate reviews on every commit (as it is stated
> >> in the documentation (http://www.reviewboard.org/docs/manual/1.0/users/
> >> tools/post-review/#automating-post-review
> >> ).
>
> >> I created a post-commit hook as it is in the documentation:
>
> >> post-review --username=SPECIAL_USER --password=PASSWORD --submit-
> >> as=ANOTHER_USER
> >> (SPECIAL_USER has been created in reviewboard, ANOTHER_USER exists)
>
> >> The OS-user running the post-review has all necessary rights (Manually
> >> through the command line,
> >> a review can be submitted with this user). But, the reviews are not
> >> auto-post on commits.
>
> >> - I do not see any errors in neither SVN server logs, neither Apache
> >> server logs
> >> - Am I forgetting something here?
> >> - How does the post-review hook know which revision to use for the
> >> review?
>
> >> Any help is appreciated!
>
> >> Thanks,
> >> Koen
>
> >> >> To unsubscribe from this group, send email to
> >> reviewboard+unsubscr...@googlegroups.com
> >> For more options, visit this group at
> >>http://groups.google.com/group/reviewboard?hl=en
> >> -~--~~~~--~~--~--~---
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Reviewboard post-commit hook for SVN

2009-11-15 Thread Christian Hammond 
Shame on me. Too late at night, not thinking straight.

post-review needs to be run from an active source tree, if you're running it
straight like that. You'll probably want to look in the contrib/tools/
directory at the various SVN hooks already provided. As you'll see, there's
a bit more that you'll need to do than just run post-review. Specifically,
see svn-hook-postcommit-review.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sun, Nov 15, 2009 at 3:09 AM, Christian Hammond wrote:

> Hi Koen,
>
> You may want to try running post-review with the -d (debug) parameter, and
> output all stdout and stderr to a log file that you could check. This should
> help provide some idea as to what's going wrong.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
>
> On Sun, Nov 15, 2009 at 2:51 AM, Koen  wrote:
>
>>
>> Hi all,
>>
>>
>> I've successfully set up reviewboard 1.1 alpha 1 on a Windows 2003
>> server with SVN.
>> However, i'd like to automate reviews on every commit (as it is stated
>> in the documentation (http://www.reviewboard.org/docs/manual/1.0/users/
>> tools/post-review/#automating-post-review
>> ).
>>
>> I created a post-commit hook as it is in the documentation:
>>
>> post-review --username=SPECIAL_USER --password=PASSWORD --submit-
>> as=ANOTHER_USER
>> (SPECIAL_USER has been created in reviewboard, ANOTHER_USER exists)
>>
>>
>> The OS-user running the post-review has all necessary rights (Manually
>> through the command line,
>> a review can be submitted with this user). But, the reviews are not
>> auto-post on commits.
>>
>> - I do not see any errors in neither SVN server logs, neither Apache
>> server logs
>> - Am I forgetting something here?
>> - How does the post-review hook know which revision to use for the
>> review?
>>
>>
>> Any help is appreciated!
>>
>> Thanks,
>> Koen
>>
>> >> To unsubscribe from this group, send email to
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/reviewboard?hl=en
>> -~--~~~~--~~--~--~---
>>
>>
>

--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Reviewboard post-commit hook for SVN

2009-11-15 Thread Christian Hammond 
Hi Koen,

You may want to try running post-review with the -d (debug) parameter, and
output all stdout and stderr to a log file that you could check. This should
help provide some idea as to what's going wrong.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sun, Nov 15, 2009 at 2:51 AM, Koen  wrote:

>
> Hi all,
>
>
> I've successfully set up reviewboard 1.1 alpha 1 on a Windows 2003
> server with SVN.
> However, i'd like to automate reviews on every commit (as it is stated
> in the documentation (http://www.reviewboard.org/docs/manual/1.0/users/
> tools/post-review/#automating-post-review
> ).
>
> I created a post-commit hook as it is in the documentation:
>
> post-review --username=SPECIAL_USER --password=PASSWORD --submit-
> as=ANOTHER_USER
> (SPECIAL_USER has been created in reviewboard, ANOTHER_USER exists)
>
>
> The OS-user running the post-review has all necessary rights (Manually
> through the command line,
> a review can be submitted with this user). But, the reviews are not
> auto-post on commits.
>
> - I do not see any errors in neither SVN server logs, neither Apache
> server logs
> - Am I forgetting something here?
> - How does the post-review hook know which revision to use for the
> review?
>
>
> Any help is appreciated!
>
> Thanks,
> Koen
>
> > To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> -~--~~~~--~~--~--~---
>
>

--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---