Re: Reviewing diffs of large merges

2011-03-16 Thread Christian Hammond
We were just talking about this last night. There's s bug open for it
(I don't have the number handy) but I think it'd be great to get it
in.

Christian


On Wednesday, March 16, 2011, Scott Quesnelle scott.quesne...@gmail.com
 The only thing that would be nice is if there was a way in reviewboard to say 
 that two review requests are linked or depend on each other.

 Scott

-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Reviewing diffs of large merges

2011-03-15 Thread David Trowbridge
Review Board can deal with large diffs, but I don't think there's really
much in the way of helping reviewers deal with it. The only help I can
think of is that it will split it across pages in order to avoid having
giant web pages to look at (by default 20 files to a page). If there are
specific things that you think would be helpful when reviewing very large
changes, we'd love to hear about them.

-David


On Tue, Mar 15, 2011 at 9:00 AM, Bobman bobpa...@gmail.com wrote:

 At my company we have a recurring issue (we use CVS) when we merge a
 branch back to the trunk, where (if it has been several months) the
 changes and conflicts need to be reviewed by many people.

 Ideally, we would run a diff between the two branches and publish that
 for others to review, but a 50,000-line diff is hard to digest without
 context.

 Does Review Board work well in this scenario? Does anyone here have
 experience with scenarios like this and/or have any suggestions for
 how to handle this?

 Thanks.

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en