Re: "There was an error displaying this diff"

[Christian Hammond]

Hi Illya,

Hmm, that's an interesting one. This is coming from within Python itself,
and I've never seen it before. It almost seems like it wasn't able to get a
file handle, or keep it open, for reading/writing.

I just checked online, and it looks to be a bug in Python 2.6, which is
horribly end-of-lifed (so is Python 2.7, but you can't run Review Board on
Python 3 *yet*):

https://access.redhat.com/errata/RHSA-2011:0027

"Prior to Python 2.7, programs that used "ulimit -n" to enable
communication with large numbers of subprocesses could still monitor only
1024 file descriptors at a time, which caused an exception: ValueError:
filedescriptor out of range in select()"

Review Board 2.5 is also end-of-life'd, by the way. I'd suggest moving to
Python 2.7 and Review Board 3.0.x, if possible. Review Board 3.0.x requires
Python 2.7.

Review Board 4 is entering beta soon, and will be compatible with Python
2.7 and 3.6+.

Christian

On Sun, May 3, 2020 at 10:15 AM Illya Broder  wrote:

> HI.
>
> I'm getting this error along with "filedescriptor out of range in select()
> "
>
> If I click on the "details" option it displays the following
>
> How do I solve this.
>
> Regards,
> Illya
>
> raceback (most recent call last):
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/reviews/views.py",
>  line 179, in build_diff_comment_fragments
> comment.interfilediff)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 497, in get_last_line_number_in_diff
> f = get_file_from_filediff(context, filediff, interfilediff)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 481, in get_file_from_filediff
> request=request)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 429, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 107, in get_chunks
> large_data=True)
>   File 
> "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
>  line 295, in cache_memoize
> compress_large_data))
>   File 
> "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
>  line 249, in cache_memoize_iter
> items = items_or_callable()
>   File 
> "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py",
>  line 292, in 
> lambda: [lookup_callable()],
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py",
>  line 763, in get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 232, in get_patched_file
> return patch(diff, buffer, filediff.dest_file, request)
>   File 
> "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py",
>  line 147, in patch
> stdout, stderr = p.communicate(diff)
>   File "/usr/lib64/python2.6/subprocess.py", line 691, in communicate
> return self._communicate(input)
>   File "/usr/lib64/python2.6/subprocess.py", line 1211, in _communicate
> rlist, wlist, xlist = select.select(read_set, write_set, [])
> ValueError: filedescriptor out of range in select(
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/46025f9b-e476-4c9d-9fd2-0b1458c8ed8e%40googlegroups.com
> 
> .
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review 

Re: "There was an error displaying this diff" when diffing a file that contains a "#" in the filename.

[Rob Petti]

Hey Folks,

I've managed to narrow it down some more. It appears to be a problem in 
scmtools/svn/pysvn.py.

def _do_on_path(self, cb, path, revision=HEAD):
if not path:
raise FileNotFoundError(path, revision)

try:
# path == 
"src/cws/QMS/Entities/NonconformanceBase#cws-nativeentity#.cws"
normpath = self.normalize_path(path)
# normpath == 
"https://subversion.ourdomain.net/repos/bpm-spa/trunk/applications/qualitycenter/src/cws/QMS/Entities/NonconformanceBase#cws-nativeentity#.cws";

# SVN expects to have URLs escaped. Take care to only
# escape the path part of the URL.
if self.client.is_url(normpath):
pathtuple = urlsplit(normpath)
path = pathtuple[2]
if isinstance(path, six.text_type):
path = path.encode('utf-8', 'ignore')
normpath = urlunsplit((pathtuple[0],
   pathtuple[1],
   quote(path),
   '', ''))

# normpath == 
"https://subversion.ourdomain.net/repos/bpm-spa/trunk/applications/qualitycenter/src/cws/QMS/Entities/NonconformanceBase";
normrev = self._normalize_revision(revision)
return cb(normpath, normrev)


As you can see, it combines the path naively into a URL without escaping 
any characters, then tries to parse it as a URL to URL-escape the path 
portion of it, which obviously won't work.

I was able to fix my problem by changing the code as below. It didn't make 
any sense to me that it would parse it as a URL before escaping it, so I 
removed that whole section of the code and just encoded the file path 
before normalizing it.
def _do_on_path(self, cb, path, revision=HEAD):
if not path:
raise FileNotFoundError(path, revision)

try:
normpath = self.normalize_path(quote(path.encode('utf-8', 
'ignore')))

normrev = self._normalize_revision(revision)
return cb(normpath, normrev)


If this makes sense, should I open a review with my proposed changes?

On Thursday, 22 August 2019 13:34:16 UTC-6, Rob Petti wrote:
>
> Hi Folks,
>
> We're having an issue with one of our SVN repositories right now. It 
> appears almost as if ReviewBoard can't handle files that contain "#" in 
> their names. I've attached a screenshot of the error. Of particular note is 
> that the error seems to suggest that it's truncating the filename from '#' 
> and erroneously trying to use that to locate the file in the repository.
>
> Would anyone know how to overcome this problem? Obviously we could work 
> around it by changing the file names, but this is a naming convention 
> that's required by our product and cannot be changed.
>
> Thanks!
> ~Rob
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/533d838b-61ab-4263-a1c6-2dbd3a0b61e7%40googlegroups.com.

Re: There was an error displaying this diff.

[David Trowbridge]

Bitbucket recently turned off a bunch of old APIs without any notice,
including one that Review Board used. We put out an update that fixes this
in Review Board 3.0.15:
https://www.reviewboard.org/docs/releasenotes/reviewboard/3.0.15/

David

On Thu, Jul 25, 2019 at 8:47 AM Birendra Rawat 
wrote:

> Resource removed
>
> This may be a bug in the software, a temporary outage, or an issue with
> the format of your diff.
>
> Please try again, and if you still have trouble, contact support.
>
> Details
>
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/views.py",
> line 300, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 298, in cache_memoize
> compress_large_data))
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 252, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 295, in 
> lambda: [lookup_callable()],
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py",
> line 669, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",
> line 786, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 298, in cache_memoize
> compress_large_data))
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 252, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 295, in 
> lambda: [lookup_callable()],
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/chunk_generator.py",
> line 792, in get_chunks_uncached
> self.encoding_list)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/diffviewer/diffutils.py",
> line 199, in get_original_file
> request=request)
>   File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py",
> line 362, in get_file
> large_data=True)[0]
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 298, in cache_memoize
> compress_large_data))
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 252, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/lib/python2.7/site-packages/djblets/cache/backend.py", line
> 295, in 
> lambda: [lookup_callable()],
>   File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py",
> line 361, in 
> request)],
>   File "/usr/lib/python2.7/site-packages/reviewboard/scmtools/models.py",
> line 543, in _get_file_uncached
> base_commit_id=base_commit_id)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py",
> line 306, in get_file
> base_commit_id)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py",
> line 608, in _api_get_src
> return self._api_get(url, raw_content=True)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py",
> line 687, in _api_get
> self._check_api_error(e)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/hostingsvcs/bitbucket.py",
> line 724, in _check_api_error
> rsp=e)
> HostingServiceAPIError: Resource removed
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/bba923f2-12a6-4af7-a36f-7c997791e795%40go

Re: There was an error displaying this diff.

[Thomas McLeod]

Ok, so apparently I have to give the full path of each file that I want to
include in the diff, is that correct? How do I ignore whitespace in the
diff?
T McLeod

On Tue, May 7, 2019 at 5:45 PM Thomas McLeod  wrote:

> I created the diff. I can't get rbtools to create a diff between two
> revisions AND limit the review files. When I tell I give git hashes rbt
> post always creates a diff for the entire repository, though I want to
> review only a small part of it. Furthermore rbt post always creates diffs
> with significant white space. this occurs even though the debug output
> shows the correct git command with a file spec following "--".
>
> Thomas McLeod
>
>
> On Tue, May 7, 2019 at 5:38 PM David Trowbridge 
> wrote:
>
>> What is "review_diff.diff" and how did you create it? Is there a reason
>> why you're creating the diff beforehand instead of just letting rbtools
>> make the diff between the specified revisions?
>>
>> -David
>>
>> On Tue, May 7, 2019 at 2:34 PM  wrote:
>>
>>> I'm just trying to post a diff to a review. But the error I get is
>>>
>>>
>>>  There was an error displaying this diff.
>>>  The patch to ' didn't apply cleanly. The temporary files have
>>> been left in '/tmp/reviewboard.VRycmo' for debugging purposes.
>>> `patch` returned:
>>>
>>>  This may be a bug in the software, a temporary outage, or an issue
>>>  with the format of your diff.
>>>
>>>  Please try again, and if you still have trouble,
>>>  contact support.
>>>
>>>
>>> Kinda disappointing
>>>
>>>
>>> $ rbt post -r=1382 --submit-as=tmcleod --diff-only
>>> --diff-filename="review_diff.diff" --debug 95f4edc6..7c503a5a>>> RBTools
>>> 1.0.2
>>> >>> Python 2.7.12 (default, Nov 12 2018, 14:36:49)
>>> [GCC 5.4.0 20160609]
>>> >>> Running on Linux-4.15.0-48-generic-x86_64-with-Ubuntu-16.04-xenial
>>> >>> Home = /home/tmcleod
>>> >>> Current directory =
>>> /home/tmcleod/src-git/Core-4.9/video/netvr/videostreamer
>>> >>> Command line: rbt post -r=1382 --submit-as=tmcleod --diff-only
>>> --diff-filename=review_diff.diff --debug 95f4edc6..7c503a5a
>>> >>> Running: tf vc help
>>> >>> Checking for a Git repository...
>>> >>> Running: git rev-parse --git-dir
>>> >>> Running: git config core.bare
>>> >>> Running: git rev-parse --show-toplevel
>>> >>> Running: git symbolic-ref -q HEAD
>>> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.merge
>>> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.remote
>>> >>> Running: git config --get remote.origin.url
>>> >>> Repository info: Path: , Base path: , Supports changesets:
>>> False
>>> >>> Making HTTP GET request to https://reviews.s2sys.com/reviews/api/
>>> >>> Making HTTP GET request to
>>> https://reviews.s2sys.com/reviews/api/validation/diffs/
>>> >>> Cached response for HTTP GET
>>> https://reviews.s2sys.com/reviews/api/validation/diffs/ expired and was
>>> modified
>>> >>> Making HTTP POST request to
>>> https://reviews.s2sys.com/reviews/api/validation/diffs/
>>> >>> Making HTTP GET request to
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft&only-fields=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>>> >>> Cached response for HTTP GET
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft&only-fields=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>>> expired and was not modified
>>> >>> Making HTTP GET request to
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>>> >>> Cached response for HTTP GET
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>>> expired and was modified
>>> >>> Making HTTP POST request to
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/
>>> >>> Making HTTP GET request to
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>>> >>> Cached response for HTTP GET
>>> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>>> expired and was not modified
>>> Review request #1382 posted.
>>>
>>> https://reviews.s2sys.com/reviews/r/1382/
>>> https://reviews.s2sys.com/reviews/r/1382/diff/
>>>
>>>
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Review Board Community" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/reviewboard/a5700ca4-f872-4cba-bcd4-6502d1cc86c2%40googlegroups.com
>>> 

Re: There was an error displaying this diff.

[Thomas McLeod]

I created the diff. I can't get rbtools to create a diff between two
revisions AND limit the review files. When I tell I give git hashes rbt
post always creates a diff for the entire repository, though I want to
review only a small part of it. Furthermore rbt post always creates diffs
with significant white space. this occurs even though the debug output
shows the correct git command with a file spec following "--".

Thomas McLeod


On Tue, May 7, 2019 at 5:38 PM David Trowbridge  wrote:

> What is "review_diff.diff" and how did you create it? Is there a reason
> why you're creating the diff beforehand instead of just letting rbtools
> make the diff between the specified revisions?
>
> -David
>
> On Tue, May 7, 2019 at 2:34 PM  wrote:
>
>> I'm just trying to post a diff to a review. But the error I get is
>>
>>
>>  There was an error displaying this diff.
>>  The patch to ' didn't apply cleanly. The temporary files have
>> been left in '/tmp/reviewboard.VRycmo' for debugging purposes.
>> `patch` returned:
>>
>>  This may be a bug in the software, a temporary outage, or an issue
>>  with the format of your diff.
>>
>>  Please try again, and if you still have trouble,
>>  contact support.
>>
>>
>> Kinda disappointing
>>
>>
>> $ rbt post -r=1382 --submit-as=tmcleod --diff-only
>> --diff-filename="review_diff.diff" --debug 95f4edc6..7c503a5a>>> RBTools
>> 1.0.2
>> >>> Python 2.7.12 (default, Nov 12 2018, 14:36:49)
>> [GCC 5.4.0 20160609]
>> >>> Running on Linux-4.15.0-48-generic-x86_64-with-Ubuntu-16.04-xenial
>> >>> Home = /home/tmcleod
>> >>> Current directory =
>> /home/tmcleod/src-git/Core-4.9/video/netvr/videostreamer
>> >>> Command line: rbt post -r=1382 --submit-as=tmcleod --diff-only
>> --diff-filename=review_diff.diff --debug 95f4edc6..7c503a5a
>> >>> Running: tf vc help
>> >>> Checking for a Git repository...
>> >>> Running: git rev-parse --git-dir
>> >>> Running: git config core.bare
>> >>> Running: git rev-parse --show-toplevel
>> >>> Running: git symbolic-ref -q HEAD
>> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.merge
>> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.remote
>> >>> Running: git config --get remote.origin.url
>> >>> Repository info: Path: , Base path: , Supports changesets:
>> False
>> >>> Making HTTP GET request to https://reviews.s2sys.com/reviews/api/
>> >>> Making HTTP GET request to
>> https://reviews.s2sys.com/reviews/api/validation/diffs/
>> >>> Cached response for HTTP GET
>> https://reviews.s2sys.com/reviews/api/validation/diffs/ expired and was
>> modified
>> >>> Making HTTP POST request to
>> https://reviews.s2sys.com/reviews/api/validation/diffs/
>> >>> Making HTTP GET request to
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft&only-fields=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>> >>> Cached response for HTTP GET
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft&only-fields=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
>> expired and was not modified
>> >>> Making HTTP GET request to
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>> >>> Cached response for HTTP GET
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
>> expired and was modified
>> >>> Making HTTP POST request to
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/
>> >>> Making HTTP GET request to
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>> >>> Cached response for HTTP GET
>> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
>> expired and was not modified
>> Review request #1382 posted.
>>
>> https://reviews.s2sys.com/reviews/r/1382/
>> https://reviews.s2sys.com/reviews/r/1382/diff/
>>
>>
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/reviewboard/a5700ca4-f872-4cba-bcd4-6502d1cc86c2%40googlegroups.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
>

Re: There was an error displaying this diff.

[David Trowbridge]

What is "review_diff.diff" and how did you create it? Is there a reason why
you're creating the diff beforehand instead of just letting rbtools make
the diff between the specified revisions?

-David

On Tue, May 7, 2019 at 2:34 PM  wrote:

> I'm just trying to post a diff to a review. But the error I get is
>
>
>  There was an error displaying this diff.
>  The patch to ' didn't apply cleanly. The temporary files have
> been left in '/tmp/reviewboard.VRycmo' for debugging purposes.
> `patch` returned:
>
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>
>  Please try again, and if you still have trouble,
>  contact support.
>
>
> Kinda disappointing
>
>
> $ rbt post -r=1382 --submit-as=tmcleod --diff-only
> --diff-filename="review_diff.diff" --debug 95f4edc6..7c503a5a>>> RBTools
> 1.0.2
> >>> Python 2.7.12 (default, Nov 12 2018, 14:36:49)
> [GCC 5.4.0 20160609]
> >>> Running on Linux-4.15.0-48-generic-x86_64-with-Ubuntu-16.04-xenial
> >>> Home = /home/tmcleod
> >>> Current directory =
> /home/tmcleod/src-git/Core-4.9/video/netvr/videostreamer
> >>> Command line: rbt post -r=1382 --submit-as=tmcleod --diff-only
> --diff-filename=review_diff.diff --debug 95f4edc6..7c503a5a
> >>> Running: tf vc help
> >>> Checking for a Git repository...
> >>> Running: git rev-parse --git-dir
> >>> Running: git config core.bare
> >>> Running: git rev-parse --show-toplevel
> >>> Running: git symbolic-ref -q HEAD
> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.merge
> >>> Running: git config --get branch.feature/5.1_vr1_videostreamer.remote
> >>> Running: git config --get remote.origin.url
> >>> Repository info: Path: , Base path: , Supports changesets:
> False
> >>> Making HTTP GET request to https://reviews.s2sys.com/reviews/api/
> >>> Making HTTP GET request to
> https://reviews.s2sys.com/reviews/api/validation/diffs/
> >>> Cached response for HTTP GET
> https://reviews.s2sys.com/reviews/api/validation/diffs/ expired and was
> modified
> >>> Making HTTP POST request to
> https://reviews.s2sys.com/reviews/api/validation/diffs/
> >>> Making HTTP GET request to
> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft&only-fields=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
> >>> Cached response for HTTP GET
> https://reviews.s2sys.com/reviews/api/review-requests/1382/?only-links=diffs%2Cdraft&only-fields=absolute_url%2Cbugs_closed%2Cid%2Cstatus%2Cpublic
> expired and was not modified
> >>> Making HTTP GET request to
> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
> >>> Cached response for HTTP GET
> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/?only-fields=
> expired and was modified
> >>> Making HTTP POST request to
> https://reviews.s2sys.com/reviews/api/review-requests/1382/diffs/
> >>> Making HTTP GET request to
> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
> >>> Cached response for HTTP GET
> https://reviews.s2sys.com/reviews/api/review-requests/1382/draft/?only-fields=commit_id
> expired and was not modified
> Review request #1382 posted.
>
> https://reviews.s2sys.com/reviews/r/1382/
> https://reviews.s2sys.com/reviews/r/1382/diff/
>
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/a5700ca4-f872-4cba-bcd4-6502d1cc86c2%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAFS3VNU%2BQ25B%3DWokdeFQDw%3Do0yjiD_Ku3m0bQ9UiM%3DvZ4excoA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: There was an error displaying this diff.

[huangminzh]

Hi Michal,

Did you fix this issue? I came across the same problem.

Thanks,
Min

On Tuesday, July 31, 2018 at 1:19:47 AM UTC-7, Michał Pieniak wrote:
>
> Christian,
>
> Thanks for response.
>
> I removed original post because of the naming our projects and renamed it:
>
> *"Hello,*
>
> *I have a problem with my RB diff. *
>
> *The patch to '...' didn't apply cleanly. The temporary files have 
> been left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
> *`patch` returned: *
>
> 
>
> * This may be a bug in the software, a temporary outage, or an issue*
> * with the format of your diff.*
>
> 
> 
>
>
> * Please try again, and if you still have trouble*
>
>
> *Traceback (most recent call last):*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
>  
> line 299, in get*
> *response = renderer.render_to_response(request)*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 56, in render_to_response*
> *return HttpResponse(self.render_to_string(request))*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 74, in render_to_string*
> *large_data=True)*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 295, in cache_memoize*
> *compress_large_data))*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 249, in cache_memoize_iter*
> *items = items_or_callable()*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 292, in *
> *lambda: [lookup_callable()],*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 73, in *
> *lambda: self.render_to_string_uncached(request),*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 87, in render_to_string_uncached*
> *request=request)*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 667, in populate_diff_chunks*
> *chunks = list(generator.get_chunks())*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 756, in get_chunks*
> *for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 107, in get_chunks*
> *large_data=True)*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 295, in cache_memoize*
> *compress_large_data))*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 249, in cache_memoize_iter*
> *items = items_or_callable()*
> *  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
> line 292, in *
> *lambda: [lookup_callable()],*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 106, in *
> *lambda: list(self.get_chunks_uncached()),*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 763, in get_chunks_uncached*
> *new = get_patched_file(old, self.filediff, self.request)*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 233, in get_patched_file*
> *return patch(diff, buffer, filediff.dest_file, request)*
> *  File 
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 169, in patch*
> *'output': stderr,*
> *Exception: The patch to '.' didn't apply cleanly. The temporary 
> files have been left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
> *`patch` returned: *
>
> *Its happen only for 1 revision. When i move to revision number of 2 
> problem does not exist."*
>
>
> Returning to our topic we will try check to our Unicode BOM on the 
> perforce and upgrade our RB version to latest. I will let you know.
>
> Thanks a lot !
> Michal
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: There was an error displaying this diff.

[Michał Pieniak]

Christian,

Thanks for response.

I removed original post because of the naming our projects and renamed it:

*"Hello,*

*I have a problem with my RB diff. *

*The patch to '...' didn't apply cleanly. The temporary files have been 
left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
*`patch` returned: *



* This may be a bug in the software, a temporary outage, or an issue*
* with the format of your diff.*





* Please try again, and if you still have trouble*


*Traceback (most recent call last):*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 299, in get*
*response = renderer.render_to_response(request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response*
*return HttpResponse(self.render_to_string(request))*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string*
*large_data=True)*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize*
*compress_large_data))*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter*
*items = items_or_callable()*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in *
*lambda: [lookup_callable()],*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in *
*lambda: self.render_to_string_uncached(request),*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached*
*request=request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 667, in populate_diff_chunks*
*chunks = list(generator.get_chunks())*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks*
*for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks*
*large_data=True)*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize*
*compress_large_data))*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter*
*items = items_or_callable()*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in *
*lambda: [lookup_callable()],*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in *
*lambda: list(self.get_chunks_uncached()),*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached*
*new = get_patched_file(old, self.filediff, self.request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 233, in get_patched_file*
*return patch(diff, buffer, filediff.dest_file, request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 169, in patch*
*'output': stderr,*
*Exception: The patch to '.' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
*`patch` returned: *

*Its happen only for 1 revision. When i move to revision number of 2 
problem does not exist."*


Returning to our topic we will try check to our Unicode BOM on the perforce 
and upgrade our RB version to latest. I will let you know.

Thanks a lot !
Michal

-- 





--

The contents of this e-mail and any attachments hereto
are intended solely 
for the person or entity to which they are addressed to and
contain the 
sender's confidential information, and/or legally privileged
information. 
Any disclosure, dissemination, copying, printing and forwarding to

unauthorized persons or other misuse of this e-mail which is not compliant 
with
its purpose is prohibited and may be against the law. If you have 
received this
e-mail by accident, please immediately contact the sender and 
delete the message
in its entirety.

--

Treść tej wiadomości wraz z załącznikami jest przeznaczona wyłącznie dla

jej adresata i zawiera poufne informacje nadawcy i/lub informacje prawnie

chronione. Udostępnianie, rozpowszechnianie, kopiowanie i prze

Re: There was an error displaying this diff.

[Michał Pieniak]

Christian,

Thanks for response.

I removed original post because of the naming our projects and renamed it:

*"Hello,*

*I have a problem with my RB diff. *

*The patch to '...' didn't apply cleanly. The temporary files have been 
left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
*`patch` returned: *



* This may be a bug in the software, a temporary outage, or an issue*
* with the format of your diff.*





* Please try again, and if you still have trouble*


*Traceback (most recent call last):*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
 
line 299, in get*
*response = renderer.render_to_response(request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 56, in render_to_response*
*return HttpResponse(self.render_to_string(request))*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 74, in render_to_string*
*large_data=True)*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize*
*compress_large_data))*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter*
*items = items_or_callable()*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in *
*lambda: [lookup_callable()],*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 73, in *
*lambda: self.render_to_string_uncached(request),*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
 
line 87, in render_to_string_uncached*
*request=request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 667, in populate_diff_chunks*
*chunks = list(generator.get_chunks())*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 756, in get_chunks*
*for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 107, in get_chunks*
*large_data=True)*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 295, in cache_memoize*
*compress_large_data))*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 249, in cache_memoize_iter*
*items = items_or_callable()*
*  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", 
line 292, in *
*lambda: [lookup_callable()],*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 106, in *
*lambda: list(self.get_chunks_uncached()),*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
 
line 763, in get_chunks_uncached*
*new = get_patched_file(old, self.filediff, self.request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 233, in get_patched_file*
*return patch(diff, buffer, filediff.dest_file, request)*
*  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
 
line 169, in patch*
*'output': stderr,*
*Exception: The patch to '.' didn't apply cleanly. The temporary 
files have been left in '/tmp/reviewboard.4L2LuH' for debugging purposes.*
*`patch` returned: *

*Its happen only for 1 revision. When i move to revision number of 2 
problem does not exist."*


Returning to our topic we will try check to our Unicode BOM on the perforce 
and upgrade our RB version to latest. I will let you know.

Thanks a lot !
Michal

W dniu poniedziałek, 30 lipca 2018 22:25:53 UTC+2 użytkownik Christian 
Hammond napisał:
>
> Is this a Perforce repository?
>
> I'd need to see the actual source code and reject files to know more 
> (which I'm sure can't be made public), but any number of things could have 
> caused that. If this is a Perforce repository, you might have hit an issue 
> with a conflict involving a Unicode BOM marker in the file. Perforce went 
> through a series of regressions at one point involving these markers, and 
> depending on the versions of p4d and p4python and the metadata state of the 
> file, you could hit this scenario. We'd done work in more recent versions 
> in the 3.0.x releases to try to work around this better.
>
> Christian
>
> On Mon, Jul 30, 2018 at 8:43 AM Michał Pieniak  > wrote:
>
>> Hello,
>>
>> I have a problem with my RB diff. 
>>
>> The patch to 
>> '//tech/dev-cs-full-body-ik/cs/source/code/game/Cornerstone/

Re: There was an error displaying this diff.

[Christian Hammond]

Is this a Perforce repository?

I'd need to see the actual source code and reject files to know more (which
I'm sure can't be made public), but any number of things could have caused
that. If this is a Perforce repository, you might have hit an issue with a
conflict involving a Unicode BOM marker in the file. Perforce went through
a series of regressions at one point involving these markers, and depending
on the versions of p4d and p4python and the metadata state of the file, you
could hit this scenario. We'd done work in more recent versions in the
3.0.x releases to try to work around this better.

Christian

On Mon, Jul 30, 2018 at 8:43 AM Michał Pieniak 
wrote:

> Hello,
>
> I have a problem with my RB diff.
>
> The patch to
> '//tech/dev-cs-full-body-ik/cs/source/code/game/Cornerstone/Game/Player/PlayerDI.cpp'
> didn't apply cleanly. The temporary files have been left in
> '/tmp/reviewboard.4L2LuH' for debugging purposes.
> `patch` returned:
>
>
>
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>
>
>
>
>
>  Please try again, and if you still have trouble
>
>
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/views.py",
> line 299, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 667, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 763, in get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 233, in get_patched_file
> return patch(diff, buffer, filediff.dest_file, request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.7-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 169, in patch
> 'output': stderr,
> Exception: The patch to
> '//tech/dev-cs-full-body-ik/cs/source/code/game/Cornerstone/Game/Player/PlayerDI.cpp'
> didn't apply cleanly. The temporary files have been left in
> '/tmp/reviewboard.4L2LuH' for debugging purposes.
> `patch` returned:
>
> Its happen only for 1 revision. When i move to revision number of 2
> problem does not exist.
>
>
> 
>
>
>
> What is that mean?
>
> Thanks
> Michał
>
> --
>
> 
> --
> The contents of this e-mail and any attachments

Re: There was an error displaying this diff

[David Trowbridge]

Power Pack is supported on Review Board 2.0+, though we of course recommend
updating if you can. There should be no specific RBTools requirements,
assuming you're on a relatively modern version (0.7.x).

If you e-mail us at supp...@beanbaginc.com, I can get you set up with a
beta build. You'll want to request a trial key at
https://www.reviewboard.org/powerpack/trial/

-David

On Wed, Jan 10, 2018 at 7:43 AM  wrote:

> Hi,
> That sounds interesting.
> Are there any version requirements for RBTools or Reviewboard?
>
> On Monday, January 8, 2018 at 9:16:28 PM UTC+2, David Trowbridge wrote:
>
>> Bitbucket Server (nee Stash) isn't yet supported by Review Board. We're
>> actively working on adding support in Power Pack. If you'd like to help us
>> test it out, I can get you a beta build.
>>
>> -David
>>
>> On Mon, Jan 8, 2018 at 8:29 AM  wrote:
>>
> Hello,
>>>
>>> I'm trying to post review from our hosted Bitbucket, to hosted
>>> Reviewboard using the RBTools.
>>> The Reviewboard version is 2.0.11
>>> The RBTools version is 0.7.2
>>> It seems to have some issue with the diff of the files but I can't
>>> figure out what it is.
>>> Is there any place I can check the reason of the failure?
>>>
>>> I configured a new repository in reviewboard as a custom git repository
>>> with a matching raw url mask.
>>>
>>> I use the following command to send the review:
>>>
>>> */usr/local/bin/rbt post -d -p --repository-type git --server
>>> http://rb.server.com  --repository my-test-repo
>>> --username post-commit-user --password  post-commit-user --tracking-branch
>>> origin/master --submit-as myuser --guess-summary --guess-description
>>> --branch master c19f372a155993747a9206f0c8fe0085d02acb2b*
>>>
>>> And I'm getting a msg that the review was posted.
>>> The STDERR is:
>>> * RBTools 0.7.2*
>>> *>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
>>> *[GCC 4.8.4]*
>>> *>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
>>> *>>> Home = /my_home*
>>> *>>> Current directory = /my_home/shared/data/repositories/902*
>>> *>>> Checking for a Git repository...*
>>> *>>> Running: git rev-parse --git-dir*
>>> *>>> Running: git config core.bare*
>>> *>>> Running: git symbolic-ref -q HEAD*
>>> *>>> Running: git config --get branch.master.merge*
>>> *>>> Command exited with rc 1: ['git', 'config', '--get',
>>> u'branch.master.merge']*
>>> *---*
>>> *>>> Running: git config --get branch.master.remote*
>>> *>>> Command exited with rc 1: ['git', 'config', '--get',
>>> u'branch.master.remote']*
>>> *---*
>>> *>>> Running: git config --get remote.origin.url*
>>> *>>> Command exited with rc 1: ['git', 'config', '--get',
>>> 'remote.origin.url']*
>>> *---*
>>> *>>> Running: git config --get remote.origin.url*
>>> *>>> Command exited with rc 1: ['git', 'config', '--get',
>>> 'remote.origin.url']*
>>> *---*
>>> *>>> repository info: Path: /my_home/shared/data/repositories/902, Base
>>> path: , Supports changesets: False*
>>> *>>> Making HTTP GET request to http://rb.server.com/api/
>>> *
>>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
>>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
>>> *>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7
>>> master*
>>> *>>> Running: git rev-parse --git-dir*
>>> *>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff
>>> --no-color --full-index --ignore-submodules -M --no-ext-diff
>>> 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
>>> *>>> Running: git log --reverse --pretty=format:%s%n%n%b
>>> ^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7
>>> c19f372a155993747a9206f0c8fe0085d02acb2b*
>>> *>>> Making HTTP GET request to
>>> http://rb.server.com/api/review-requests/?only-links=create&only-fields=
>>> *
>>> *>>> Making HTTP POST request to http://rb
>>> . server.com/api/review-requests/
>>> *
>>> *>>> Making HTTP GET request to http://rb
>>> . server.com/api/review-requests/304341/diffs/?only-fields=
>>> *
>>> *>>> Making HTTP POST request to http://rb
>>> . server.com/api/review-requests/304341/diffs/
>>> *
>>> *>>> Making HTTP GET request to http://rb
>>> . 
>>> server.com/api/review-requests/304341/draft/?only-fields=commit_id
>>> *
>>> *>>> Making HTTP PUT request to http://rb
>>> . server.com/api/review-requests/304341/draft/
>>> *
>>>
>>> The diff in the review showing the following:
>>> *The patch to 'testfile.sh' didn't apply cleanly. The temporary files
>>> have been left in '/tmp/reviewboard.Pj6_Hj' for debuggin

Re: There was an error displaying this diff

[akarasik]

Hi,
That sounds interesting.
Are there any version requirements for RBTools or Reviewboard?

On Monday, January 8, 2018 at 9:16:28 PM UTC+2, David Trowbridge wrote:
>
> Bitbucket Server (nee Stash) isn't yet supported by Review Board. We're 
> actively working on adding support in Power Pack. If you'd like to help us 
> test it out, I can get you a beta build.
>
> -David
>
> On Mon, Jan 8, 2018 at 8:29 AM > wrote:
>
>> Hello,
>>
>> I'm trying to post review from our hosted Bitbucket, to hosted 
>> Reviewboard using the RBTools.
>> The Reviewboard version is 2.0.11
>> The RBTools version is 0.7.2
>> It seems to have some issue with the diff of the files but I can't figure 
>> out what it is.
>> Is there any place I can check the reason of the failure?
>>
>> I configured a new repository in reviewboard as a custom git repository 
>> with a matching raw url mask.
>>
>> I use the following command to send the review:
>>
>> */usr/local/bin/rbt post -d -p --repository-type git --server 
>> http://rb.server.com  --repository my-test-repo 
>> --username post-commit-user --password  post-commit-user --tracking-branch 
>> origin/master --submit-as myuser --guess-summary --guess-description 
>> --branch master c19f372a155993747a9206f0c8fe0085d02acb2b*
>>
>> And I'm getting a msg that the review was posted.
>> The STDERR is:
>> * RBTools 0.7.2*
>> *>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
>> *[GCC 4.8.4]*
>> *>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
>> *>>> Home = /my_home*
>> *>>> Current directory = /my_home/shared/data/repositories/902*
>> *>>> Checking for a Git repository...*
>> *>>> Running: git rev-parse --git-dir*
>> *>>> Running: git config core.bare*
>> *>>> Running: git symbolic-ref -q HEAD*
>> *>>> Running: git config --get branch.master.merge*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> u'branch.master.merge']*
>> *---*
>> *>>> Running: git config --get branch.master.remote*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> u'branch.master.remote']*
>> *---*
>> *>>> Running: git config --get remote.origin.url*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> 'remote.origin.url']*
>> *---*
>> *>>> Running: git config --get remote.origin.url*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> 'remote.origin.url']*
>> *---*
>> *>>> repository info: Path: /my_home/shared/data/repositories/902, Base 
>> path: , Supports changesets: False*
>> *>>> Making HTTP GET request to http://rb.server.com/api/ 
>> *
>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
>> *>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
>> master*
>> *>>> Running: git rev-parse --git-dir*
>> *>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
>> --no-color --full-index --ignore-submodules -M --no-ext-diff 
>> 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Running: git log --reverse --pretty=format:%s%n%n%b 
>> ^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
>> c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Making HTTP GET request to 
>> http://rb.server.com/api/review-requests/?only-links=create&only-fields= 
>> *
>> *>>> Making HTTP POST request to http://rb 
>> . server.com/api/review-requests/ 
>> *
>> *>>> Making HTTP GET request to http://rb 
>> . server.com/api/review-requests/304341/diffs/?only-fields= 
>> *
>> *>>> Making HTTP POST request to http://rb 
>> . server.com/api/review-requests/304341/diffs/ 
>> *
>> *>>> Making HTTP GET request to http://rb 
>> . 
>> server.com/api/review-requests/304341/draft/?only-fields=commit_id 
>> *
>> *>>> Making HTTP PUT request to http://rb 
>> . server.com/api/review-requests/304341/draft/ 
>> *
>>
>> The diff in the review showing the following:
>> *The patch to 'testfile.sh' didn't apply cleanly. The temporary files 
>> have been left in '/tmp/reviewboard.Pj6_Hj' for debugging purposes.*
>> *`patch` returned: *
>> *This may be a bug in the software, a temporary outage, or an issue with 
>> the format of your diff.*
>>
>> And the tmp folder contains following files:
>>
>> *testfile.sh.diff*
>> *diff --git a/testfile.sh b/testfile.sh*
>> *index 
>> 083e35784e55e496abb30dffeed7ab11e3d21747..6e7fbe249ce5d2fc350a2a0085f5c11dfaea34df
>>  
>> 100644*
>> *--- a/testfile.sh*
>> *+++ b/testfile.sh*
>> *@@ -1,4 +1,3 @@*
>> * #!/bin/bash*
>>
>> * echo "test"*
>> *-ec

Re: There was an error displaying this diff

[David Trowbridge]

Bitbucket Server (nee Stash) isn't yet supported by Review Board. We're
actively working on adding support in Power Pack. If you'd like to help us
test it out, I can get you a beta build.

-David

On Mon, Jan 8, 2018 at 8:29 AM  wrote:

> Hello,
>
> I'm trying to post review from our hosted Bitbucket, to hosted Reviewboard
> using the RBTools.
> The Reviewboard version is 2.0.11
> The RBTools version is 0.7.2
> It seems to have some issue with the diff of the files but I can't figure
> out what it is.
> Is there any place I can check the reason of the failure?
>
> I configured a new repository in reviewboard as a custom git repository
> with a matching raw url mask.
>
> I use the following command to send the review:
>
> */usr/local/bin/rbt post -d -p --repository-type git --server
> http://rb.server.com  --repository my-test-repo
> --username post-commit-user --password  post-commit-user --tracking-branch
> origin/master --submit-as myuser --guess-summary --guess-description
> --branch master c19f372a155993747a9206f0c8fe0085d02acb2b*
>
> And I'm getting a msg that the review was posted.
> The STDERR is:
> * RBTools 0.7.2*
> *>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
> *[GCC 4.8.4]*
> *>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
> *>>> Home = /my_home*
> *>>> Current directory = /my_home/shared/data/repositories/902*
> *>>> Checking for a Git repository...*
> *>>> Running: git rev-parse --git-dir*
> *>>> Running: git config core.bare*
> *>>> Running: git symbolic-ref -q HEAD*
> *>>> Running: git config --get branch.master.merge*
> *>>> Command exited with rc 1: ['git', 'config', '--get',
> u'branch.master.merge']*
> *---*
> *>>> Running: git config --get branch.master.remote*
> *>>> Command exited with rc 1: ['git', 'config', '--get',
> u'branch.master.remote']*
> *---*
> *>>> Running: git config --get remote.origin.url*
> *>>> Command exited with rc 1: ['git', 'config', '--get',
> 'remote.origin.url']*
> *---*
> *>>> Running: git config --get remote.origin.url*
> *>>> Command exited with rc 1: ['git', 'config', '--get',
> 'remote.origin.url']*
> *---*
> *>>> repository info: Path: /my_home/shared/data/repositories/902, Base
> path: , Supports changesets: False*
> *>>> Making HTTP GET request to http://rb.server.com/api/
> *
> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
> *>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7
> master*
> *>>> Running: git rev-parse --git-dir*
> *>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff
> --no-color --full-index --ignore-submodules -M --no-ext-diff
> 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
> *>>> Running: git log --reverse --pretty=format:%s%n%n%b
> ^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7
> c19f372a155993747a9206f0c8fe0085d02acb2b*
> *>>> Making HTTP GET request to
> http://rb.server.com/api/review-requests/?only-links=create&only-fields=
> *
> *>>> Making HTTP POST request to http://rb
> . server.com/api/review-requests/
> *
> *>>> Making HTTP GET request to http://rb
> . server.com/api/review-requests/304341/diffs/?only-fields=
> *
> *>>> Making HTTP POST request to http://rb
> . server.com/api/review-requests/304341/diffs/
> *
> *>>> Making HTTP GET request to http://rb
> . 
> server.com/api/review-requests/304341/draft/?only-fields=commit_id
> *
> *>>> Making HTTP PUT request to http://rb
> . server.com/api/review-requests/304341/draft/
> *
>
> The diff in the review showing the following:
> *The patch to 'testfile.sh' didn't apply cleanly. The temporary files have
> been left in '/tmp/reviewboard.Pj6_Hj' for debugging purposes.*
> *`patch` returned: *
> *This may be a bug in the software, a temporary outage, or an issue with
> the format of your diff.*
>
> And the tmp folder contains following files:
>
> *testfile.sh.diff*
> *diff --git a/testfile.sh b/testfile.sh*
> *index
> 083e35784e55e496abb30dffeed7ab11e3d21747..6e7fbe249ce5d2fc350a2a0085f5c11dfaea34df
> 100644*
> *--- a/testfile.sh*
> *+++ b/testfile.sh*
> *@@ -1,4 +1,3 @@*
> * #!/bin/bash*
>
> * echo "test"*
> *-echo "another test"*
>
> *tmplt0vvX*
> *#!/bin/bash*
>
> *echo "test"*
>
> *tmplt0vvX-new* - empty file
>
> *tmplt0vvX-new.rej*
> *--- testfile.sh*
> *+++ testfile.sh*
> *@@ -1,4 +1,3 @@*
> * #!/bin/bash*
>
> * echo "test"*
> *-echo "another test"*
>
>
>
> The above terms reflect a potential business arrangement, are provided 

Re: "There was an error displaying this diff" when config rb via gitweb configuration

[Zizou Fablenas]

Hi Christian,

Exciting. Look forward to get it.
Thanks

On Thursday, 31 August 2017 12:06:28 UTC+8, Christian Hammond wrote:
>
> Hi Zizou,
>
> Subgroups aren't supported today, but we should have support in next 
> week's release (aiming for Tuesday).
>
> Christian
>
> On Wed, Aug 30, 2017 at 7:00 PM, Zizou Fablenas  > wrote:
>
>> Hi christian,
>> Thanks for you reply.
>> We've configured the repo as a GitLab repository before, but when we 
>> started to use 'subgroup's on Gitlab, the reviewboard can not locate the 
>> repo. In the GitLab subgroup context, the repository is under the path 
>> '://' while it seems that repository 
>> doesn't have knowledge about ''. There comes we tried the plain 
>> repository. 
>> Do you mean the newer version supports Gitlab's 'subgroup' feature? Did I 
>> get it?
>> I appreciate your help.
>>
>> On Thursday, 31 August 2017 05:57:26 UTC+8, Christian Hammond wrote:
>>>
>>> Hi,
>>>
>>> You'll need to configure the repository as a GitLab repository. A plain 
>>> Git repository won't work. Review Board must talk to the GitLab API in 
>>> order to access files, correctly validate diffs, and display the diff 
>>> viewer.
>>>
>>> You'll also want to grab a newer 2.5.x release for some other GitLab 
>>> fixes. Some more fixes for GitLab are coming in the next 2.5.x release, 
>>> which should be out next Tuesday.
>>>
>>> Christian
>>>
>>> On Wed, Aug 30, 2017 at 2:44 AM, Zizou Fablenas  
>>> wrote:
>>>
 hi guys,

 to support gitlab subgroup configurations, we had configured rb as 
 follows,


 

 when posted via "rbt post -g", we got errors as follows,


 




 the version of reviewboard is 2.5.9.
 Could you help me to resolve such a problem, please?

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>
>>>
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: "There was an error displaying this diff" when config rb via gitweb configuration

[Christian Hammond]

Hi Zizou,

Subgroups aren't supported today, but we should have support in next week's
release (aiming for Tuesday).

Christian

On Wed, Aug 30, 2017 at 7:00 PM, Zizou Fablenas  wrote:

> Hi christian,
> Thanks for you reply.
> We've configured the repo as a GitLab repository before, but when we
> started to use 'subgroup's on Gitlab, the reviewboard can not locate the
> repo. In the GitLab subgroup context, the repository is under the path
> '://' while it seems that
> repository doesn't have knowledge about ''. There comes we tried
> the plain repository.
> Do you mean the newer version supports Gitlab's 'subgroup' feature? Did I
> get it?
> I appreciate your help.
>
> On Thursday, 31 August 2017 05:57:26 UTC+8, Christian Hammond wrote:
>>
>> Hi,
>>
>> You'll need to configure the repository as a GitLab repository. A plain
>> Git repository won't work. Review Board must talk to the GitLab API in
>> order to access files, correctly validate diffs, and display the diff
>> viewer.
>>
>> You'll also want to grab a newer 2.5.x release for some other GitLab
>> fixes. Some more fixes for GitLab are coming in the next 2.5.x release,
>> which should be out next Tuesday.
>>
>> Christian
>>
>> On Wed, Aug 30, 2017 at 2:44 AM, Zizou Fablenas 
>> wrote:
>>
>>> hi guys,
>>>
>>> to support gitlab subgroup configurations, we had configured rb as
>>> follows,
>>>
>>>
>>> 
>>>
>>> when posted via "rbt post -g", we got errors as follows,
>>>
>>>
>>> 
>>>
>>>
>>>
>>>
>>> the version of reviewboard is 2.5.9.
>>> Could you help me to resolve such a problem, please?
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: "There was an error displaying this diff" when config rb via gitweb configuration

[Zizou Fablenas]

Hi christian,
Thanks for you reply.
We've configured the repo as a GitLab repository before, but when we 
started to use 'subgroup's on Gitlab, the reviewboard can not locate the 
repo. In the GitLab subgroup context, the repository is under the path 
'://' while it seems that repository 
doesn't have knowledge about ''. There comes we tried the plain 
repository. 
Do you mean the newer version supports Gitlab's 'subgroup' feature? Did I 
get it?
I appreciate your help.

On Thursday, 31 August 2017 05:57:26 UTC+8, Christian Hammond wrote:
>
> Hi,
>
> You'll need to configure the repository as a GitLab repository. A plain 
> Git repository won't work. Review Board must talk to the GitLab API in 
> order to access files, correctly validate diffs, and display the diff 
> viewer.
>
> You'll also want to grab a newer 2.5.x release for some other GitLab 
> fixes. Some more fixes for GitLab are coming in the next 2.5.x release, 
> which should be out next Tuesday.
>
> Christian
>
> On Wed, Aug 30, 2017 at 2:44 AM, Zizou Fablenas  > wrote:
>
>> hi guys,
>>
>> to support gitlab subgroup configurations, we had configured rb as 
>> follows,
>>
>>
>> 
>>
>> when posted via "rbt post -g", we got errors as follows,
>>
>>
>> 
>>
>>
>>
>>
>> the version of reviewboard is 2.5.9.
>> Could you help me to resolve such a problem, please?
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: "There was an error displaying this diff" when config rb via gitweb configuration

[Christian Hammond]

Hi,

You'll need to configure the repository as a GitLab repository. A plain Git
repository won't work. Review Board must talk to the GitLab API in order to
access files, correctly validate diffs, and display the diff viewer.

You'll also want to grab a newer 2.5.x release for some other GitLab fixes.
Some more fixes for GitLab are coming in the next 2.5.x release, which
should be out next Tuesday.

Christian

On Wed, Aug 30, 2017 at 2:44 AM, Zizou Fablenas  wrote:

> hi guys,
>
> to support gitlab subgroup configurations, we had configured rb as follows,
>
>
> 
>
> when posted via "rbt post -g", we got errors as follows,
>
>
> 
>
>
>
>
> the version of reviewboard is 2.5.9.
> Could you help me to resolve such a problem, please?
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: There was an error displaying this diff.

[Christian Hammond]

Hi Stephen,

This looks like a bug we fixed in 2.5.8. (2.5.10 is the latest version.) I
believe if you upgrade, it should be fixed.

See https://hellosplat.com/s/beanbag/tickets/4472/ for info on that bug
report.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Wed, Apr 26, 2017 at 12:49 AM, Stephen Lee 
wrote:

> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/views.py", line 275, in get
> response = renderer.render_to_response(request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/renderers.py", line 56, in
> render_to_response
> return HttpResponse(self.render_to_string(request))
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/renderers.py", line 74, in
> render_to_string
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 292, in 
> lambda: [lookup_callable()],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/renderers.py", line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/renderers.py", line 87, in
> render_to_string_uncached
> request=request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 422, in
> populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 756, in
> get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 107, in
> get_chunks
> large_data=True)
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 292, in 
> lambda: [lookup_callable()],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 106, in
> 
> lambda: list(self.get_chunks_uncached()),
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 762, in
> get_chunks_uncached
> self.encoding_list)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 198, in
> get_original_file
> request=request)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/scmtools/models.py", line 359, in get_file
> large_data=True)[0]
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 295, in cache_memoize
> compress_large_data))
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
> items = items_or_callable()
>   File "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.
> 7.egg/djblets/cache/backend.py", line 292, in 
> lambda: [lookup_callable()],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/scmtools/models.py", line 358, in 
> request)],
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/scmtools/models.py", line 534, in
> _get_file_uncached
> base_commit_id=base_commit_id)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 170, in get_file
> raw_content=True)
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/hostingsvcs/gitlab.py", line 505, in _api_get
> 'PRIVATE-TOKEN': self._get_private_token(),
>   File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.
> 2-py2.7.egg/reviewboard/hostingsvcs/service.py", line 55, in http_get
> return self.http_request(url, method='GET', **kwargs)
>   File "/usr/loca

Re: There was an error displaying this diff

[Christian Hammond]

Hi Igor,

I'm sorry I haven't been able to get to this yet. Been busy with some
customers with support contracts lately, and my backlog's been growing.

What I have noticed is that the reject file's showing a different encoding
than the source file, indicating that maybe the patch in question isn't
properly UTF-8 (or the code fetched from the repository isn't UTF-8).

Is there a way I could also get the patch in question? (Remember that these
are publicly indexed -- private support is something we offer, but only
with a support contract.)

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, Aug 15, 2016 at 11:52 PM, Igor Zilberman  wrote:

>
> Hi,
>
> Attached.
> Thanks.
>
> понедельник, 15 августа 2016 г., 22:45:18 UTC+3 пользователь Christian
> Hammond написал:
>>
>> Can you zip up those files and send them that way? Encodings can be
>> messed with when transmitting over e-mail.
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Mon, Aug 15, 2016 at 1:08 AM, Igor Zilberman 
>> wrote:
>>
>>> Hi Christian,
>>>
>>> Thank you for your reply!
>>>
>>> I am using 2.5.3 with RBTools 0.7.5.
>>> Repository type is ClearCase.
>>> Ive attached part of the xml file and the rej file.
>>>
>>> Regarding the last q I am not sure, but in the advanced settings of this
>>> repository, Encoding field is empty.
>>>
>>> Thanks.
>>>
>>> понедельник, 15 августа 2016 г., 2:54:03 UTC+3 пользователь Christian
>>> Hammond написал:

 Hi Igor,

 What version of Review Board are you using, and what type of repository?

 Would it be possible to get a sample of one of the files that is
 failing, along with the matching section from the reject file in that temp
 directory?

 Are the special characters indeed UTF-8 in the repository, or is the
 repository converting them to UTF-8 on checkout?

 Christian

 --
 Christian Hammond
 President/CEO of Beanbag 
 Makers of Review Board 

 On Sun, Aug 14, 2016 at 5:54 AM, Igor Zilberman 
 wrote:

> I am getting error trying to see the diff:
>
> The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply
> cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z'
> for debugging purposes.
> `patch` returned:
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>
>  Please try again, and if you still have trouble,
>  contact support.
>
> This file contains unicode characters.
>
> I had an issue to post this file:
> CRITICAL: 'ascii' codec can't decode byte 0xed in position 298:
> ordinal not in range(128)
>
> So after adding sitecustomize.py:
>
> # encoding=utf8
> import sys
>
> reload(sys)
> sys.setdefaultencoding('utf8')
>
>
> I was able to post but now I cant see the diff in reviewboard.
>
> Thanks.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google
> Groups "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to reviewboard...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>


>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: There was an error displaying this diff

[Christian Hammond]

Can you zip up those files and send them that way? Encodings can be messed
with when transmitting over e-mail.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, Aug 15, 2016 at 1:08 AM, Igor Zilberman  wrote:

> Hi Christian,
>
> Thank you for your reply!
>
> I am using 2.5.3 with RBTools 0.7.5.
> Repository type is ClearCase.
> Ive attached part of the xml file and the rej file.
>
> Regarding the last q I am not sure, but in the advanced settings of this
> repository, Encoding field is empty.
>
> Thanks.
>
> понедельник, 15 августа 2016 г., 2:54:03 UTC+3 пользователь Christian
> Hammond написал:
>>
>> Hi Igor,
>>
>> What version of Review Board are you using, and what type of repository?
>>
>> Would it be possible to get a sample of one of the files that is failing,
>> along with the matching section from the reject file in that temp directory?
>>
>> Are the special characters indeed UTF-8 in the repository, or is the
>> repository converting them to UTF-8 on checkout?
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Sun, Aug 14, 2016 at 5:54 AM, Igor Zilberman 
>> wrote:
>>
>>> I am getting error trying to see the diff:
>>>
>>> The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply
>>> cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z'
>>> for debugging purposes.
>>> `patch` returned:
>>>  This may be a bug in the software, a temporary outage, or an issue
>>>  with the format of your diff.
>>>
>>>  Please try again, and if you still have trouble,
>>>  contact support.
>>>
>>> This file contains unicode characters.
>>>
>>> I had an issue to post this file:
>>> CRITICAL: 'ascii' codec can't decode byte 0xed in position 298: ordinal
>>> not in range(128)
>>>
>>> So after adding sitecustomize.py:
>>>
>>> # encoding=utf8
>>> import sys
>>>
>>> reload(sys)
>>> sys.setdefaultencoding('utf8')
>>>
>>>
>>> I was able to post but now I cant see the diff in reviewboard.
>>>
>>> Thanks.
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: There was an error displaying this diff

[Igor Zilberman]

Hi Christian,

Thank you for your reply!

I am using 2.5.3 with RBTools 0.7.5.
Repository type is ClearCase.
Ive attached part of the xml file and the rej file.

Regarding the last q I am not sure, but in the advanced settings of this 
repository, Encoding field is empty.

Thanks.

понедельник, 15 августа 2016 г., 2:54:03 UTC+3 пользователь Christian 
Hammond написал:
>
> Hi Igor,
>
> What version of Review Board are you using, and what type of repository?
>
> Would it be possible to get a sample of one of the files that is failing, 
> along with the matching section from the reject file in that temp directory?
>
> Are the special characters indeed UTF-8 in the repository, or is the 
> repository converting them to UTF-8 on checkout?
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Sun, Aug 14, 2016 at 5:54 AM, Igor Zilberman  > wrote:
>
>> I am getting error trying to see the diff:
>>
>> The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply 
>> cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z' 
>> for debugging purposes.
>> `patch` returned: 
>>  This may be a bug in the software, a temporary outage, or an issue
>>  with the format of your diff.
>>
>>  Please try again, and if you still have trouble,
>>  contact support.
>>
>> This file contains unicode characters.
>>
>> I had an issue to post this file:
>> CRITICAL: 'ascii' codec can't decode byte 0xed in position 298: ordinal 
>> not in range(128)
>>
>> So after adding sitecustomize.py:
>>
>> # encoding=utf8  
>> import sys  
>>
>> reload(sys)  
>> sys.setdefaultencoding('utf8')
>>
>>
>> I was able to post but now I cant see the diff in reviewboard.
>>
>> Thanks.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


tmpex08zZ-new.rej
Description: Binary data


RetCodesQuotaDir.xml
Description: XML document

Re: There was an error displaying this diff

[Christian Hammond]

Hi Igor,

What version of Review Board are you using, and what type of repository?

Would it be possible to get a sample of one of the files that is failing,
along with the matching section from the reject file in that temp directory?

Are the special characters indeed UTF-8 in the repository, or is the
repository converting them to UTF-8 on checkout?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Sun, Aug 14, 2016 at 5:54 AM, Igor Zilberman  wrote:

> I am getting error trying to see the diff:
>
> The patch to 'pathtofile/somefile.xml@@/path/CHECKEDOUT' didn't apply
> cleanly. The temporary files have been left in '/tmp/reviewboard.BWp42z'
> for debugging purposes.
> `patch` returned:
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>
>  Please try again, and if you still have trouble,
>  contact support.
>
> This file contains unicode characters.
>
> I had an issue to post this file:
> CRITICAL: 'ascii' codec can't decode byte 0xed in position 298: ordinal
> not in range(128)
>
> So after adding sitecustomize.py:
>
> # encoding=utf8
> import sys
>
> reload(sys)
> sys.setdefaultencoding('utf8')
>
>
> I was able to post but now I cant see the diff in reviewboard.
>
> Thanks.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: There was an error displaying this diff.

[tiger . peng]

Hello All,

We run into similar issue. After spend some time, I identified the cause: 
the svnlook diff converted string "\t" to tab charter and cause patch 
command failure

Anyone have suggestion on how to solve the issue: (The svnlook is quite old 
and I cannot perform upgrade at this time.)

svnlook --version

 

svnlook, version 1.5.1 (r32289) 

   compiled Jul 31 2008, 09:45:17 


 

Copyright (C) 2000-2008 CollabNet.





The diff command used in pre-commit hook:
$SVNLOOK diff -x -u -t "$TXN" "$REPOS"

Thanks in advance,


Tiger




On Thursday, February 4, 2016 at 9:09:13 AM UTC-6, Waqar Ali Khan wrote:
>
> Hello everyone,
> I am using Reviewboard 2.5.2 on Ubuntu and on client side using latest 
> version of RBTools which is 0.7.5.
> When i am trying to post review for some files the diff is not showing 
> giving following error. My repository is CVS based. I have attached the 
> temporary files referenced in the error.
> My guess is that either CVS is not generating diff correctly or Review 
> Board cannot read some of the diff files.
>
>  There was an error displaying this diff.
> The patch to 
> 'stencils/jasperReports/quickReports/AP/form1099Report.jrxml' didn't apply 
> cleanly. The temporary files have been left in '/tmp/reviewboard.W0_4Ee' 
> for debugging purposes.
> `patch` returned: patch:  malformed patch at line 8499: 
>
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>  Please try again, and if you still have trouble,
>  contact support.
>
> Traceback (most recent call last):
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/views.py",
>  
> line 275, in get
> response = renderer.render_to_response(request)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 74, in render_to_string
> large_data=True)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 295, in cache_memoize
> compress_large_data))
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 292, in 
> lambda: [lookup_callable()],
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
>  
> line 87, in render_to_string_uncached
> request=request)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 422, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 107, in get_chunks
> large_data=True)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 295, in cache_memoize
> compress_large_data))
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>  
> line 292, in 
> lambda: [lookup_callable()],
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>  
> line 763, in get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File 
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>  
> line 232, in 

Re: There was an error displaying this diff.

[Christian Hammond]

Hi,

Your diff appears to have a bad mixture of line endings. Some lines use \n
(everything but the diff content), whereas the diff content uses \r\n. This
mixture is what's causing the parsing errors, as patch (and anything else)
will see extra newlines in the diff content.

This might be something you'd need to fix in the repository in this case,
but can you show me the full command you used to post the diff, along with
the --debug flag?

Was the source tree checked out on the Ubuntu system, or was it copied over
from another system?

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Thu, Feb 4, 2016 at 3:00 AM, Waqar Ali Khan 
wrote:

> Hello everyone,
> I am using Reviewboard 2.5.2 on Ubuntu and on client side using latest
> version of RBTools which is 0.7.5.
> When i am trying to post review for some files the diff is not showing
> giving following error. My repository is CVS based. I have attached the
> temporary files referenced in the error.
> My guess is that either CVS is not generating diff correctly or Review
> Board cannot read some of the diff files.
>
>  There was an error displaying this diff.
> The patch to
> 'stencils/jasperReports/quickReports/AP/form1099Report.jrxml' didn't apply
> cleanly. The temporary files have been left in '/tmp/reviewboard.W0_4Ee'
> for debugging purposes.
> `patch` returned: patch:  malformed patch at line 8499:
>
>  This may be a bug in the software, a temporary outage, or an issue
>  with the format of your diff.
>  Please try again, and if you still have trouble,
>  contact support.
>
> Traceback (most recent call last):
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/views.py",
> line 275, in get
> response = renderer.render_to_response(request)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 422, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 763, in get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File
> "/opt/reviewboard/venv/local/lib/python2.7/site-packages/ReviewBoard-2.5.2-py2.7.egg/reviewboard/diffviewer/di

Re: There was an error displaying this diff.

[Christian Hammond]

Try clearing memcached. There may be some stale state there.

Christian

-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Tue, Dec 1, 2015 at 1:41 AM, Jerzy Lasyk  wrote:

> Thank you for response.
> Unfortunately still doesn't work. Error is the same.
> I have put in Raw File URL mask: http://plmaaa02.
> *:8080/gitweb?p=SW_TestTool.git;a=blob;f=;h=
> When I put instead of filename and revision, data from diff file and open
> url, correct file from gitweb is visible.
> I have no idea what is still wrong.
>
> -Jerzy
>
> W dniu poniedziałek, 30 listopada 2015 23:55:41 UTC+1 użytkownik David
> Trowbridge napisał:
>>
>> The Raw File URL mask needs to be a template URL, not just the path to
>> the gitweb server.
>>
>> See
>> https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#gitweb
>>  for
>> examples.
>>
>> -David
>>
>> On Sun, Nov 29, 2015 at 11:16 PM Jerzy Lasyk  wrote:
>>
>>> The RAW file URL mask : http://plmaaa02
>>> :8080/p/SW_TestTool.git
>>> Path field is same: http://plmaaa02
>>> ***:8080/p/SW_TestTool.git
>>>
>>>
>>> W dniu niedziela, 29 listopada 2015 07:16:13 UTC+1 użytkownik David
>>> Trowbridge napisał:
>>>
 What is the raw file URL set to?

 -David

 On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk  wrote:

>>> I have a problem with error: "There was an error displaying this diff."
> I was searching for solution in this group, but didn't find helpful 
> answer.
> This error occurs for all generated diffs, created using command :
> "rbt post"
> I am using git repository. In reviewboard configuration I have put
> gitweb address in Path and Raw URL field. Whole error log is.
>
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
> line 275, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 422, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 763, in get_chunks_uncached
> new = get_patched_f

Re: There was an error displaying this diff.

[Jerzy Lasyk]

Thank you for response.
Unfortunately still doesn't work. Error is the same.
I have put in Raw File URL 
mask: 
http://plmaaa02.*:8080/gitweb?p=SW_TestTool.git;a=blob;f=;h=
When I put instead of filename and revision, data from diff file and open 
url, correct file from gitweb is visible. 
I have no idea what is still wrong.

-Jerzy

W dniu poniedziałek, 30 listopada 2015 23:55:41 UTC+1 użytkownik David 
Trowbridge napisał:
>
> The Raw File URL mask needs to be a template URL, not just the path to the 
> gitweb server.
>
> See 
> https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#gitweb
>  for 
> examples.
>
> -David
>
> On Sun, Nov 29, 2015 at 11:16 PM Jerzy Lasyk  > wrote:
>
>> The RAW file URL mask : http://plmaaa02
>> :8080/p/SW_TestTool.git
>> Path field is same: http://plmaaa02
>> ***:8080/p/SW_TestTool.git
>>
>>
>> W dniu niedziela, 29 listopada 2015 07:16:13 UTC+1 użytkownik David 
>> Trowbridge napisał:
>>
>>> What is the raw file URL set to?
>>>
>>> -David
>>>
>>> On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk  wrote:
>>>
>> I have a problem with error: "There was an error displaying this diff." I 
 was searching for solution in this group, but didn't find helpful answer.
 This error occurs for all generated diffs, created using command : 
 "rbt post"
 I am using git repository. In reviewboard configuration I have put 
 gitweb address in Path and Raw URL field. Whole error log is.

 Traceback (most recent call last):
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
  
 line 275, in get
 response = renderer.render_to_response(request)
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
  
 line 56, in render_to_response
 return HttpResponse(self.render_to_string(request))
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
  
 line 74, in render_to_string
 large_data=True)
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
  
 line 295, in cache_memoize
 compress_large_data))
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
  
 line 249, in cache_memoize_iter
 items = items_or_callable()
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
  
 line 292, in 
 lambda: [lookup_callable()],
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
  
 line 73, in 
 lambda: self.render_to_string_uncached(request),
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
  
 line 87, in render_to_string_uncached
 request=request)
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
  
 line 422, in populate_diff_chunks
 chunks = list(generator.get_chunks())
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
  
 line 756, in get_chunks
 for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
  
 line 107, in get_chunks
 large_data=True)
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
  
 line 295, in cache_memoize
 compress_large_data))
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
  
 line 249, in cache_memoize_iter
 items = items_or_callable()
   File 
 "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
  
 line 292, in 
 lambda: [lookup_callable()],
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
  
 line 106, in 
 lambda: list(self.get_chunks_uncached()),
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
  
 line 763, in get_chunks_uncached
 new = get_patched_file(old, self.filediff, self.request)
   File 
 "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
  
 line 232, in get_patched_file
 return patch(diff, buffer, filediff

Re: There was an error displaying this diff.

[David Trowbridge]

The Raw File URL mask needs to be a template URL, not just the path to the
gitweb server.

See
https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#gitweb
for
examples.

-David

On Sun, Nov 29, 2015 at 11:16 PM Jerzy Lasyk  wrote:

> The RAW file URL mask : http://plmaaa02
> :8080/p/SW_TestTool.git
> Path field is same: http://plmaaa02
> ***:8080/p/SW_TestTool.git
>
>
> W dniu niedziela, 29 listopada 2015 07:16:13 UTC+1 użytkownik David
> Trowbridge napisał:
>
>> What is the raw file URL set to?
>>
>> -David
>>
>> On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk  wrote:
>>
> I have a problem with error: "There was an error displaying this diff." I
>>> was searching for solution in this group, but didn't find helpful answer.
>>> This error occurs for all generated diffs, created using command : "rbt
>>> post"
>>> I am using git repository. In reviewboard configuration I have put
>>> gitweb address in Path and Raw URL field. Whole error log is.
>>>
>>> Traceback (most recent call last):
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
>>> line 275, in get
>>> response = renderer.render_to_response(request)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>> line 56, in render_to_response
>>> return HttpResponse(self.render_to_string(request))
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>> line 74, in render_to_string
>>> large_data=True)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 295, in cache_memoize
>>> compress_large_data))
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 249, in cache_memoize_iter
>>> items = items_or_callable()
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 292, in 
>>> lambda: [lookup_callable()],
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>> line 73, in 
>>> lambda: self.render_to_string_uncached(request),
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>> line 87, in render_to_string_uncached
>>> request=request)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>> line 422, in populate_diff_chunks
>>> chunks = list(generator.get_chunks())
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>> line 756, in get_chunks
>>> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>> line 107, in get_chunks
>>> large_data=True)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 295, in cache_memoize
>>> compress_large_data))
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 249, in cache_memoize_iter
>>> items = items_or_callable()
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>> line 292, in 
>>> lambda: [lookup_callable()],
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>> line 106, in 
>>> lambda: list(self.get_chunks_uncached()),
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>> line 763, in get_chunks_uncached
>>> new = get_patched_file(old, self.filediff, self.request)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>> line 232, in get_patched_file
>>> return patch(diff, buffer, filediff.dest_file, request)
>>>   File
>>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>> line 168, in patch
>>> 'output': stderr,
>>> Exception: The patch to
>>> 'AP_NavServerTest/AppBase/source/TestServerMain.cpp' didn't apply cleanly.
>>> The temporary files have been left in '/tmp/reviewboard.dQtcK8' for
>>> debugging purposes.
>>> `patch` returned:
>>>
>>>
>>> Erro occures for all .cpp, .gitignore, .h files.
>>> Please Help.
>>>
>>> Jerzy
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>

Re: There was an error displaying this diff.

[Jerzy Lasyk]

The RAW file URL mask 
: http://plmaaa02:8080/p/SW_TestTool.git
Path field is 
same: http://plmaaa02***:8080/p/SW_TestTool.git

W dniu niedziela, 29 listopada 2015 07:16:13 UTC+1 użytkownik David 
Trowbridge napisał:
>
> What is the raw file URL set to?
>
> -David
>
> On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk  > wrote:
>
>> I have a problem with error: "There was an error displaying this diff." I 
>> was searching for solution in this group, but didn't find helpful answer.
>> This error occurs for all generated diffs, created using command : "rbt 
>> post"
>> I am using git repository. In reviewboard configuration I have put gitweb 
>> address in Path and Raw URL field. Whole error log is.
>>
>> Traceback (most recent call last):
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
>>  
>> line 275, in get
>> response = renderer.render_to_response(request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 56, in render_to_response
>> return HttpResponse(self.render_to_string(request))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 74, in render_to_string
>> large_data=True)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 295, in cache_memoize
>> compress_large_data))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 249, in cache_memoize_iter
>> items = items_or_callable()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 292, in 
>> lambda: [lookup_callable()],
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 73, in 
>> lambda: self.render_to_string_uncached(request),
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
>>  
>> line 87, in render_to_string_uncached
>> request=request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 422, in populate_diff_chunks
>> chunks = list(generator.get_chunks())
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 756, in get_chunks
>> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 107, in get_chunks
>> large_data=True)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 295, in cache_memoize
>> compress_large_data))
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 249, in cache_memoize_iter
>> items = items_or_callable()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
>>  
>> line 292, in 
>> lambda: [lookup_callable()],
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 106, in 
>> lambda: list(self.get_chunks_uncached()),
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
>>  
>> line 763, in get_chunks_uncached
>> new = get_patched_file(old, self.filediff, self.request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 232, in get_patched_file
>> return patch(diff, buffer, filediff.dest_file, request)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
>>  
>> line 168, in patch
>> 'output': stderr,
>> Exception: The patch to 
>> 'AP_NavServerTest/AppBase/source/TestServerMain.cpp' didn't apply cleanly. 
>> The temporary files have been left in '/tmp/reviewboard.dQtcK8' for 
>> debugging purposes.
>> `patch` returned: 
>>
>>
>> Erro occures for all .cpp, .gitignore, .h files.
>> Please Help.
>>
>> Jerzy
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> 

Re: There was an error displaying this diff.

[David Trowbridge]

What is the raw file URL set to?

-David

On Fri, Nov 27, 2015 at 8:03 AM Jerzy Lasyk  wrote:

> I have a problem with error: "There was an error displaying this diff." I
> was searching for solution in this group, but didn't find helpful answer.
> This error occurs for all generated diffs, created using command : "rbt
> post"
> I am using git repository. In reviewboard configuration I have put gitweb
> address in Path and Raw URL field. Whole error log is.
>
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/views.py",
> line 275, in get
> response = renderer.render_to_response(request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 56, in render_to_response
> return HttpResponse(self.render_to_string(request))
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 74, in render_to_string
> large_data=True)
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 73, in 
> lambda: self.render_to_string_uncached(request),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/renderers.py",
> line 87, in render_to_string_uncached
> request=request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 422, in populate_diff_chunks
> chunks = list(generator.get_chunks())
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 756, in get_chunks
> for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 107, in get_chunks
> large_data=True)
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 295, in cache_memoize
> compress_large_data))
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 249, in cache_memoize_iter
> items = items_or_callable()
>   File
> "/usr/local/lib/python2.7/dist-packages/Djblets-0.9-py2.7.egg/djblets/cache/backend.py",
> line 292, in 
> lambda: [lookup_callable()],
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 106, in 
> lambda: list(self.get_chunks_uncached()),
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/chunk_generator.py",
> line 763, in get_chunks_uncached
> new = get_patched_file(old, self.filediff, self.request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 232, in get_patched_file
> return patch(diff, buffer, filediff.dest_file, request)
>   File
> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.5.1.1-py2.7.egg/reviewboard/diffviewer/diffutils.py",
> line 168, in patch
> 'output': stderr,
> Exception: The patch to
> 'AP_NavServerTest/AppBase/source/TestServerMain.cpp' didn't apply cleanly.
> The temporary files have been left in '/tmp/reviewboard.dQtcK8' for
> debugging purposes.
> `patch` returned:
>
>
> Erro occures for all .cpp, .gitignore, .h files.
> Please Help.
>
> Jerzy
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-David

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group a