Re: Three questions for using Review Board 1.0.6

2010-11-04 Thread J Arrizza
It looks like --parent works. Not sure what I did before, but when I reran a test based on a series of changes to a single test file, the diffs come out as expected. I didn't try file deletions/additions just changes within a single file: - Created a file with three lines line1 line2 line3

Re: Three questions for using Review Board 1.0.6

2010-11-02 Thread J Arrizza
1. interesting. I tried parent but it didn't seem to work the way I expected. It should compare the current revision with the parent revision, but didn't seem to do that. I suspect I probably did not set up the test correctly. In any case, I'll give it another try. On Sat, Oct 30, 2010 at 11:01

Re: Three questions for using Review Board 1.0.6

2010-10-28 Thread J Arrizza
Andrew, I am still new to RB, and we are looking for something similar as well. We have an SCR in our defect tracking system that aggregates all work for change. Developers create a series of changesets and then tag each of those with the SCR. When it's time to do a code review, we'd like to have

Re: Three questions for using Review Board 1.0.6

2010-10-28 Thread Andrew Schwartz
On Thu, Oct 28, 2010 at 12:28 PM, J Arrizza cppge...@gmail.com wrote: Andrew, I am still new to RB, and we are looking for something similar as well. We have an SCR in our defect tracking system that aggregates all work for change. Developers create a series of changesets and then tag each

Re: Three questions for using Review Board 1.0.6

2010-10-28 Thread J Arrizza
On Thu, Oct 28, 2010 at 12:46 PM, Andrew Schwartz aschwa...@gmail.comwrote: - have a rollup mechanism. As the additional revisions are added, the changes are rolled up into one aggregate diff. (I assume this would be very complicated code and so might not be doable without significant risk)

Re: Three questions for using Review Board 1.0.6

2010-07-29 Thread Andrew Schwartz
N On Tue, Jul 27, 2010 at 4:05 PM, Eduardo Felipe eduardofelip...@gmail.comwrote: Sure! I am working on making the support for DVCS better by implementing the following: Remote branch tracking: Based on the notion of feature branches one could build around the notion of long lived

Re: Three questions for using Review Board 1.0.6

2010-07-29 Thread Eduardo Felipe
Andrew, I'm afraid that won't be possible with the code I'm writing. I'm basing this on a post-commit style of review. In this scenario, you would write a new commit E that fixes the issues mentioned on the review, instead of rewriting the patches. The model you are suggesting is harder to do on

Re: Three questions for using Review Board 1.0.6

2010-07-27 Thread Andrew
Hi all. Please let me know what's going on with DVCS and Review Board. I know that there are ways to make it work (as we are in my organization), but it would be nice for it to be better integrated in the project with reviewing multiple changesets, etc. Thanks. On Jul 20, 5:40 pm, Andrew

Re: Three questions for using Review Board 1.0.6

2010-07-27 Thread Christian Hammond
Eduardo, can you give a summary of what you're working on? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Jul 27, 2010 at 12:33 PM, Andrew aschwa...@gmail.com wrote: Hi all. Please let me know

Re: Three questions for using Review Board 1.0.6

2010-06-02 Thread Christian Hammond
Hi James, Today, each logical change is meant to have its own review request. If you have three things that are related but are separately worked on, each should be put up for review separately. There's no notion of a review request that encompasses several different changes. I personally think