Re: Unable to create New Review Request for RBTools

2009-11-16 Thread Chris Clark
Chris Clark wrote: > Comments? Presumably this would be a 1.1+ feature. I could think I would > be able to implement the 1st fairly idea. > Yikes too much coffee for me! Lets try that again. If this is seen as being useful, I could probably knock up some code to handle displaying opt

Re: Unable to create New Review Request for RBTools

2009-11-16 Thread Chris Clark
Christian Hammond wrote: > You should use post-review to submit code changes for Review Board and > RBTools. > > If you do need to do it by hand for some reason, you must pass > --full-index to git diff. I've a seen a few others not know the magic git incantation to generate diffs (if not usin

Re: Unable to create New Review Request for RBTools

2009-11-15 Thread Ryan Oblak
Thanks for the info :) I've submitted my patch for review. Ryan On Nov 15, 4:41 pm, Christian Hammond wrote: > You should use post-review to submit code changes for Review Board and > RBTools. > > If you do need to do it by hand for some reason, you must pass --full-index > to git diff. > > C

Re: Unable to create New Review Request for RBTools

2009-11-15 Thread Christian Hammond
You should use post-review to submit code changes for Review Board and RBTools. If you do need to do it by hand for some reason, you must pass --full-index to git diff. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmwar