You should use post-review to submit code changes for Review Board and
RBTools.

If you do need to do it by hand for some reason, you must pass --full-index
to git diff.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Sun, Nov 15, 2009 at 3:56 PM, Ryan Oblak <rrob...@gmail.com> wrote:

>
> Hi all,
>
> I'm having trouble posting a review request for RBTools.  I forked and
> checked out RBTools from github, made my changes, and generated a
> diff.  The command I used to generate the diff is "git diff >
> postreview.patch".  I'm not getting any error message-- the page just
> reloads when I click "Create Review Request".  I have tried uploading
> my diff with both Linux Chrome and Linux Firefox.
>
> My changes add support for HTTP Digest Authentication to post-review.
> I have tested my version of the script on my Review Board 1.1 alpha 1
> installation with digest authentication, basic authentication, and no
> authentication, and it works on all 3.
>
> Thanks for any help.
>
> > To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com>
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
> -~----------~----~----~----~------~----~------~--~---
>
>

--~--~---------~--~----~------------~-------~--~----~
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to