Re: Unable to create New Review Request for RBTools
Chris Clark wrote: > Comments? Presumably this would be a 1.1+ feature. I could think I would > be able to implement the 1st fairly idea. > Yikes too much coffee for me! Lets try that again. If this is seen as being useful, I could probably knock up some code to handle displaying optional "here is how to generate diffs" text when creating new reviews via the web browser interface. Chris --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Unable to create New Review Request for RBTools
Christian Hammond wrote: > You should use post-review to submit code changes for Review Board and > RBTools. > > If you do need to do it by hand for some reason, you must pass > --full-index to git diff. I've a seen a few others not know the magic git incantation to generate diffs (if not using postreview), and until I saw it posted I didn't know it either. One idea for dealing with that would be to add a new (optional) attribute to repositories; a plain text diff description field. This could be implemented in the SCMTool __init__ method that could document the expected scm command line to generate diffs. When the web pase new review is used this field could be displayed (if it is not None). It _may_ also be worth having a user editable description field for when the admin adds the repository to the ReviewBoard server. Comments? Presumably this would be a 1.1+ feature. I could think I would be able to implement the 1st fairly idea. Chris --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Unable to create New Review Request for RBTools
Thanks for the info :) I've submitted my patch for review. Ryan On Nov 15, 4:41 pm, Christian Hammond wrote: > You should use post-review to submit code changes for Review Board and > RBTools. > > If you do need to do it by hand for some reason, you must pass --full-index > to git diff. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > > > On Sun, Nov 15, 2009 at 3:56 PM, Ryan Oblak wrote: > > > Hi all, > > > I'm having trouble posting a review request for RBTools. I forked and > > checked out RBTools from github, made my changes, and generated a > > diff. The command I used to generate the diff is "git diff > > > postreview.patch". I'm not getting any error message-- the page just > > reloads when I click "Create Review Request". I have tried uploading > > my diff with both Linux Chrome and Linux Firefox. > > > My changes add support for HTTP Digest Authentication to post-review. > > I have tested my version of the script on my Review Board 1.1 alpha 1 > > installation with digest authentication, basic authentication, and no > > authentication, and it works on all 3. > > > Thanks for any help. > > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > oups.com> > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Unable to create New Review Request for RBTools
You should use post-review to submit code changes for Review Board and RBTools. If you do need to do it by hand for some reason, you must pass --full-index to git diff. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Nov 15, 2009 at 3:56 PM, Ryan Oblak wrote: > > Hi all, > > I'm having trouble posting a review request for RBTools. I forked and > checked out RBTools from github, made my changes, and generated a > diff. The command I used to generate the diff is "git diff > > postreview.patch". I'm not getting any error message-- the page just > reloads when I click "Create Review Request". I have tried uploading > my diff with both Linux Chrome and Linux Firefox. > > My changes add support for HTTP Digest Authentication to post-review. > I have tested my version of the script on my Review Board 1.1 alpha 1 > installation with digest authentication, basic authentication, and no > authentication, and it works on all 3. > > Thanks for any help. > > > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -~--~~~~--~~--~--~--- > > --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
