Re: Upgrade issues upgrading from 3.0.20 to 3.0.22

2021-05-06 Thread Christian Hammond
I'm glad to hear it! Thanks for letting me know :) Sorry for the trouble
before.

Christian

On Thu, May 6, 2021 at 10:42 AM tw bert  wrote:

> Hi Christian, thank you, that worked flawlessly.
> We considered pip installing bleach, but like to keep stuff vanilla where
> possible.
> Fixed.
> For completeness, I've attached the output logs of pip install -U
> ReviewBoard==3.0.23 and the rb-site upgrade.
>
>
> On Thursday, 6 May 2021 at 03:16:10 UTC+2 Christian Hammond wrote:
>
>> Just put out the 3.0.23 release, so you should be able to upgrade and be
>> good. Sorry about that. There was a lingering but unnecessary usage of a
>> dependency that we had removed in 3.0.22.
>>
>> Christian
>>
>> On Wed, May 5, 2021 at 5:58 PM Christian Hammond 
>> wrote:
>>
>>> Hi,
>>>
>>> Looks like something went wrong with the release. You can get around
>>> this temporarily by doing:
>>>
>>> pip install bleach_allowlist
>>>
>>> We'll put out a fixed build tonight.
>>>
>>> Christian
>>>
>>>
>>> On Wed, May 5, 2021 at 8:42 AM tw bert  wrote:
>>>
 RB breaks when upgrading, we reverted to backup.

 Any clue? Previous upgrades always went fine.

 pip install -U ReviewBoard==3.0.22

 (ok)

 root@srv-flux-dev-01:/# rb-site upgrade /var/www/reviews.XXX.XXX.com
 WARNING:py.warnings:/usr/local/lib/python2.7/dist-packages/paramiko/transport.py:33:
 CryptographyDeprecationWarning: Python 2 is no longer supported by the
 Python core team. Support for it is now deprecated in cryptography, and
 will be removed in the next release.
   from cryptography.hazmat.backends import default_backend

 Rebuilding directory structure
 Updating database. This may take a while.

 The log output below, including warnings and errors,
 can be ignored unless upgrade fails.

 --  --

 [!] Unable to execute the manager command syncdb: cannot import name
 signals

 [!] Unable to execute the manager command registerscmtools: cannot
 import name signals

 [!] Unable to execute the manager command evolve: cannot import name
 signals
 ---  ---

 Resetting in-database caches.

 [!] Unable to execute the manager command fixreviewcounts: No module
 named bleach_allowlist

 Upgrade complete!

 There are duplicate copies of diffs in your database that can be
 condensed.
 These are the result of posting several iterations of a change for
 review on
 older versions of Review Board.

 Removing duplicate diff data will save space in your database and speed
 up
 future upgrades.

 To condense duplicate diffs, type the following:

 $ rb-site manage /var/www/reviews.XXX.XXX.com condensediffs


 root@srv-flux-dev-01:/# tail -n30 /var/log/apache2/error.log
 [Wed May 05 08:20:37.853326 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client 192.168.4.87:53160]
  self.load_middleware(), referer:
 http://srv-reviewboard:8089/dashboard/
 [Wed May 05 08:20:37.853350 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client 192.168.4.87:53160]   File
 "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line
 45, in load_middleware, referer: http://srv-reviewboard:8089/dashboard/
 [Wed May 05 08:20:37.853385 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client 192.168.4.87:53160] mw_class =
 import_by_path(middleware_path), referer:
 http://srv-reviewboard:8089/dashboard/
 [Wed May 05 08:20:37.853406 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client 192.168.4.87:53160]   File
 "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py",
 line 26, in import_by_path, referer:
 http://srv-reviewboard:8089/dashboard/
 [Wed May 05 08:20:37.853438 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client 192.168.4.87:53160] sys.exc_info()[2]),
 referer: http://srv-reviewboard:8089/dashboard/
 [Wed May 05 08:20:37.853458 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client 192.168.4.87:53160]   File
 "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py",
 line 21, in import_by_path, referer:
 http://srv-reviewboard:8089/dashboard/
 [Wed May 05 08:20:37.853504 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client 192.168.4.87:53160] module =
 import_module(module_path), referer:
 http://srv-reviewboard:8089/dashboard/
 [Wed May 05 08:20:37.853525 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client 192.168.4.87:53160]   File
 "/usr/local/lib/python2.7/dist-packages/django/utils/importlib.py", line
 40, in import_module, referer: http://srv-reviewboard:8089/dashboard/
 [Wed May 05 08:20:37.853556 2021] [wsgi:error] [pid 5063:tid
 139949663827712] [client

Re: Upgrade issues upgrading from 3.0.20 to 3.0.22

2021-05-06 Thread tw bert
Hi Christian, thank you, that worked flawlessly.
We considered pip installing bleach, but like to keep stuff vanilla where 
possible.
Fixed.
For completeness, I've attached the output logs of pip install -U 
ReviewBoard==3.0.23 and the rb-site upgrade.


On Thursday, 6 May 2021 at 03:16:10 UTC+2 Christian Hammond wrote:

> Just put out the 3.0.23 release, so you should be able to upgrade and be 
> good. Sorry about that. There was a lingering but unnecessary usage of a 
> dependency that we had removed in 3.0.22.
>
> Christian
>
> On Wed, May 5, 2021 at 5:58 PM Christian Hammond  
> wrote:
>
>> Hi,
>>
>> Looks like something went wrong with the release. You can get around this 
>> temporarily by doing:
>>
>> pip install bleach_allowlist
>>
>> We'll put out a fixed build tonight.
>>
>> Christian
>>
>>
>> On Wed, May 5, 2021 at 8:42 AM tw bert  wrote:
>>
>>> RB breaks when upgrading, we reverted to backup.
>>>
>>> Any clue? Previous upgrades always went fine.
>>>
>>> pip install -U ReviewBoard==3.0.22
>>>
>>> (ok)
>>>
>>> root@srv-flux-dev-01:/# rb-site upgrade /var/www/reviews.XXX.XXX.com
>>> WARNING:py.warnings:/usr/local/lib/python2.7/dist-packages/paramiko/transport.py:33:
>>>  
>>> CryptographyDeprecationWarning: Python 2 is no longer supported by the 
>>> Python core team. Support for it is now deprecated in cryptography, and 
>>> will be removed in the next release.
>>>   from cryptography.hazmat.backends import default_backend
>>>
>>> Rebuilding directory structure
>>> Updating database. This may take a while.
>>>
>>> The log output below, including warnings and errors,
>>> can be ignored unless upgrade fails.
>>>
>>> --  --
>>>
>>> [!] Unable to execute the manager command syncdb: cannot import name
>>> signals
>>>
>>> [!] Unable to execute the manager command registerscmtools: cannot
>>> import name signals
>>>
>>> [!] Unable to execute the manager command evolve: cannot import name
>>> signals
>>> ---  ---
>>>
>>> Resetting in-database caches.
>>>
>>> [!] Unable to execute the manager command fixreviewcounts: No module
>>> named bleach_allowlist
>>>
>>> Upgrade complete!
>>>
>>> There are duplicate copies of diffs in your database that can be 
>>> condensed.
>>> These are the result of posting several iterations of a change for 
>>> review on
>>> older versions of Review Board.
>>>
>>> Removing duplicate diff data will save space in your database and speed 
>>> up
>>> future upgrades.
>>>
>>> To condense duplicate diffs, type the following:
>>>
>>> $ rb-site manage /var/www/reviews.XXX.XXX.com condensediffs
>>>
>>>
>>> root@srv-flux-dev-01:/# tail -n30 /var/log/apache2/error.log
>>> [Wed May 05 08:20:37.853326 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160]
>>>  self.load_middleware(), referer: http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853350 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160]   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 
>>> 45, in load_middleware, referer: http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853385 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160] mw_class = 
>>> import_by_path(middleware_path), referer: 
>>> http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853406 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160]   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py", 
>>> line 26, in import_by_path, referer: 
>>> http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853438 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160] sys.exc_info()[2]), 
>>> referer: http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853458 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160]   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py", 
>>> line 21, in import_by_path, referer: 
>>> http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853504 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160] module = 
>>> import_module(module_path), referer: 
>>> http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853525 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160]   File 
>>> "/usr/local/lib/python2.7/dist-packages/django/utils/importlib.py", line 
>>> 40, in import_module, referer: http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853556 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160] __import__(name), 
>>> referer: http://srv-reviewboard:8089/dashboard/
>>> [Wed May 05 08:20:37.853575 2021] [wsgi:error] [pid 5063:tid 
>>> 139949663827712] [client 192.168.4.87:53160]   File 
>>> "/usr/loc

Re: Upgrade issues upgrading from 3.0.20 to 3.0.22

2021-05-05 Thread Christian Hammond
Just put out the 3.0.23 release, so you should be able to upgrade and be
good. Sorry about that. There was a lingering but unnecessary usage of a
dependency that we had removed in 3.0.22.

Christian

On Wed, May 5, 2021 at 5:58 PM Christian Hammond 
wrote:

> Hi,
>
> Looks like something went wrong with the release. You can get around this
> temporarily by doing:
>
> pip install bleach_allowlist
>
> We'll put out a fixed build tonight.
>
> Christian
>
>
> On Wed, May 5, 2021 at 8:42 AM tw bert  wrote:
>
>> RB breaks when upgrading, we reverted to backup.
>>
>> Any clue? Previous upgrades always went fine.
>>
>> pip install -U ReviewBoard==3.0.22
>>
>> (ok)
>>
>> root@srv-flux-dev-01:/# rb-site upgrade /var/www/reviews.XXX.XXX.com
>> WARNING:py.warnings:/usr/local/lib/python2.7/dist-packages/paramiko/transport.py:33:
>> CryptographyDeprecationWarning: Python 2 is no longer supported by the
>> Python core team. Support for it is now deprecated in cryptography, and
>> will be removed in the next release.
>>   from cryptography.hazmat.backends import default_backend
>>
>> Rebuilding directory structure
>> Updating database. This may take a while.
>>
>> The log output below, including warnings and errors,
>> can be ignored unless upgrade fails.
>>
>> --  --
>>
>> [!] Unable to execute the manager command syncdb: cannot import name
>> signals
>>
>> [!] Unable to execute the manager command registerscmtools: cannot
>> import name signals
>>
>> [!] Unable to execute the manager command evolve: cannot import name
>> signals
>> ---  ---
>>
>> Resetting in-database caches.
>>
>> [!] Unable to execute the manager command fixreviewcounts: No module
>> named bleach_allowlist
>>
>> Upgrade complete!
>>
>> There are duplicate copies of diffs in your database that can be
>> condensed.
>> These are the result of posting several iterations of a change for review
>> on
>> older versions of Review Board.
>>
>> Removing duplicate diff data will save space in your database and speed up
>> future upgrades.
>>
>> To condense duplicate diffs, type the following:
>>
>> $ rb-site manage /var/www/reviews.XXX.XXX.com condensediffs
>>
>>
>> root@srv-flux-dev-01:/# tail -n30 /var/log/apache2/error.log
>> [Wed May 05 08:20:37.853326 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160] self.load_middleware(),
>> referer: http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853350 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160]   File
>> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line
>> 45, in load_middleware, referer: http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853385 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160] mw_class =
>> import_by_path(middleware_path), referer:
>> http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853406 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160]   File
>> "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py",
>> line 26, in import_by_path, referer:
>> http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853438 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160] sys.exc_info()[2]),
>> referer: http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853458 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160]   File
>> "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py",
>> line 21, in import_by_path, referer:
>> http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853504 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160] module =
>> import_module(module_path), referer:
>> http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853525 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160]   File
>> "/usr/local/lib/python2.7/dist-packages/django/utils/importlib.py", line
>> 40, in import_module, referer: http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853556 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160] __import__(name),
>> referer: http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853575 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160]   File
>> "/usr/local/lib/python2.7/dist-packages/reviewboard/admin/middleware.py",
>> line 9, in , referer: http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853621 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160] from
>> reviewboard.accounts.backends.registry import get_enabled_auth_backends,
>> referer: http://srv-reviewboard:8089/dashboard/
>> [Wed May 05 08:20:37.853653 2021] [wsgi:error] [pid 5063:tid
>> 139949663827712] [client 192.168.4.87:53160]   F

Re: Upgrade issues upgrading from 3.0.20 to 3.0.22

2021-05-05 Thread Christian Hammond
Hi,

Looks like something went wrong with the release. You can get around this
temporarily by doing:

pip install bleach_allowlist

We'll put out a fixed build tonight.

Christian


On Wed, May 5, 2021 at 8:42 AM tw bert  wrote:

> RB breaks when upgrading, we reverted to backup.
>
> Any clue? Previous upgrades always went fine.
>
> pip install -U ReviewBoard==3.0.22
>
> (ok)
>
> root@srv-flux-dev-01:/# rb-site upgrade /var/www/reviews.XXX.XXX.com
> WARNING:py.warnings:/usr/local/lib/python2.7/dist-packages/paramiko/transport.py:33:
> CryptographyDeprecationWarning: Python 2 is no longer supported by the
> Python core team. Support for it is now deprecated in cryptography, and
> will be removed in the next release.
>   from cryptography.hazmat.backends import default_backend
>
> Rebuilding directory structure
> Updating database. This may take a while.
>
> The log output below, including warnings and errors,
> can be ignored unless upgrade fails.
>
> --  --
>
> [!] Unable to execute the manager command syncdb: cannot import name
> signals
>
> [!] Unable to execute the manager command registerscmtools: cannot
> import name signals
>
> [!] Unable to execute the manager command evolve: cannot import name
> signals
> ---  ---
>
> Resetting in-database caches.
>
> [!] Unable to execute the manager command fixreviewcounts: No module
> named bleach_allowlist
>
> Upgrade complete!
>
> There are duplicate copies of diffs in your database that can be condensed.
> These are the result of posting several iterations of a change for review
> on
> older versions of Review Board.
>
> Removing duplicate diff data will save space in your database and speed up
> future upgrades.
>
> To condense duplicate diffs, type the following:
>
> $ rb-site manage /var/www/reviews.XXX.XXX.com condensediffs
>
>
> root@srv-flux-dev-01:/# tail -n30 /var/log/apache2/error.log
> [Wed May 05 08:20:37.853326 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160] self.load_middleware(),
> referer: http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853350 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160]   File
> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line
> 45, in load_middleware, referer: http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853385 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160] mw_class =
> import_by_path(middleware_path), referer:
> http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853406 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160]   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py",
> line 26, in import_by_path, referer:
> http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853438 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160] sys.exc_info()[2]),
> referer: http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853458 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160]   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py",
> line 21, in import_by_path, referer:
> http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853504 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160] module =
> import_module(module_path), referer:
> http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853525 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160]   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/importlib.py", line
> 40, in import_module, referer: http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853556 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160] __import__(name),
> referer: http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853575 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160]   File
> "/usr/local/lib/python2.7/dist-packages/reviewboard/admin/middleware.py",
> line 9, in , referer: http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853621 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160] from
> reviewboard.accounts.backends.registry import get_enabled_auth_backends,
> referer: http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853653 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160]   File
> "/usr/local/lib/python2.7/dist-packages/reviewboard/accounts/backends/__init__.py",
> line 34, in , referer: http://srv-reviewboard:8089/dashboard/
> [Wed May 05 08:20:37.853686 2021] [wsgi:error] [pid 5063:tid
> 139949663827712] [client 192.168.4.87:53160] from
> reviewboard.accounts.backends.registry import (AuthBackendRegistry,,
> referer: http://srv-reviewboard:808

Re: Upgrade issues from 1.5.7 to 1.6.5

2012-04-23 Thread Christian Hammond
On Mon, Apr 23, 2012 at 12:25 PM, Stephen Gallagher <
step...@gallagherhome.com> wrote:

> On Mon, 2012-04-23 at 12:01 -0700, Christian Hammond wrote:
> > Maybe I'm getting mixed up between 1.6.x and 1.7. It could be that we
> > only added "site" in 1.6.
> >
> > We can get that change into 1.6.x. I was hesitant to make too many
> > more changes to 1.6.x, but we'll be doing a larger 1.6.x release
> > hopefully this week, so I'll try to remember to slip that one in.
> >
>
> Thanks for your help and quick replies. We're back up and running again
> on Fedora Hosted. It's appreciated :)
>
>
Awesome, glad to hear it :)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Upgrade issues from 1.5.7 to 1.6.5

2012-04-23 Thread Stephen Gallagher
On Mon, 2012-04-23 at 12:01 -0700, Christian Hammond wrote:
> Maybe I'm getting mixed up between 1.6.x and 1.7. It could be that we
> only added "site" in 1.6.
> 
> We can get that change into 1.6.x. I was hesitant to make too many
> more changes to 1.6.x, but we'll be doing a larger 1.6.x release
> hopefully this week, so I'll try to remember to slip that one in.
> 

Thanks for your help and quick replies. We're back up and running again
on Fedora Hosted. It's appreciated :)

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Upgrade issues from 1.5.7 to 1.6.5

2012-04-23 Thread Christian Hammond
Maybe I'm getting mixed up between 1.6.x and 1.7. It could be that we only
added "site" in 1.6.

We can get that change into 1.6.x. I was hesitant to make too many more
changes to 1.6.x, but we'll be doing a larger 1.6.x release hopefully this
week, so I'll try to remember to slip that one in.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Apr 23, 2012 at 11:46 AM, Stephen Gallagher <
step...@gallagherhome.com> wrote:

> On Mon, 2012-04-23 at 11:41 -0700, Christian Hammond wrote:
> > It's your settings_local. Overriding that entirely is a recipe for
> > disaster, as we add to that. If things are missing (the site app among
> > a few in this case), things will blow up.
> >
>
> Eep, that's weird. I could have sworn I added the site app, but I
> somehow missed it. Guess that explains that. Thanks!
>
> You say "among a few". Were there others that I missed that you see?
>
> > You probably should just dynamically take what's in there, convert to a
> > list, and insert your models at one index before the last.
>
> As noted, I submitted http://reviews.reviewboard.org/r/2630/ half a year
> ago, but it only made it to master (not 1.6.x). That would obviously be
> my preferred approach to this :)
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Upgrade issues from 1.5.7 to 1.6.5

2012-04-23 Thread Stephen Gallagher
On Mon, 2012-04-23 at 11:41 -0700, Christian Hammond wrote:
> It's your settings_local. Overriding that entirely is a recipe for
> disaster, as we add to that. If things are missing (the site app among
> a few in this case), things will blow up.
> 

Eep, that's weird. I could have sworn I added the site app, but I
somehow missed it. Guess that explains that. Thanks!

You say "among a few". Were there others that I missed that you see?

> You probably should just dynamically take what's in there, convert to a
> list, and insert your models at one index before the last.

As noted, I submitted http://reviews.reviewboard.org/r/2630/ half a year
ago, but it only made it to master (not 1.6.x). That would obviously be
my preferred approach to this :)

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Upgrade issues from 1.5.7 to 1.6.5

2012-04-23 Thread Christian Hammond
It's your settings_local. Overriding that entirely is a recipe for disaster, as 
we add to that. If things are missing (the site app among a few in this case), 
things will blow up.

You probably should just dynamically take what's in there, convert to a list, 
and insert your models at one index before the last.

Christian



On Apr 23, 2012, at 11:36, Stephen Gallagher  wrote:

> On Mon, 2012-04-23 at 11:25 -0700, Christian Hammond wrote:
>> Hi Stephen,
>> 
>> Hmm, that's concerning. My upgrade simulations aren't reproducing that.
>> 
>> The same issue should be hit for any 1.6 release. 
>> 
>> Is this for the packages or FedoraHosted?
> 
> This is happening from the RPMs I created for EPEL 6. They are identical
> to the 1.6.5 sources except for three custom patches (attached). They
> are minimally-invasive.
> 
> I also have a slightly unorthodox settings_local.py file (also attached,
> portions redacted). This is because my patch for including other
> apps/middleware is only in the 1.7 branch.
> 
>> It almost sounds like the syncdb didn't set up the site app. We're
>> there any warnings? Do you see those in the database?
> 
> I'm not sure where to look for warnings and or what I need from the
> database. Please clarify.
> 
> 
> Slightly more complete output (this was with django_evolution 0.6.5):
> 
> [sgallagh@hosted03 conf]$ sudo rb-site upgrade /srv/reviewboard
> Rebuilding directory structure
> /usr/lib/python2.6/site-packages/django/db/__init__.py:60:
> DeprecationWarning: Short names for ENGINE in database configurations
> are deprecated. Prepend default.ENGINE with 'django.db.backends.'
>  DeprecationWarning
> Upgrading from version 1.5.7
> Updating database. This may take a while.
> Creating tables ...
> Creating table accounts_localsiteprofile
> Creating table attachments_fileattachment
> Creating table reviews_fileattachmentcomment
> Upgrading Review Board from 1.5.7 to 1.6.5
> There are unapplied evolutions for sessions.
> There are unapplied evolutions for accounts.
> There are unapplied evolutions for reviews.
> There are unapplied evolutions for scmtools.
> Loading FAS groups...
> FAS groups loaded. Don't forget to set FAS_USERNAME and FAS_PASSWORD to
> a low-privilege account.
> Adding baseline version for new models
> Project signature has changed - an evolution is required
> Installing custom SQL ...
> Installing indexes ...
> No fixtures found.
> Registering new SCM Tool Plastic SCM
> (reviewboard.scmtools.plastic.PlasticTool) in database
> Traceback (most recent call last):
>  File "/usr/bin/rb-site", line 9, in 
>load_entry_point('ReviewBoard==1.6.5', 'console_scripts',
> 'rb-site')()
>  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
> line 1760, in main
>command.run()
>  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
> line 1650, in run
>site.migrate_database()
>  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
> line 353, in migrate_database
>self.run_manage_command("evolve", ["--noinput", "--execute"])
>  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
> line 469, in run_manage_command
>execute_manager(reviewboard.settings, [__file__, cmd] + params)
>  File
> "/usr/lib/python2.6/site-packages/django/core/management/__init__.py",
> line 438, in execute_manager
>utility.execute()
>  File
> "/usr/lib/python2.6/site-packages/django/core/management/__init__.py",
> line 379, in execute
>self.fetch_command(subcommand).run_from_argv(self.argv)
>  File
> "/usr/lib/python2.6/site-packages/django/core/management/base.py", line
> 191, in run_from_argv
>self.execute(*args, **options.__dict__)
>  File
> "/usr/lib/python2.6/site-packages/django/core/management/base.py", line
> 220, in execute
>output = self.handle(*args, **options)
>  File
> "/usr/lib/python2.6/site-packages/django_evolution/management/commands/evolve.py",
>  line 60, in handle
>self.evolve(*app_labels, **options)
>  File
> "/usr/lib/python2.6/site-packages/django_evolution/management/commands/evolve.py",
>  line 140, in evolve
>database))
>  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
> line 418, in mutate
>return self.add_column(app_label, proj_sig, database)
>  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
> line 426, in add_column
>self.field_attrs, model)
>  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
> line 33, in create_field
>related_model_sig = proj_sig[related_app_name][related_model_name]
> KeyError: 'site'
> 
> And again after updating to django_evolution 0.6.7 (to be sure):
> 
> [sgallagh@hosted03 conf]$ sudo rb-site upgrade /srv/reviewboard
> Rebuilding directory structure
> /usr/lib/python2.6/site-packages/django/db/__init__.py:60:
> DeprecationWarning: Short names for ENGINE in database configurations
> are deprecated. Prepend default.ENGINE with 'django.db.backends.'
>  DeprecationWarnin

Re: Upgrade issues from 1.5.7 to 1.6.5

2012-04-23 Thread Stephen Gallagher
On Mon, 2012-04-23 at 11:25 -0700, Christian Hammond wrote:
> Hi Stephen,
> 
> Hmm, that's concerning. My upgrade simulations aren't reproducing that.
> 
> The same issue should be hit for any 1.6 release. 
> 
> Is this for the packages or FedoraHosted?

This is happening from the RPMs I created for EPEL 6. They are identical
to the 1.6.5 sources except for three custom patches (attached). They
are minimally-invasive.

I also have a slightly unorthodox settings_local.py file (also attached,
portions redacted). This is because my patch for including other
apps/middleware is only in the 1.7 branch.

> It almost sounds like the syncdb didn't set up the site app. We're
> there any warnings? Do you see those in the database?

I'm not sure where to look for warnings and or what I need from the
database. Please clarify.


Slightly more complete output (this was with django_evolution 0.6.5):

[sgallagh@hosted03 conf]$ sudo rb-site upgrade /srv/reviewboard
Rebuilding directory structure
/usr/lib/python2.6/site-packages/django/db/__init__.py:60:
DeprecationWarning: Short names for ENGINE in database configurations
are deprecated. Prepend default.ENGINE with 'django.db.backends.'
  DeprecationWarning
Upgrading from version 1.5.7
Updating database. This may take a while.
Creating tables ...
Creating table accounts_localsiteprofile
Creating table attachments_fileattachment
Creating table reviews_fileattachmentcomment
Upgrading Review Board from 1.5.7 to 1.6.5
There are unapplied evolutions for sessions.
There are unapplied evolutions for accounts.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Loading FAS groups...
FAS groups loaded. Don't forget to set FAS_USERNAME and FAS_PASSWORD to
a low-privilege account.
Adding baseline version for new models
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
No fixtures found.
Registering new SCM Tool Plastic SCM
(reviewboard.scmtools.plastic.PlasticTool) in database
Traceback (most recent call last):
  File "/usr/bin/rb-site", line 9, in 
load_entry_point('ReviewBoard==1.6.5', 'console_scripts',
'rb-site')()
  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
line 1760, in main
command.run()
  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
line 1650, in run
site.migrate_database()
  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
line 353, in migrate_database
self.run_manage_command("evolve", ["--noinput", "--execute"])
  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
line 469, in run_manage_command
execute_manager(reviewboard.settings, [__file__, cmd] + params)
  File
"/usr/lib/python2.6/site-packages/django/core/management/__init__.py",
line 438, in execute_manager
utility.execute()
  File
"/usr/lib/python2.6/site-packages/django/core/management/__init__.py",
line 379, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
  File
"/usr/lib/python2.6/site-packages/django/core/management/base.py", line
191, in run_from_argv
self.execute(*args, **options.__dict__)
  File
"/usr/lib/python2.6/site-packages/django/core/management/base.py", line
220, in execute
output = self.handle(*args, **options)
  File
"/usr/lib/python2.6/site-packages/django_evolution/management/commands/evolve.py",
 line 60, in handle
self.evolve(*app_labels, **options)
  File
"/usr/lib/python2.6/site-packages/django_evolution/management/commands/evolve.py",
 line 140, in evolve
database))
  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
line 418, in mutate
return self.add_column(app_label, proj_sig, database)
  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
line 426, in add_column
self.field_attrs, model)
  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
line 33, in create_field
related_model_sig = proj_sig[related_app_name][related_model_name]
KeyError: 'site'

And again after updating to django_evolution 0.6.7 (to be sure):

[sgallagh@hosted03 conf]$ sudo rb-site upgrade /srv/reviewboard
Rebuilding directory structure
/usr/lib/python2.6/site-packages/django/db/__init__.py:60:
DeprecationWarning: Short names for ENGINE in database configurations
are deprecated. Prepend default.ENGINE with 'django.db.backends.'
  DeprecationWarning
Upgrading from version 1.6.5
Updating database. This may take a while.
Creating tables ...
There are unapplied evolutions for sessions.
There are unapplied evolutions for accounts.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Loading FAS groups...
FAS groups loaded. Don't forget to set FAS_USERNAME and FAS_PASSWORD to
a low-privilege account.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
No fixtures found.
Traceback (most recent call last):
  File "/usr/bin/

Re: Upgrade issues from 1.5.7 to 1.6.5

2012-04-23 Thread Christian Hammond
Hi Stephen,

Hmm, that's concerning. My upgrade simulations aren't reproducing that.

The same issue should be hit for any 1.6 release. 

Is this for the packages or FedoraHosted?

It almost sounds like the syncdb didn't set up the site app. We're there any 
warnings? Do you see those in the database?

Christian


On Apr 23, 2012, at 8:32, Stephen Gallagher  wrote:

> I'm getting the following error while trying to upgrade my 1.5.7 install
> to the newer 1.6.5 package during 'rb-site upgrade'.
> 
> I am using django_evolution 0.6.7. This error is resulting in an outage
> situation, so I could really use some help quickly :(
> 
> 
>  File "/usr/bin/rb-site", line 9, in 
>load_entry_point('ReviewBoard==1.6.5', 'console_scripts',
> 'rb-site')()
>  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
> line 1760, in main
>command.run()
>  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
> line 1650, in run
>site.migrate_database()
>  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
> line 353, in migrate_database
>self.run_manage_command("evolve", ["--noinput", "--execute"])
>  File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py",
> line 469, in run_manage_command
>execute_manager(reviewboard.settings, [__file__, cmd] + params)
>  File
> "/usr/lib/python2.6/site-packages/django/core/management/__init__.py",
> line 438, in execute_manager
>utility.execute()
>  File
> "/usr/lib/python2.6/site-packages/django/core/management/__init__.py",
> line 379, in execute
>self.fetch_command(subcommand).run_from_argv(self.argv)
>  File
> "/usr/lib/python2.6/site-packages/django/core/management/base.py", line
> 191, in run_from_argv
>self.execute(*args, **options.__dict__)
>  File
> "/usr/lib/python2.6/site-packages/django/core/management/base.py", line
> 220, in execute
>output = self.handle(*args, **options)
>  File
> "/usr/lib/python2.6/site-packages/django_evolution/management/commands/evolve.py",
>  line 60, in handle
>self.evolve(*app_labels, **options)
>  File
> "/usr/lib/python2.6/site-packages/django_evolution/management/commands/evolve.py",
>  line 140, in evolve
>database))
>  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
> line 426, in mutate
>return self.add_column(app_label, proj_sig, database)
>  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
> line 434, in add_column
>self.field_attrs, model)
>  File "/usr/lib/python2.6/site-packages/django_evolution/mutations.py",
> line 33, in create_field
>related_model_sig = proj_sig[related_app_name][related_model_name]
> KeyError: 'site'
> 
> 
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Upgrade issues

2009-07-17 Thread Ben

I went to the admin part and looked for something that looks like
'reviews_reviewrequestdraft.changedesc_id' visited the right page
(http://server/admin/db/reviews/reviewrequestdraft/), did nothing,
saved, and it's gone ...

thanks anyway for pointing the right database ...

On Fri, Jul 17, 2009 at 15:38, Ben wrote:
> Hi there,
>
> Upgrading from an svn install I'm also hitting that one ...
>
> How did you solved it ? manually editing the database ?
>
> Regards,
> Benoit
>
> On Mon, Dec 8, 2008 at 20:12, Chris Clark wrote:
>> Christian Hammond wrote:
>>
>> This was due to a bug I'm currently fixing. I should have it in in about 15
>> mins.
>>
>> I'm not sure which this referred to. I've pulled (new) headrevs - I still
>> get the problem with htdocs and an existing review not viewable anymore.
>>
>> BUT I know how to deal with htdocs (I'll start using the new rb-site
>> script).
>>
>> RE the review not visible anymore I now know what the problem is! If you
>> have any reviews in Draft, i.e not yet published, and you are pre "change
>> description on review update", at the time of the evolve. With sqlite the
>> evolve appears to use the string 'changedesc_id' for the
>> reviews_reviewrequestdraft.changedesc_id column (supposed to be integer or
>> null). For the draft reviews I've simple updated all the
>> reviews_reviewrequestdraft.changedesc_id columns to NULL if they ==
>> 'changedesc_id' - I've not looked any further into this or checked other
>> database engines.
>>
>> Summary of the problem:
>>
>> upgrade from release of RB that does not have the change description field
>> on updated reviews
>> using sqlite
>> have an existing review, that is in draft (with some updated diffs)
>> you are logged in as the review owner
>> you evolve the database
>> view review
>>
>> Error traceback (from debug on, so result go to web browser)
>>
>> TemplateSyntaxError at /r/62/
>>
>> Caught an exception while rendering: invalid literal for int():
>> changedesc_id
>>
>> Original Traceback (most recent call last):
>>   File "C:\svn\django\django\template\debug.py", line 71, in render_node
>>     result = node.render(context)
>>   File "C:\svn\django\django\template\debug.py", line 87, in render
>>     output = force_unicode(self.filter_expression.resolve(context))
>>   File "C:\svn\django\django\template\__init__.py", line 535, in resolve
>>     obj = self.var.resolve(context)
>>   File "C:\svn\django\django\template\__init__.py", line 676, in resolve
>>     value = self._resolve_lookup(context)
>>   File "C:\svn\django\django\template\__init__.py", line 705, in
>> _resolve_lookup
>>     current = getattr(current, bit)
>>   File "C:\svn\django\django\db\models\fields\related.py", line 248, in
>> __get__
>>     rel_obj = QuerySet(self.field.rel.to).get(**params)
>>   File "C:\svn\django\django\db\models\query.py", line 297, in get
>>     clone = self.filter(*args, **kwargs)
>>   File "C:\svn\django\django\db\models\query.py", line 483, in filter
>>     return self._filter_or_exclude(False, *args, **kwargs)
>>   File "C:\svn\django\django\db\models\query.py", line 501, in
>> _filter_or_exclude
>>     clone.query.add_q(Q(*args, **kwargs))
>>   File "C:\svn\django\django\db\models\sql\query.py", line 1224, in add_q
>>     can_reuse=used_aliases)
>>   File "C:\svn\django\django\db\models\sql\query.py", line 1167, in
>> add_filter
>>     self.where.add((alias, col, field, lookup_type, value), connector)
>>   File "C:\svn\django\django\db\models\sql\where.py", line 48, in add
>>     params = field.get_db_prep_lookup(lookup_type, value)
>>   File "C:\svn\django\django\db\models\fields\__init__.py", line 202, in
>> get_db_prep_lookup
>>     return [self.get_db_prep_value(value)]
>>   File "C:\svn\django\django\db\models\fields\__init__.py", line 353, in
>> get_db_prep_value
>>     return int(value)
>> ValueError: invalid literal for int(): changedesc_id
>>
>> Request Method: GET
>> Request URL: http://clach04-745.ingres.prv:8000/r/62/
>> Exception Type: TemplateSyntaxError
>> Exception Value:
>>
>> Caught an exception while rendering: invalid literal for int():
>> changedesc_id
>>
>> Original Traceback (most recent call last):
>>   File "C:\svn\django\django\template\debug.py", line 71, in render_node
>>     result = node.render(context)
>>   File "C:\svn\django\django\template\debug.py", line 87, in render
>>     output = force_unicode(self.filter_expression.resolve(context))
>>   File "C:\svn\django\django\template\__init__.py", line 535, in resolve
>>     obj = self.var.resolve(context)
>>   File "C:\svn\django\django\template\__init__.py", line 676, in resolve
>>     value = self._resolve_lookup(context)
>>   File "C:\svn\django\django\template\__init__.py", line 705, in
>> _resolve_lookup
>>     current = getattr(current, bit)
>>   File "C:\svn\django\django\db\models\fields\related.py", line 248, in
>> __get__
>>     rel_obj = QuerySet(self.field.rel.to).get(**params)
>>   File "C:\svn\django\django\db\models\query.py", line

Re: Upgrade issues

2009-07-17 Thread Ben

Hi there,

Upgrading from an svn install I'm also hitting that one ...

How did you solved it ? manually editing the database ?

Regards,
Benoit

On Mon, Dec 8, 2008 at 20:12, Chris Clark wrote:
> Christian Hammond wrote:
>
> This was due to a bug I'm currently fixing. I should have it in in about 15
> mins.
>
> I'm not sure which this referred to. I've pulled (new) headrevs - I still
> get the problem with htdocs and an existing review not viewable anymore.
>
> BUT I know how to deal with htdocs (I'll start using the new rb-site
> script).
>
> RE the review not visible anymore I now know what the problem is! If you
> have any reviews in Draft, i.e not yet published, and you are pre "change
> description on review update", at the time of the evolve. With sqlite the
> evolve appears to use the string 'changedesc_id' for the
> reviews_reviewrequestdraft.changedesc_id column (supposed to be integer or
> null). For the draft reviews I've simple updated all the
> reviews_reviewrequestdraft.changedesc_id columns to NULL if they ==
> 'changedesc_id' - I've not looked any further into this or checked other
> database engines.
>
> Summary of the problem:
>
> upgrade from release of RB that does not have the change description field
> on updated reviews
> using sqlite
> have an existing review, that is in draft (with some updated diffs)
> you are logged in as the review owner
> you evolve the database
> view review
>
> Error traceback (from debug on, so result go to web browser)
>
> TemplateSyntaxError at /r/62/
>
> Caught an exception while rendering: invalid literal for int():
> changedesc_id
>
> Original Traceback (most recent call last):
>   File "C:\svn\django\django\template\debug.py", line 71, in render_node
> result = node.render(context)
>   File "C:\svn\django\django\template\debug.py", line 87, in render
> output = force_unicode(self.filter_expression.resolve(context))
>   File "C:\svn\django\django\template\__init__.py", line 535, in resolve
> obj = self.var.resolve(context)
>   File "C:\svn\django\django\template\__init__.py", line 676, in resolve
> value = self._resolve_lookup(context)
>   File "C:\svn\django\django\template\__init__.py", line 705, in
> _resolve_lookup
> current = getattr(current, bit)
>   File "C:\svn\django\django\db\models\fields\related.py", line 248, in
> __get__
> rel_obj = QuerySet(self.field.rel.to).get(**params)
>   File "C:\svn\django\django\db\models\query.py", line 297, in get
> clone = self.filter(*args, **kwargs)
>   File "C:\svn\django\django\db\models\query.py", line 483, in filter
> return self._filter_or_exclude(False, *args, **kwargs)
>   File "C:\svn\django\django\db\models\query.py", line 501, in
> _filter_or_exclude
> clone.query.add_q(Q(*args, **kwargs))
>   File "C:\svn\django\django\db\models\sql\query.py", line 1224, in add_q
> can_reuse=used_aliases)
>   File "C:\svn\django\django\db\models\sql\query.py", line 1167, in
> add_filter
> self.where.add((alias, col, field, lookup_type, value), connector)
>   File "C:\svn\django\django\db\models\sql\where.py", line 48, in add
> params = field.get_db_prep_lookup(lookup_type, value)
>   File "C:\svn\django\django\db\models\fields\__init__.py", line 202, in
> get_db_prep_lookup
> return [self.get_db_prep_value(value)]
>   File "C:\svn\django\django\db\models\fields\__init__.py", line 353, in
> get_db_prep_value
> return int(value)
> ValueError: invalid literal for int(): changedesc_id
>
> Request Method: GET
> Request URL: http://clach04-745.ingres.prv:8000/r/62/
> Exception Type: TemplateSyntaxError
> Exception Value:
>
> Caught an exception while rendering: invalid literal for int():
> changedesc_id
>
> Original Traceback (most recent call last):
>   File "C:\svn\django\django\template\debug.py", line 71, in render_node
> result = node.render(context)
>   File "C:\svn\django\django\template\debug.py", line 87, in render
> output = force_unicode(self.filter_expression.resolve(context))
>   File "C:\svn\django\django\template\__init__.py", line 535, in resolve
> obj = self.var.resolve(context)
>   File "C:\svn\django\django\template\__init__.py", line 676, in resolve
> value = self._resolve_lookup(context)
>   File "C:\svn\django\django\template\__init__.py", line 705, in
> _resolve_lookup
> current = getattr(current, bit)
>   File "C:\svn\django\django\db\models\fields\related.py", line 248, in
> __get__
> rel_obj = QuerySet(self.field.rel.to).get(**params)
>   File "C:\svn\django\django\db\models\query.py", line 297, in get
> clone = self.filter(*args, **kwargs)
>   File "C:\svn\django\django\db\models\query.py", line 483, in filter
> return self._filter_or_exclude(False, *args, **kwargs)
>   File "C:\svn\django\django\db\models\query.py", line 501, in
> _filter_or_exclude
> clone.query.add_q(Q(*args, **kwargs))
>   File "C:\svn\django\django\db\models\sql\query.py", line 1224, in add_q
> can_reuse=used_aliases)
>   File

Re: Upgrade issues

2008-12-05 Thread Christian Hammond
Hey Chris.

This was due to a bug I'm currently fixing. I should have it in in about 15
mins.

We've moved to using rb-site for site installations recently, and a recent
change to settings.py has it look for htdocs in the parent directory of
wherever settings_local.py is stored. This is due to the rb-site install
directory structure (sitedir/conf/settings_local.py, sitedir/htdocs/, ...).
I'm making it smarter so it will only do that if settings_local.py and
settings.py aren't in the same directory.

I would really recommend at this point using rb-site to do any site
installs, even if you're using svn. You can run "python setup.py install"
from your SVN checkout to get things installed so you can use rb-site. This
will maintain your tree, get everything put into the right locations, and
keep media files up-to-date.

The GettingStarted guide has more info for migrating to this.

Christian

-- 
Christian Hammond - [EMAIL PROTECTED]
VMware, Inc.


On Fri, Dec 5, 2008 at 5:13 PM, Chris Clark <[EMAIL PROTECTED]> wrote:

>
> I've just moved to rev 1623 in trunk (I was at 1519). I do like the new
> "manual upgrade required" screen that pops up (settings.py has been
> updated to change the location for "htdocs/media/uploaded/images"). Very
> slick and should saves lots of admin hair pulling :-)
>
> However when I first loaded the main page (and review page) it appeared
> to be "messed up" in Google Chrome and IE6 (to the point that diffs are
> not usable). This turned out to be because the whole of the htdocs
> directory had moved (changes to settings.py), not just the upload dir.
>
>REM this is new with heads revs as of 5th dec 2008
>REM rev 1623
>mkdir C:\svn\django\htdocs\media\uploaded\images
>mkdir C:\svn\django\htdocs\media\rb\images
>xcopy /S /Y C:\svn\django\reviewboard\htdocs C:\svn\django\htdocs
>
> I'm assuming I can still run from SVN without the deployment tool pre RB
> 1.0 - is this a bad assumption?
>
> Before the change RB was using (on this Windows box)
> C:\svn\django\reviewboard\htdocs. The good thing is that the manual
> upgrade required web page helped me work out what was going in.
>
> I also had some problems with the evolve, it worked but accessing (old)
> reviews (against svn) I get errors about bad change description/numbers
> :-(. Oddly the old reviews with my work in progress SCMTool are fine.
> I'm planning on starting a fresh db but I have copies (sqlitedb) if
> there is interest in debugging this. It isn't bothering me but I thought
> I would mention it (rather than logging a bug/issue). The pull from
> trunk also updated dbjlets, etc.
>
> I don't need fixes but wanted to share this in case other people hit
> this too (and in case I'm deploying incorrectly).
>
> Thanks!
>
> Chris
>
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---