Re: View Diff is broken: Diff currently unavailable.
Sounds like the Perforce SCM backend is saying it can't find the Perforce program. Do you have the "p4" binary available in the server's PATH? Regards, Chris On 3 Feb 2009, at 23:38, Cong Do wrote: > Hi Christian, > We are still trying to use post-review for P4. After running post- > review, > we get the following error when we try to view the diff. Any idea? > Posting the review was successful. > Cong. > > [Errno 2] No such file or directory > > Traceback (most recent call last): > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/views.py", line 86, in view_diff > files = get_diff_files(diffset, None, interdiffset, highlighting) > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 660, in > get_diff_files > enable_syntax_highlighting) > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 579, in > generate_files > large_data=True) > File "/usr/lib/python2.4/site-packages/Djblets-0.5alpha1-py2.4.egg/ > djblets/util/misc.py", line 142, in cache_memoize > data = lookup_callable() > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 578, in > enable_syntax_highlighting), > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 339, in > get_chunks > old = get_original_file(filediff) > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 246, in > get_original_file > large_data=True)[0] > File "/usr/lib/python2.4/site-packages/Djblets-0.5alpha1-py2.4.egg/ > djblets/util/misc.py", line 142, in cache_memoize > data = lookup_callable() > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 245, in > data = cache_memoize(key, lambda: [fetch_file(file, revision)], > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/diffviewer/diffutils.py", line 225, in > fetch_file > data = tool.get_file(file, revision) > File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1- > py2.4.egg/reviewboard/scmtools/perforce.py", line 92, in get_file > p = subprocess.Popen(cmdline, stdout=subprocess.PIPE, > stderr=subprocess.PIPE) > File "/usr/lib64/python2.4/subprocess.py", line 542, in __init__ > errread, errwrite) > File "/usr/lib64/python2.4/subprocess.py", line 975, in > _execute_child > raise child_exception > OSError: [Errno 2] No such file or directory > > > From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com > ] On Behalf Of Christian Hammond > Sent: Tuesday, February 03, 2009 2:53 PM > To: reviewboard@googlegroups.com > Subject: Re: View Diff is broken: Diff currently unavailable. > > It wouldn't have with last night's build. I didn't update the > dependency for the new nightly. > > Do an upgrade of Djblets as well and it should work. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > VMware, Inc. > > On Tue, Feb 3, 2009 at 2:43 PM, Matthew Von Bargen > wrote: > > I don't know... > > If running "sudo easy_install --upgrade ReviewBoard" upgrades Djblets > then I upgraded it. If not, then I did not. > > On Tue, Feb 3, 2009 at 2:38 PM, Christian Hammond > wrote: > > Er, yeah, key.. I'm a bit out of it today. > > > > Did you upgrade Djblets as well? > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > VMware, Inc. > > > > > > On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen > > > wrote: > >> > >> Okay. Thanks. > >> > >> Did you mean: > >> > >> key += "-%s" % settings.AJAX_SERIAL > >> > >> instead of : > >> > >> str += "-%s" % settings.AJAX_SERIAL > >> > >> ? > >> > >> If I do what you say, but assign to +key+ instead of +str+, then > >> things mostly work. But I am still seeing one "Diff currently > >> unavailable." error: > >> > >> Diff currently unavailable. > >> Error: 'Settings' object has no attribute 'AJAX_SERIAL' > >> Details > >> T
RE: View Diff is broken: Diff currently unavailable.
Hi Christian, We are still trying to use post-review for P4. After running post-review, we get the following error when we try to view the diff. Any idea? Posting the review was successful. Cong. [Errno 2] No such file or directory Traceback (most recent call last): File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/diffviewer/views.py", line 86, in view_diff files = get_diff_files(diffset, None, interdiffset, highlighting) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/diffviewer/diffutils.py", line 660, in get_diff_files enable_syntax_highlighting) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/diffviewer/diffutils.py", line 579, in generate_files large_data=True) File "/usr/lib/python2.4/site-packages/Djblets-0.5alpha1-py2.4.egg/djblets/ut il/misc.py", line 142, in cache_memoize data = lookup_callable() File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/diffviewer/diffutils.py", line 578, in enable_syntax_highlighting), File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/diffviewer/diffutils.py", line 339, in get_chunks old = get_original_file(filediff) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/diffviewer/diffutils.py", line 246, in get_original_file large_data=True)[0] File "/usr/lib/python2.4/site-packages/Djblets-0.5alpha1-py2.4.egg/djblets/ut il/misc.py", line 142, in cache_memoize data = lookup_callable() File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/diffviewer/diffutils.py", line 245, in data = cache_memoize(key, lambda: [fetch_file(file, revision)], File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/diffviewer/diffutils.py", line 225, in fetch_file data = tool.get_file(file, revision) File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha1-py2.4.egg/review board/scmtools/perforce.py", line 92, in get_file p = subprocess.Popen(cmdline, stdout=subprocess.PIPE, stderr=subprocess.PIPE) File "/usr/lib64/python2.4/subprocess.py", line 542, in __init__ errread, errwrite) File "/usr/lib64/python2.4/subprocess.py", line 975, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Tuesday, February 03, 2009 2:53 PM To: reviewboard@googlegroups.com Subject: Re: View Diff is broken: Diff currently unavailable. It wouldn't have with last night's build. I didn't update the dependency for the new nightly. Do an upgrade of Djblets as well and it should work. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Feb 3, 2009 at 2:43 PM, Matthew Von Bargen wrote: I don't know... If running "sudo easy_install --upgrade ReviewBoard" upgrades Djblets then I upgraded it. If not, then I did not. On Tue, Feb 3, 2009 at 2:38 PM, Christian Hammond wrote: > Er, yeah, key.. I'm a bit out of it today. > > Did you upgrade Djblets as well? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > VMware, Inc. > > > On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen > wrote: >> >> Okay. Thanks. >> >> Did you mean: >> >> key += "-%s" % settings.AJAX_SERIAL >> >> instead of : >> >> str += "-%s" % settings.AJAX_SERIAL >> >> ? >> >> If I do what you say, but assign to +key+ instead of +str+, then >> things mostly work. But I am still seeing one "Diff currently >> unavailable." error: >> >> Diff currently unavailable. >> Error: 'Settings' object has no attribute 'AJAX_SERIAL' >> Details >> Traceback (most recent call last): >> File >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2 .5.egg/reviewboard/diffviewer/views.py", >> line 193, in view_diff_fragment >>context, template_name)) >> File >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2 .5.egg/reviewboard/diffviewer/views.py", >> line 53, in build_diff_fragment >>key += "-%s" % settings.AJAX_SERIAL >> File >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/co nf/__init__.py", >> line 32, in __getattr__ >>return getattr(self._target, name) >> AttributeError: 'Settings' object has no
Re: View Diff is broken: Diff currently unavailable.
That fixed it. Thanks. On Tue, Feb 3, 2009 at 2:53 PM, Christian Hammond wrote: > It wouldn't have with last night's build. I didn't update the dependency for > the new nightly. > > Do an upgrade of Djblets as well and it should work. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > VMware, Inc. > > > On Tue, Feb 3, 2009 at 2:43 PM, Matthew Von Bargen > wrote: >> >> I don't know... >> >> If running "sudo easy_install --upgrade ReviewBoard" upgrades Djblets >> then I upgraded it. If not, then I did not. >> >> On Tue, Feb 3, 2009 at 2:38 PM, Christian Hammond >> wrote: >> > Er, yeah, key.. I'm a bit out of it today. >> > >> > Did you upgrade Djblets as well? >> > >> > Christian >> > >> > -- >> > Christian Hammond - chip...@chipx86.com >> > VMware, Inc. >> > >> > >> > On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen >> > wrote: >> >> >> >> Okay. Thanks. >> >> >> >> Did you mean: >> >> >> >> key += "-%s" % settings.AJAX_SERIAL >> >> >> >> instead of : >> >> >> >> str += "-%s" % settings.AJAX_SERIAL >> >> >> >> ? >> >> >> >> If I do what you say, but assign to +key+ instead of +str+, then >> >> things mostly work. But I am still seeing one "Diff currently >> >> unavailable." error: >> >> >> >> Diff currently unavailable. >> >> Error: 'Settings' object has no attribute 'AJAX_SERIAL' >> >> Details >> >> Traceback (most recent call last): >> >> File >> >> >> >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", >> >> line 193, in view_diff_fragment >> >>context, template_name)) >> >> File >> >> >> >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", >> >> line 53, in build_diff_fragment >> >>key += "-%s" % settings.AJAX_SERIAL >> >> File >> >> >> >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/conf/__init__.py", >> >> line 32, in __getattr__ >> >>return getattr(self._target, name) >> >> AttributeError: 'Settings' object has no attribute 'AJAX_SERIAL' >> >> >> >> >> >> >> >> On Tue, Feb 3, 2009 at 2:05 PM, Christian Hammond >> >> wrote: >> >> > Odd that I didn't hit that during testing... >> >> > >> >> > I've committed a fix to SVN, but you can edit >> >> > >> >> > >> >> > /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py >> >> > line 53 and change the line to: >> >> > >> >> > str += "-%s" % settings.AJAX_SERIAL >> >> > >> >> > I'm putting out the 1.0 alpha 2 release tonight, and this will be >> >> > fixed >> >> > along with it. >> >> > >> >> > Christian >> >> > >> >> > -- >> >> > Christian Hammond - chip...@chipx86.com >> >> > VMware, Inc. >> >> > >> >> > >> >> > On Tue, Feb 3, 2009 at 10:04 AM, mattvonb wrote: >> >> >> >> >> >> I recently upgraded my Review Board installation by running: >> >> >> >> >> >> sudo easy_install --upgrade ReviewBoard >> >> >> >> >> >> and >> >> >> >> >> >> sudo rb-site upgrade /path/to/my/install >> >> >> >> >> >> and now whenever I'm looking at a review and I click "View Diff" I >> >> >> get >> >> >> several of the following errors where the diffs would be: >> >> >> >> >> >> Diff currently unavailable. >> >> >> Error: cannot concatenate 'str' and 'int' objects >> >> >> >> >> >> Clicking the Details link shows me: >> >> >> >> >> >> Traceback (most recent call last): >> >> >> File "/usr/lib/python2.5/site-packages/ >> >> >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ >> >> >> views.py", line 193, in view_diff_fragment >> >> >>context, template_name)) >> >> >> File "/usr/lib/python2.5/site-packages/ >> >> >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ >> >> >> views.py", line 53, in build_diff_fragment >> >> >>key += '-' + settings.AJAX_SERIAL >> >> >> TypeError: cannot concatenate 'str' and 'int' objects >> >> >> >> >> >> >> >> >> What did I do wrong, and how can I fix it. Thanks. >> >> >> >> >> >> >> >> >> >> >> > >> >> > >> >> > > >> >> > >> >> >> >> >> > >> > >> > > >> > >> >> > > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: View Diff is broken: Diff currently unavailable.
It wouldn't have with last night's build. I didn't update the dependency for the new nightly. Do an upgrade of Djblets as well and it should work. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Feb 3, 2009 at 2:43 PM, Matthew Von Bargen wrote: > > I don't know... > > If running "sudo easy_install --upgrade ReviewBoard" upgrades Djblets > then I upgraded it. If not, then I did not. > > On Tue, Feb 3, 2009 at 2:38 PM, Christian Hammond > wrote: > > Er, yeah, key.. I'm a bit out of it today. > > > > Did you upgrade Djblets as well? > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > VMware, Inc. > > > > > > On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen > > wrote: > >> > >> Okay. Thanks. > >> > >> Did you mean: > >> > >> key += "-%s" % settings.AJAX_SERIAL > >> > >> instead of : > >> > >> str += "-%s" % settings.AJAX_SERIAL > >> > >> ? > >> > >> If I do what you say, but assign to +key+ instead of +str+, then > >> things mostly work. But I am still seeing one "Diff currently > >> unavailable." error: > >> > >> Diff currently unavailable. > >> Error: 'Settings' object has no attribute 'AJAX_SERIAL' > >> Details > >> Traceback (most recent call last): > >> File > >> > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", > >> line 193, in view_diff_fragment > >>context, template_name)) > >> File > >> > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", > >> line 53, in build_diff_fragment > >>key += "-%s" % settings.AJAX_SERIAL > >> File > >> > "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/conf/__init__.py", > >> line 32, in __getattr__ > >>return getattr(self._target, name) > >> AttributeError: 'Settings' object has no attribute 'AJAX_SERIAL' > >> > >> > >> > >> On Tue, Feb 3, 2009 at 2:05 PM, Christian Hammond > >> wrote: > >> > Odd that I didn't hit that during testing... > >> > > >> > I've committed a fix to SVN, but you can edit > >> > > >> > > /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py > >> > line 53 and change the line to: > >> > > >> > str += "-%s" % settings.AJAX_SERIAL > >> > > >> > I'm putting out the 1.0 alpha 2 release tonight, and this will be > fixed > >> > along with it. > >> > > >> > Christian > >> > > >> > -- > >> > Christian Hammond - chip...@chipx86.com > >> > VMware, Inc. > >> > > >> > > >> > On Tue, Feb 3, 2009 at 10:04 AM, mattvonb wrote: > >> >> > >> >> I recently upgraded my Review Board installation by running: > >> >> > >> >> sudo easy_install --upgrade ReviewBoard > >> >> > >> >> and > >> >> > >> >> sudo rb-site upgrade /path/to/my/install > >> >> > >> >> and now whenever I'm looking at a review and I click "View Diff" I > get > >> >> several of the following errors where the diffs would be: > >> >> > >> >> Diff currently unavailable. > >> >> Error: cannot concatenate 'str' and 'int' objects > >> >> > >> >> Clicking the Details link shows me: > >> >> > >> >> Traceback (most recent call last): > >> >> File "/usr/lib/python2.5/site-packages/ > >> >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > >> >> views.py", line 193, in view_diff_fragment > >> >>context, template_name)) > >> >> File "/usr/lib/python2.5/site-packages/ > >> >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > >> >> views.py", line 53, in build_diff_fragment > >> >>key += '-' + settings.AJAX_SERIAL > >> >> TypeError: cannot concatenate 'str' and 'int' objects > >> >> > >> >> > >> >> What did I do wrong, and how can I fix it. Thanks. > >> >> > >> >> > >> >> > >> > > >> > > >> > > > >> > > >> > >> > > > > > > > > > > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: View Diff is broken: Diff currently unavailable.
I don't know... If running "sudo easy_install --upgrade ReviewBoard" upgrades Djblets then I upgraded it. If not, then I did not. On Tue, Feb 3, 2009 at 2:38 PM, Christian Hammond wrote: > Er, yeah, key.. I'm a bit out of it today. > > Did you upgrade Djblets as well? > > Christian > > -- > Christian Hammond - chip...@chipx86.com > VMware, Inc. > > > On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen > wrote: >> >> Okay. Thanks. >> >> Did you mean: >> >> key += "-%s" % settings.AJAX_SERIAL >> >> instead of : >> >> str += "-%s" % settings.AJAX_SERIAL >> >> ? >> >> If I do what you say, but assign to +key+ instead of +str+, then >> things mostly work. But I am still seeing one "Diff currently >> unavailable." error: >> >> Diff currently unavailable. >> Error: 'Settings' object has no attribute 'AJAX_SERIAL' >> Details >> Traceback (most recent call last): >> File >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", >> line 193, in view_diff_fragment >>context, template_name)) >> File >> "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", >> line 53, in build_diff_fragment >>key += "-%s" % settings.AJAX_SERIAL >> File >> "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/conf/__init__.py", >> line 32, in __getattr__ >>return getattr(self._target, name) >> AttributeError: 'Settings' object has no attribute 'AJAX_SERIAL' >> >> >> >> On Tue, Feb 3, 2009 at 2:05 PM, Christian Hammond >> wrote: >> > Odd that I didn't hit that during testing... >> > >> > I've committed a fix to SVN, but you can edit >> > >> > /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py >> > line 53 and change the line to: >> > >> > str += "-%s" % settings.AJAX_SERIAL >> > >> > I'm putting out the 1.0 alpha 2 release tonight, and this will be fixed >> > along with it. >> > >> > Christian >> > >> > -- >> > Christian Hammond - chip...@chipx86.com >> > VMware, Inc. >> > >> > >> > On Tue, Feb 3, 2009 at 10:04 AM, mattvonb wrote: >> >> >> >> I recently upgraded my Review Board installation by running: >> >> >> >> sudo easy_install --upgrade ReviewBoard >> >> >> >> and >> >> >> >> sudo rb-site upgrade /path/to/my/install >> >> >> >> and now whenever I'm looking at a review and I click "View Diff" I get >> >> several of the following errors where the diffs would be: >> >> >> >> Diff currently unavailable. >> >> Error: cannot concatenate 'str' and 'int' objects >> >> >> >> Clicking the Details link shows me: >> >> >> >> Traceback (most recent call last): >> >> File "/usr/lib/python2.5/site-packages/ >> >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ >> >> views.py", line 193, in view_diff_fragment >> >>context, template_name)) >> >> File "/usr/lib/python2.5/site-packages/ >> >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ >> >> views.py", line 53, in build_diff_fragment >> >>key += '-' + settings.AJAX_SERIAL >> >> TypeError: cannot concatenate 'str' and 'int' objects >> >> >> >> >> >> What did I do wrong, and how can I fix it. Thanks. >> >> >> >> >> >> >> > >> > >> > > >> > >> >> > > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: View Diff is broken: Diff currently unavailable.
Er, yeah, key.. I'm a bit out of it today. Did you upgrade Djblets as well? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Feb 3, 2009 at 2:35 PM, Matthew Von Bargen wrote: > > Okay. Thanks. > > Did you mean: > > key += "-%s" % settings.AJAX_SERIAL > > instead of : > > str += "-%s" % settings.AJAX_SERIAL > > ? > > If I do what you say, but assign to +key+ instead of +str+, then > things mostly work. But I am still seeing one "Diff currently > unavailable." error: > > Diff currently unavailable. > Error: 'Settings' object has no attribute 'AJAX_SERIAL' > Details > Traceback (most recent call last): > File > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", > line 193, in view_diff_fragment >context, template_name)) > File > "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", > line 53, in build_diff_fragment > key += "-%s" % settings.AJAX_SERIAL > File > "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/conf/__init__.py", > line 32, in __getattr__ >return getattr(self._target, name) > AttributeError: 'Settings' object has no attribute 'AJAX_SERIAL' > > > > On Tue, Feb 3, 2009 at 2:05 PM, Christian Hammond > wrote: > > Odd that I didn't hit that during testing... > > > > I've committed a fix to SVN, but you can edit > > > /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py > > line 53 and change the line to: > > > > str += "-%s" % settings.AJAX_SERIAL > > > > I'm putting out the 1.0 alpha 2 release tonight, and this will be fixed > > along with it. > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > VMware, Inc. > > > > > > On Tue, Feb 3, 2009 at 10:04 AM, mattvonb wrote: > >> > >> I recently upgraded my Review Board installation by running: > >> > >> sudo easy_install --upgrade ReviewBoard > >> > >> and > >> > >> sudo rb-site upgrade /path/to/my/install > >> > >> and now whenever I'm looking at a review and I click "View Diff" I get > >> several of the following errors where the diffs would be: > >> > >> Diff currently unavailable. > >> Error: cannot concatenate 'str' and 'int' objects > >> > >> Clicking the Details link shows me: > >> > >> Traceback (most recent call last): > >> File "/usr/lib/python2.5/site-packages/ > >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > >> views.py", line 193, in view_diff_fragment > >>context, template_name)) > >> File "/usr/lib/python2.5/site-packages/ > >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > >> views.py", line 53, in build_diff_fragment > >>key += '-' + settings.AJAX_SERIAL > >> TypeError: cannot concatenate 'str' and 'int' objects > >> > >> > >> What did I do wrong, and how can I fix it. Thanks. > >> > >> > >> > > > > > > > > > > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: View Diff is broken: Diff currently unavailable.
Okay. Thanks. Did you mean: key += "-%s" % settings.AJAX_SERIAL instead of : str += "-%s" % settings.AJAX_SERIAL ? If I do what you say, but assign to +key+ instead of +str+, then things mostly work. But I am still seeing one "Diff currently unavailable." error: Diff currently unavailable. Error: 'Settings' object has no attribute 'AJAX_SERIAL' Details Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", line 193, in view_diff_fragment context, template_name)) File "/usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py", line 53, in build_diff_fragment key += "-%s" % settings.AJAX_SERIAL File "/usr/lib/python2.5/site-packages/Django-1.0.2_final-py2.5.egg/django/conf/__init__.py", line 32, in __getattr__ return getattr(self._target, name) AttributeError: 'Settings' object has no attribute 'AJAX_SERIAL' On Tue, Feb 3, 2009 at 2:05 PM, Christian Hammond wrote: > Odd that I didn't hit that during testing... > > I've committed a fix to SVN, but you can edit > /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py > line 53 and change the line to: > > str += "-%s" % settings.AJAX_SERIAL > > I'm putting out the 1.0 alpha 2 release tonight, and this will be fixed > along with it. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > VMware, Inc. > > > On Tue, Feb 3, 2009 at 10:04 AM, mattvonb wrote: >> >> I recently upgraded my Review Board installation by running: >> >> sudo easy_install --upgrade ReviewBoard >> >> and >> >> sudo rb-site upgrade /path/to/my/install >> >> and now whenever I'm looking at a review and I click "View Diff" I get >> several of the following errors where the diffs would be: >> >> Diff currently unavailable. >> Error: cannot concatenate 'str' and 'int' objects >> >> Clicking the Details link shows me: >> >> Traceback (most recent call last): >> File "/usr/lib/python2.5/site-packages/ >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ >> views.py", line 193, in view_diff_fragment >>context, template_name)) >> File "/usr/lib/python2.5/site-packages/ >> ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ >> views.py", line 53, in build_diff_fragment >>key += '-' + settings.AJAX_SERIAL >> TypeError: cannot concatenate 'str' and 'int' objects >> >> >> What did I do wrong, and how can I fix it. Thanks. >> >> >> > > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: View Diff is broken: Diff currently unavailable.
Odd that I didn't hit that during testing... I've committed a fix to SVN, but you can edit /usr/lib/python2.5/site-packages/ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/views.py line 53 and change the line to: str += "-%s" % settings.AJAX_SERIAL I'm putting out the 1.0 alpha 2 release tonight, and this will be fixed along with it. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Feb 3, 2009 at 10:04 AM, mattvonb wrote: > > I recently upgraded my Review Board installation by running: > > sudo easy_install --upgrade ReviewBoard > > and > > sudo rb-site upgrade /path/to/my/install > > and now whenever I'm looking at a review and I click "View Diff" I get > several of the following errors where the diffs would be: > > Diff currently unavailable. > Error: cannot concatenate 'str' and 'int' objects > > Clicking the Details link shows me: > > Traceback (most recent call last): > File "/usr/lib/python2.5/site-packages/ > ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > views.py", line 193, in view_diff_fragment >context, template_name)) > File "/usr/lib/python2.5/site-packages/ > ReviewBoard-1.0alpha2.dev_20090203-py2.5.egg/reviewboard/diffviewer/ > views.py", line 53, in build_diff_fragment >key += '-' + settings.AJAX_SERIAL > TypeError: cannot concatenate 'str' and 'int' objects > > > What did I do wrong, and how can I fix it. Thanks. > > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
