Re: Way to send "branch" review in subversion?
There isn't any support in post-review for Subversion diffs on separate branches. The only place in the code (that I'm familiar with) that does a diff between two URLs in the repository is in SVNClient.diff_between_revisions(). You could probably use that as a model to add a diff_between_branches() that you could call from SVNClient.diff() when options.branch is defined. On Feb 3, 2:05 pm, Jan Koprowski wrote: > I think about this scenario: > > 1. Developer make branche > 2. Developer make changes on the branch > 3. Developer merge latest trunk to branch > 4. Developer run "post-review --tracking-branch my-feature" > 5. post-review check is branch "svnlook propget svn:mergeinfo" > containe "svnlook youngest" revision of trunk > 6. If not raise error and ask about merging to latest trunk > 7. If contain make diff between /branches/my-feature and /trunk > > I'm not sure this is fine but ... I think it is fine :) > > > > > > On Thu, Feb 3, 2011 at 7:27 PM, D Krueger wrote: > > Are you trying to do the diff against the latest trunk or the trunk > > when the branch occurred? > > > On Feb 3, 10:13 am, Jan Koprowski wrote: > >> Hi, > > >> I've been poking around in post-review code but I still can't figure it > >> out - is there way to send review for whole branch in subversion? Branch I > >> mean /branches/my-feature directory in repository and everything in it. > >> Diff > >> will be between this and /trunk dir. Something like this. > > >> Greetings from Poland > >> -- > >> Jan Koprowski > > > -- > > Want to help the Review Board project? Donate today > > athttp://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group > > athttp://groups.google.com/group/reviewboard?hl=en > > -- > > > > ><> Jan Koprowski- Hide quoted text - > > - Show quoted text -- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Way to send "branch" review in subversion?
I think about this scenario: 1. Developer make branche 2. Developer make changes on the branch 3. Developer merge latest trunk to branch 4. Developer run "post-review --tracking-branch my-feature" 5. post-review check is branch "svnlook propget svn:mergeinfo" containe "svnlook youngest" revision of trunk 6. If not raise error and ask about merging to latest trunk 7. If contain make diff between /branches/my-feature and /trunk I'm not sure this is fine but ... I think it is fine :) On Thu, Feb 3, 2011 at 7:27 PM, D Krueger wrote: > Are you trying to do the diff against the latest trunk or the trunk > when the branch occurred? > > On Feb 3, 10:13 am, Jan Koprowski wrote: >> Hi, >> >> I've been poking around in post-review code but I still can't figure it >> out - is there way to send review for whole branch in subversion? Branch I >> mean /branches/my-feature directory in repository and everything in it. Diff >> will be between this and /trunk dir. Something like this. >> >> Greetings from Poland >> -- >> Jan Koprowski > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- ><> Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Way to send "branch" review in subversion?
Are you trying to do the diff against the latest trunk or the trunk when the branch occurred? On Feb 3, 10:13 am, Jan Koprowski wrote: > Hi, > > I've been poking around in post-review code but I still can't figure it > out - is there way to send review for whole branch in subversion? Branch I > mean /branches/my-feature directory in repository and everything in it. Diff > will be between this and /trunk dir. Something like this. > > Greetings from Poland > -- > Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
