Re: Why review of not existing file or revision or without SCM is forbidden ?

2012-01-28 Thread Ilkka Laukkanen
D'ohh, of course :) Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+u

Re: Why review of not existing file or revision or without SCM is forbidden ?

2012-01-27 Thread Nicolas VINOT
2012/1/26 David Trowbridge : > The diffs that get sent and stored on the server are just diffs. Review > Board fetches > the source file in order to generate the two-column view. Repo access is mandatory to generate 2-column view with more context lines. But 2-column is possible from the diff only

Re: Why review of not existing file or revision or without SCM is forbidden ?

2012-01-26 Thread David Trowbridge
The diffs that get sent and stored on the server are just diffs. Review Board fetches the source file in order to generate the two-column view. -David On Wed, Jan 25, 2012 at 7:18 AM, Ilkka Laukkanen < ilkka.s.laukka...@gmail.com> wrote: > On Tuesday, 3 January 2012 09:57:20 UTC+2, morisgi wrot

Re: Why review of not existing file or revision or without SCM is forbidden ?

2012-01-26 Thread Ilkka Laukkanen
On Tuesday, 3 January 2012 09:57:20 UTC+2, morisgi wrote: > > RB needs to dump the content of files at certain revision to perform the > diffs. > What operations do this? I thought that at least for the normal* git workflows the diffs are generated on the client side? *) normal as in submit unco

Re: Why review of not existing file or revision or without SCM is forbidden ?

2012-01-02 Thread Gilles Moris
On Thursday 29 December 2011 12:00:07 pm Nicolas Vinot wrote: > First, Mercurial SSH support is broken on RB, but because SCM URL is > mandatory and must point to real existing repo, I have to use filesystem > path instead of ssh:// (fortunately, RB and mercurial-server are on the > same server). B