Re: post-review doesn't find my CVS repository

2010-01-06 Thread heffe
On Jan 5, 9:29 pm, Christian Hammond  wrote:
> Our repository matching right now requires exact matches, unfortunately. I'd
> like to add better fuzzy matching in the future that would better handle
> these cases.
>
> For now, though, change the Path back to what it was and set Mirror Path to
> what post-review is "cvsserver.domain.com:/reporoot". It should then find
> that match and continue to use Path for querying the server.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
This fixed it for me.  Thanks!
-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: post-review doesn't find my CVS repository

2010-01-06 Thread Chris Clark
The other option is to add a command line override for the SCM 
repository information.


I ended up doing this for the SCM we use . although I've not yet 
needed to make use of it :-) I think this is what the --p4-port flag is 
for with Perforce.


You could also have some sort of mapping in the .reviewboardrc file 
(again you would need to implement this logic). These would probably be 
good contributions back for post-review if you do work on this.


Chris

qhlonline wrote:


Hi,sir.

I have met this problem before. post-review's CVSClient now get the 
host name of CVS Server through "socket.getfqdn(host)", to replace 
host part of your "CVSPath" string. But ReviewBoard server seems not 
support it. So you can edit post-review yourself. You should find the 
CVSClient part and function "get_repository_info()", you move the last 
sentence of this function after "fp.close()" and ignore following 
source code, That may be fine. You can have a try.


Best Regards!

??2010-01-06 13:19:31??heffe  ??
>I have been using Review Board for a 3-4 months using the Web UI to
>submit review requests.  I'm now trying to make use of post-review but
>I am unable to get it to work with my CVS repository configuration.  I
>have multiple repositories configured on my Review Board server, some
>SVN, some CVS.  One of the SVN repositories I have tested works with
>post-review, but CVS does not.
>
>My Review Board server configuration has a CVS repository configured
>with:
>
>:pserver:u...@cvsserver.domain.com:/reporoot
>
>(my CVS login doesn't need a password)
>
>When I try to use post-review, I see
>
>  $ post-review -d
>  >>> svn info
>  >>> repository info: Path: cvsserver.domain.com:/reporoot, Base
>path: None, Supports changesets: False
>  >>> cvs diff -uN
>  >>> Looking for 'reviewboard.mydomain.com /' cookie in /home/
>heffe/.post-review-cookies.txt
>  >>> Loaded valid cookie -- no login required
>  >>> Attempting to create review request for None
>  >>> HTTP POSTing to 
http://reviewboard.mydomain.com/api/json/reviewrequests/new/:
>{'repository_path': 'cvsserver.domain.com:/reporoot'}
>  Error creating review request: The repository path specified is not
>in the list of known repositories (code 206)
>
>I've been digging for hours to try and get around this but I can't
>figure it out.  I tried removing the username from the Review Board
>repository configuration and then adding it to the username field on
>the repository editor page, but that fails completely to talk to my
>CVS repository.
>
>Any thoughts?  Why does post-review not identify the CVS repository
>configuration I have in my Review Board server?
  





-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: post-review doesn't find my CVS repository

2010-01-05 Thread Christian Hammond
Our repository matching right now requires exact matches, unfortunately. I'd
like to add better fuzzy matching in the future that would better handle
these cases.

For now, though, change the Path back to what it was and set Mirror Path to
what post-review is "cvsserver.domain.com:/reporoot". It should then find
that match and continue to use Path for querying the server.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Tue, Jan 5, 2010 at 9:19 PM, heffe  wrote:

> I have been using Review Board for a 3-4 months using the Web UI to
> submit review requests.  I'm now trying to make use of post-review but
> I am unable to get it to work with my CVS repository configuration.  I
> have multiple repositories configured on my Review Board server, some
> SVN, some CVS.  One of the SVN repositories I have tested works with
> post-review, but CVS does not.
>
> My Review Board server configuration has a CVS repository configured
> with:
>
> :pserver:u...@cvsserver.domain.com:/reporoot
>
> (my CVS login doesn't need a password)
>
> When I try to use post-review, I see
>
>  $ post-review -d
>  >>> svn info
>  >>> repository info: Path: cvsserver.domain.com:/reporoot, Base
> path: None, Supports changesets: False
>  >>> cvs diff -uN
>  >>> Looking for 'reviewboard.mydomain.com /' cookie in /home/
> heffe/.post-review-cookies.txt
>  >>> Loaded valid cookie -- no login required
>  >>> Attempting to create review request for None
>  >>> HTTP POSTing to
> http://reviewboard.mydomain.com/api/json/reviewrequests/new/:
> {'repository_path': 'cvsserver.domain.com:/reporoot'}
>  Error creating review request: The repository path specified is not
> in the list of known repositories (code 206)
>
> I've been digging for hours to try and get around this but I can't
> figure it out.  I tried removing the username from the Review Board
> repository configuration and then adding it to the username field on
> the repository editor page, but that fails completely to talk to my
> CVS repository.
>
> Any thoughts?  Why does post-review not identify the CVS repository
> configuration I have in my Review Board server?
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en