Re: post-review in git with svn remote
It uses master by default, but you can do a diff against any other parent branch using the --parent= parameter. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Wed, Sep 24, 2008 at 3:40 PM, Rusty Burchfield <[EMAIL PROTECTED]> wrote: > > On Sep 8, 2:14 pm, Rusty Burchfield <[EMAIL PROTECTED]> wrote: > > Are there any other settings I need to change? > > Ah ha! I was testing on master, but you apparently have to be on a > branch for it to work. > > I guess it is doing a diff against master. This seems to cause some > issues when the branch has been rebased to a version different from > master. Is this expected behavior? > > ~Rusty > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review in git with svn remote
On Sep 8, 2:14 pm, Rusty Burchfield <[EMAIL PROTECTED]> wrote: > Are there any other settings I need to change? Ah ha! I was testing on master, but you apparently have to be on a branch for it to work. I guess it is doing a diff against master. This seems to cause some issues when the branch has been rebased to a version different from master. Is this expected behavior? ~Rusty --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review in git with svn remote
On Sep 5, 6:32 pm, Rusty Burchfield <[EMAIL PROTECTED]> wrote:
> On Sep 5, 6:11 pm, Rusty Burchfield <[EMAIL PROTECTED]> wrote:
> > Any thoughts on what I am missing here?
>
> Ah. It is because I don't have any changes.
>
> $ post-review --output-diff
> None
OK, I have tried committing changes on a local branch without a
dcommit, and that still produces a "None" diff.
$ post-review -o
Traceback (most recent call last):
File "/home/rusty/scripts/post-review", line 1589, in
main(sys.argv[1:])
File "/home/rusty/scripts/post-review", line 1571, in main
submit_as=options.submit_as)
File "/home/rusty/scripts/post-review", line 1396, in tempt_fate
parent_diff_content)
File "/home/rusty/scripts/post-review", line 291, in upload_diff
debug("Uploading diff, size: %d" % len(diff_content))
If I don't unset GIT_EXTERNAL_DIFF the above will pop the diff in my
external viewer.
Are there any other settings I need to change?
~Rusty
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
