I'm definitely a Python noob, but don't mind digging around in the
code. I'm not familiar with python distributions and eggs, I assume I
can just unzip the RBTools egg and then rezip it? I'll give it a shot
when I have a free moment tomorrow and get back to you. Thanks again!
tony
On Sep 16,
Hmmm, so changing the regex allows post-review to detect perforce and
begin uploading. However, I ran into a second problem with the way
post-review is creating the repository url. I ended up just removing
the whole try block from get_repository_info in the PerforceClient
since it was picking up
Ahhh, crap, I'm an idiot. Forgot to put p4 on the path of my apache
user. Everything seems to be chill now. One final question: What is
the recommended way for distributing my local copy of the post-review
tool to the others on my team? I checked out the code from git
(release-0.2) as well.
Hi Tony,
We discourage running as root, so that wouldn't be it.
It's likely that it's failing to parse the server version info. Can you type
`p4 info` and show me the Server version: line, if it exists? If it
doesn't, that's useful to know too, and I'd like to know if there's an
equivalent line
Christian,
Thanks for the quick response. I figured as much for the root thing.
Realized after I sent the email that p4 wasn't on my path as root, so
that explains it anyway...
In terms of the p4 info the server version line is present:
Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601
Interesting. That's definitely the problem. post-review expects the version
information to be entirely numeric.
I don't know what your Python comfort level is, but if you edited
rbtools/rbtools/postreview.py and found the line that includes Server
version: , and modified it to look like:
m =
If you run p4 counters do you see the path to your RB server (in
http://server/reviewboard/ format) in the repository_path counter?
(If you have an older version of perforce the counter might have a
different syntax, but it should still be visible)
Dana Lacoste
-Original Message-
From:
I do not have p4 counter set, but I did specify the exact path in
my .reviewboardrc file.
On Aug 3, 1:30 pm, Dana Lacoste dlaco...@aperio.com wrote:
If you run p4 counters do you see the path to your RB server
(inhttp://server/reviewboard/format) in the repository_path counter?
(If you have
Repository info 'Path: salmon.hb-studios.local:1999, Base path: None,
Supports changesets: True'
Generating diff for changenum 79737
p4 describe -s 79737
Processing edit of
//NBA/Branches/Release/packages/bball/live/nba/nba-main/prints.cpp
Writing
