Re: rbt post fails with: AttributeError: Values instance has no attribute 'arbitrary_diff_file'

2018-08-07 Thread Avishek Neupane
The problem fixed itself. It seems like review board taking some time to recognize the repository. On Wednesday, August 1, 2018 at 2:08:00 PM UTC-7, David Trowbridge wrote: > > It looks like you have some custom amazon build of RBTools. It's pretty > old, and there's no "arbitrary_diff" client i

Re: rbt post fails with: AttributeError: Values instance has no attribute 'arbitrary_diff_file'

2018-08-01 Thread David Trowbridge
It looks like you have some custom amazon build of RBTools. It's pretty old, and there's no "arbitrary_diff" client in the upstream release. -David On Wed, Aug 1, 2018 at 2:06 PM Avishek Neupane wrote: > rbt post fails with: AttributeError: Values instance has no attribute > 'arbitrary_diff_fil

Re: rbt post fails with git cat-file: could not get object info

2018-01-08 Thread Christian Hammond
Hi Caroline, I'd be interested in seeing how you're handling keeping the clone active. I'm not sure what command he ran exactly, so I don't want to give the wrong advice for your setup. Does the clone exist solely for Review Board? Where does the main repository live? Christian On Mon, Jan 8, 2

Re: rbt post fails with git cat-file: could not get object info

2018-01-08 Thread Caroline
Hi, I have same issue here. Could you post your command of how to do reset here? Thanks C On Monday, March 6, 2017 at 7:04:02 AM UTC-8, Greg Burcher wrote: > > Thanks Christian. Our RB server keeps a local repository, and pulls via > cron job to stay current. When we checked that local repos

Re: rbt post fails with git cat-file: could not get object info

2017-03-06 Thread Christian Hammond
Hi Greg, Glad you were able to find the cause! Perhaps a force push caused that somewhere? Christian On Mon, Mar 6, 2017 at 07:04 Greg Burcher wrote: > Thanks Christian. Our RB server keeps a local repository, and pulls via > cron job to stay current. When we checked that local repository, th

Re: rbt post fails with git cat-file: could not get object info

2017-03-06 Thread Greg Burcher
Thanks Christian. Our RB server keeps a local repository, and pulls via cron job to stay current. When we checked that local repository, there were merge conflicts, so all the pulls had been failing for a few days. I have no idea why that repository would have merge conflicts, but we reset and

Re: rbt post fails with git cat-file: could not get object info

2017-03-03 Thread Christian Hammond
Hi Greg, Are older diffs in Review Board able to load? (Ones that would have fallen out of cache). I'm curious if this is something affecting only newer diffs. This is often due to changes on the Git repository. Mirroring may be failing, for instance, if this is a clone of the main repository. M

Re: rbt post fails for huge diff and "rbt post --diff-filename=" also fails

2016-03-23 Thread David Trowbridge
For perforce, we really don't have support for the second style of diff--everything should be the first (with the file revision included, rather than a timestamp). How did you end up with a diff file that has both styles in it?? -David On Wed, Mar 23, 2016 at 2:08 AM Subodh Konhor wrote: > Hi D

Re: rbt post fails for huge diff and "rbt post --diff-filename=" also fails

2016-03-23 Thread Subodh Konhor
Hi David, You are right. parse_diff_header is parsing the header incorrectly. I can state from a perforce diff point of view that it is incorrect. Reviewboard server code needs to be fixed Scenario: reviewboard/diffviewer/parser.py +169 def parse_diff_header if linenum + 1 < len(self.lines) an

Re: rbt post fails for huge diff and "rbt post --diff-filename=" also fails

2016-03-22 Thread David Trowbridge
I'm not super aware of your situation, but following a "process" just because even though it's ridiculous in extreme cases like this is absurd. There's no good reason why --diff-filename doesn't work with Perforce other than that it just hasn't been used. Passing in a diff file with perforce is ve

Re: rbt post fails for huge diff and "rbt post --diff-filename=" also fails

2016-03-22 Thread Subodh Konhor
I also do acknowledge that it is humanly impossible to review but we have a process of having review done for certain products before checkin is made. Therefore we post review. So yes we do post huge diffs and cannot do away with it. Command I ran to post the changenum is rbt post -d Error i

Re: rbt post fails for huge diff and "rbt post --diff-filename=" also fails

2016-03-22 Thread David Trowbridge
I'm not sure what's going on in the first couple tracebacks--somehow the diff headers aren't right. It would help if you included what command you ran to get that output. For the last traceback, it looks like there's some issues with perforce and 'rbt post --diff-filename' That said, a change with

Re: rbt post fails

2014-09-17 Thread MG
Thanks! That error message is not very helpful. On Wednesday, September 17, 2014 3:13:42 PM UTC-4, David Trowbridge wrote: > > The command-line syntax in rbt 0.6.x changed. To list files to include in > the diff, use the -I flag. > > -David > > On Sep 17, 2014, at 8:01 AM, MG > wrote: > > I have

Re: rbt post fails

2014-09-17 Thread David Trowbridge
The command-line syntax in rbt 0.6.x changed. To list files to include in the diff, use the -I flag. -David > On Sep 17, 2014, at 8:01 AM, MG wrote: > > I have a review board installation for a CVS repository on a server here, and > it has been working well. > > A new developer has just inst

Re: rbt post fails without manual fetch of git repo changes

2014-04-06 Thread Krzysztof Szynter
I had a similar problem few weeks ago. We have a RB working with git repositories, and they are on separate servers. In the end I've installed gitweb which solved issues with generating RR using rbt-post command. On Thursday, April 3, 2014 12:19:28 PM UTC+2, Tadeusz Kozak wrote: > > Answering my

Re: rbt post fails without manual fetch of git repo changes

2014-04-04 Thread Stephen Gallagher
On 04/03/2014 07:14 PM, Christian Hammond wrote: > That's why we recommend using something like cgit/gitweb on your main > git server instead. We can then use that to access the files we need > directly. > > This is all due to the lack of support for accessing individual files > through the Git pr

Re: rbt post fails without manual fetch of git repo changes

2014-04-03 Thread Christian Hammond
That's why we recommend using something like cgit/gitweb on your main git server instead. We can then use that to access the files we need directly. This is all due to the lack of support for accessing individual files through the Git protocol. Christian -- Christian Hammond - chip...@chipx86.c

Re: rbt post fails without manual fetch of git repo changes

2014-04-03 Thread Tadeusz Kozak
Answering my own question: http://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/#git In order to use Git with Review Board, you’ll need either a local clone on the server, or by using raw file URLs to a web front-end to Git (cgit, Gitweb, etc.) on the Git server. Git does