Re: Review Board 1.0.6 released
The new Djblets is out now, and should work around this problem. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Mar 28, 2010 at 1:21 PM, Christian Hammond wrote: > Hi, > > That's interesting. We haven't encountered this, and have been running with > this new code for a little while, but I'll go ahead and do a new Djblets > 0.5.9 release that guarantees we don't pass unicode strings to these cache > functions. Expect it within the hour. > > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Sun, Mar 28, 2010 at 4:23 AM, Vesterbaek wrote: > >> The problem looks similar to this old django bug: >> http://code.djangoproject.com/ticket/4845 >> >> I had a look in my /usr/local/lib/python2.6/dist-packages/Django-1.1.1- >> py2.6.egg/django/core/cache/backends/memcached.py >> >> In all functions, the key was wrapped by the django smart_str type, >> except for >> def incr(self, key, delta=1): >> return self._cache.incr(key, delta) >> def decr(self, key, delta=1): >>return self._cache.decr(key, delta) >> >> I changed these to >> def incr(self, key, delta=1): >>return self._cache.incr(smart_str(key), delta) >> >> def decr(self, key, delta=1): >>return self._cache.decr(smart_str(key), delta) >> >> .. the upgrade now runs fine -- just to learn no evolution was >> required :). >> >> -- Jeppe >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~--~~~~--~~--~--~--- >> To unsubscribe from this group, send email to >> reviewboard+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> >> To unsubscribe from this group, send email to reviewboard+ >> unsubscribegooglegroups.com or reply to this email with the words "REMOVE >> ME" as the subject. >> > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Re: Review Board 1.0.6 released
Hi, That's interesting. We haven't encountered this, and have been running with this new code for a little while, but I'll go ahead and do a new Djblets 0.5.9 release that guarantees we don't pass unicode strings to these cache functions. Expect it within the hour. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Mar 28, 2010 at 4:23 AM, Vesterbaek wrote: > The problem looks similar to this old django bug: > http://code.djangoproject.com/ticket/4845 > > I had a look in my /usr/local/lib/python2.6/dist-packages/Django-1.1.1- > py2.6.egg/django/core/cache/backends/memcached.py > > In all functions, the key was wrapped by the django smart_str type, > except for > def incr(self, key, delta=1): > return self._cache.incr(key, delta) > def decr(self, key, delta=1): >return self._cache.decr(key, delta) > > I changed these to > def incr(self, key, delta=1): >return self._cache.incr(smart_str(key), delta) > > def decr(self, key, delta=1): >return self._cache.decr(smart_str(key), delta) > > .. the upgrade now runs fine -- just to learn no evolution was > required :). > > -- Jeppe > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > > To unsubscribe from this group, send email to reviewboard+ > unsubscribegooglegroups.com or reply to this email with the words "REMOVE > ME" as the subject. > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Re: Review Board 1.0.6 released
The problem looks similar to this old django bug: http://code.djangoproject.com/ticket/4845 I had a look in my /usr/local/lib/python2.6/dist-packages/Django-1.1.1- py2.6.egg/django/core/cache/backends/memcached.py In all functions, the key was wrapped by the django smart_str type, except for def incr(self, key, delta=1): return self._cache.incr(key, delta) def decr(self, key, delta=1): return self._cache.decr(key, delta) I changed these to def incr(self, key, delta=1): return self._cache.incr(smart_str(key), delta) def decr(self, key, delta=1): return self._cache.decr(smart_str(key), delta) .. the upgrade now runs fine -- just to learn no evolution was required :). -- Jeppe -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
Re: Review Board 1.0.6 released
Hi Christian,
First, thanks for your continued efforts building review-board. Your
work is mush appreciated.
I've just tried upgrading my 1.0.5.1 installation to 1.0.6. There
seems to be a problem with django/memcached excepting plain 'str'-keys
and rb/django now using unicode?
b...@b49864:~$ sudo rb-site upgrade /var/www/reviewboard_a21/
Rebuilding directory structure
Updating database. This may take a while.
/var/lib/python-support/python2.6/MySQLdb/__init__.py:34:
DeprecationWarning: the sets module is deprecated
from sets import ImmutableSet
Upgrading Review Board from 1.0.5.1 to 1.0.6
Traceback (most recent call last):
File "/usr/local/bin/rb-site", line 8, in
load_entry_point('ReviewBoard==1.0.6', 'console_scripts', 'rb-
site')()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-
py2.6.egg/reviewboard/cmdline/rbsite.py", line 1487, in main
command.run()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-
py2.6.egg/reviewboard/cmdline/rbsite.py", line 1406, in run
site.sync_database()
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-
py2.6.egg/reviewboard/cmdline/rbsite.py", line 314, in sync_database
self.run_manage_command("syncdb", ["--noinput"])
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-
py2.6.egg/reviewboard/cmdline/rbsite.py", line 353, in
run_manage_command
execute_manager(reviewboard.settings, [__file__, cmd] + params)
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/management/__init__.py", line 362, in execute_manager
utility.execute()
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/management/__init__.py", line 303, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/management/base.py", line 195, in run_from_argv
self.execute(*args, **options.__dict__)
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/management/base.py", line 222, in execute
output = self.handle(*args, **options)
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/management/base.py", line 351, in handle
return self.handle_noargs(**options)
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/management/commands/syncdb.py", line 99, in handle_noargs
emit_post_sync_signal(created_models, verbosity, interactive)
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/management/sql.py", line 205, in emit_post_sync_signal
interactive=interactive)
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/dispatch/dispatcher.py", line 166, in send
response = receiver(signal=self, sender=sender, **named)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.6-
py2.6.egg/reviewboard/admin/management/sites.py", line 54, in
init_siteconfig
siteconfig.save()
File "/usr/local/lib/python2.6/dist-packages/Djblets-0.5.8-py2.6.egg/
djblets/siteconfig/models.py", line 120, in save
self._last_sync_gen = cache.incr(cache_key)
File "/usr/local/lib/python2.6/dist-packages/Django-1.1.1-py2.6.egg/
django/core/cache/backends/memcached.py", line 49, in incr
return self._cache.incr(key, delta)
File "/var/lib/python-support/python2.6/memcache.py", line 360, in
incr
return self._incrdecr("incr", key, delta)
File "/var/lib/python-support/python2.6/memcache.py", line 375, in
_incrdecr
check_key(key)
File "/var/lib/python-support/python2.6/memcache.py", line 878, in
check_key
raise Client.MemcachedStringEncodingError, ("Keys must be str()'s,
not"
memcache.MemcachedStringEncodingError: Keys must be str()'s,
notunicode. Convert your unicode strings using
mystring.encode(charset)!
-- Jeppe
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
To unsubscribe from this group, send email to
reviewboard+unsubscribegooglegroups.com or reply to this email with the words
"REMOVE ME" as the subject.
Review Board 1.0.6 released
Hi everyone, We just released Review Board 1.0.6, which contains what we think is a fix for the stale preferences issue, and greatly improves the performance and loading times of the Dashboard. More details are up at http://www.reviewboard.org/news/2010/03/27/review-board-106-released/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
