Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Comment #5 on issue 3446 by ke...@keithmoyer.com: ReviewRequestFieldsHook and email notfications https://code.google.com/p/reviewboard/issues/detail?id=3446 Any chance this will make it into Review Board 2.5? Not trying to rush it; just making sure it wasn't forgotten since you mentioned you'd like to add this functionality. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Comment #6 on issue 3446 by chip...@gmail.com: ReviewRequestFieldsHook and email notfications https://code.google.com/p/reviewboard/issues/detail?id=3446 Hi Keith, This bug has moved over to https://hellosplat.com/s/beanbag/tickets/3446/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Comment #4 on issue 3446 by nitesha...@gmail.com: ReviewRequestFieldsHook and email notfications https://code.google.com/p/reviewboard/issues/detail?id=3446 +1. Without this, I plan to just patch reviewboard/notifications/email.py and replace reviewboard/templates/notifications/review_request_email.html and reviewboard/templates/notifications/review_request_email.txt. Of course, this makes maintenance uglier. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: ReviewRequestFieldsHook
Hi Justin, For better or for worse, combo boxes aren’t available. I have shoehorned them into an extension, but it was not a fun process, at least for someone who hates working with JavaScript. You’ll need to extend one of the field classes (easy) and create a jQuery widget (tedious, painful, this is why I’m not a web developer). I would not recommend taking the approach I did of hijacking the existing inlineEditory widget; instead, I’d add a mechanism for selecting a different one. As a starting point, you’ll want to look in the jquery.gravy.inlineEditor.js file for an example of how to design a widget; the reviewRequestEditorView.js file is probably where you’ll need to do your widget integration. Fortunately, Review Board makes replacing the components via an extension possible. To override existing JavaScript, I copied the whole files I needed to modify into my extension and added them to the js_bundles property. I have a poorly-written comment, “Order might matter for this hack”, right above the list, so if you choose this path, keep that in mind. :) Hope this helps, Andrew From: Justin Palmer justinpalme...@gmail.commailto:justinpalme...@gmail.com Reply-To: reviewboard reviewboard@googlegroups.commailto:reviewboard@googlegroups.com Date: Thursday, January 15, 2015 at 10:53 To: reviewboard reviewboard@googlegroups.commailto:reviewboard@googlegroups.com Subject: ReviewRequestFieldsHook Thank you for this extension! Adding our own fields to track additional metadata is very important. https://www.reviewboard.org/docs/manual/2.0/extending/extensions/hooks/review-request-fields-hook/ class NotesField(BaseTextAreaField): Example is missing from reviewboard.reviews.fields import BaseTextAreaField. Would you mind adding examples for other fields? I tried looking up reviewboard.reviews.fields and I couldn't figure out how to add, for example, a combobox (option) field. I wrote my first Python yesterday when I downloaded rbseverity, replaced names and sections, ran 'python setup.py develop', restarted httpd, and enabled extension in Review Board. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.commailto:reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
ReviewRequestFieldsHook
Thank you for this extension! Adding our own fields to track additional metadata is very important. https://www.reviewboard.org/docs/manual/2.0/extending/extensions/hooks/review-request-fields-hook/ class NotesField(BaseTextAreaField): Example is missing from reviewboard.reviews.fields import BaseTextAreaField . Would you mind adding examples for other fields? I tried looking up reviewboard.reviews.fields and I couldn't figure out how to add, for example, a combobox (option) field. I wrote my first Python yesterday when I downloaded rbseverity, replaced names and sections, ran 'python setup.py develop', restarted httpd, and enabled extension in Review Board. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Updates: Labels: Project-ReviewBoard Component-Extensions Component-EMail Comment #3 on issue 3446 by trowb...@gmail.com: ReviewRequestFieldsHook and email notfications http://code.google.com/p/reviewboard/issues/detail?id=3446 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Updates: Labels: Milestone-Extensions Comment #1 on issue 3446 by chip...@gmail.com: ReviewRequestFieldsHook and email notfications http://code.google.com/p/reviewboard/issues/detail?id=3446 This is something I'd like to add. E-mails are a bit tricky, though, so we wouldn't necessarily be able to use the exact rendered value, but could probably just add a new method for getting a render for e-mail purposes that falls back on the standard rendered value. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Updates: Status: Confirmed Comment #2 on issue 3446 by chip...@gmail.com: ReviewRequestFieldsHook and email notfications http://code.google.com/p/reviewboard/issues/detail?id=3446 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3446 by ke...@keithmoyer.com: ReviewRequestFieldsHook and email notfications http://code.google.com/p/reviewboard/issues/detail?id=3446 What version are you running? 2.0.2 What's the URL of the page this enhancement relates to, if any? email notifications Describe the enhancement and the motivation for it. ReviewBoard 2.0 added extensibility for adding custom fields to a review request. We've embraced that and included a couple of important-to-us fields. It would fantastic if our field hook could also indicate to be included in the various review request notification emails, alongside the description, testing, diffs, bugs, etc. What operating system are you using? What browser? Windows 7, Firefox 29 Please provide any additional information below. The rendered value would be preferred over the text value of the field. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
