Re: The searching order of .reviewboardrc changes in rbtools 0.6.x

2015-03-02 Thread David Trowbridge
Hi,

This is a bug, and we'll get a fix in soon.

-David

On Thu, Feb 26, 2015 at 6:51 PM Xy Sui  wrote:

> Hi,
>
>
>
> I just found that’s another change without compatibility after rbtools
> upgrade.
>
> In rbtools 0.5.x, the order to search one config in all .reviewboardrc
> files is from the deepest layer to the top (3 , 2, 1),  and the
> .reviewboardrc under home is the last one
>
> *Dir_1st_Layer*
> ├── *Dir_2nd_Layer*
> │   ├── *Dir_3rd_Layer*
> │   │   └── .reviewboardrc
> │   └── .reviewboardrc
> └── .reviewboardrc
>
>
>
> Now, with rbtools 0.6.x, the order is converse and .reviewboardrc under
> home goes firstly.
>
> I checked the code just now and found one function *load_config_files*
> was used in old postreview .py to load settings, and now that function is
> still there but since postreview.py is gone…
>
> Personally, I like the old searching way because the .reviewboardrc in
> each repository should be considered firstly rather the one under home.
>
> Can anybody confirm if it's one bug or we have live with it from rbtools
> 0.6.x?
>
> Thanks.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


The searching order of .reviewboardrc changes in rbtools 0.6.x

2015-02-26 Thread Xy Sui
 

Hi,

 

I just found that’s another change without compatibility after rbtools 
upgrade.

In rbtools 0.5.x, the order to search one config in all .reviewboardrc 
files is from the deepest layer to the top (3 , 2, 1),  and the 
.reviewboardrc under home is the last one

*Dir_1st_Layer*
├── *Dir_2nd_Layer*
│   ├── *Dir_3rd_Layer*
│   │   └── .reviewboardrc
│   └── .reviewboardrc 
└── .reviewboardrc  

 

Now, with rbtools 0.6.x, the order is converse and .reviewboardrc under 
home goes firstly.

I checked the code just now and found one function *load_config_files* was 
used in old postreview .py to load settings, and now that function is still 
there but since postreview.py is gone…

Personally, I like the old searching way because the .reviewboardrc in each 
repository should be considered firstly rather the one under home.

Can anybody confirm if it's one bug or we have live with it from rbtools 
0.6.x?

Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.