Re: Uploading a internally generated diff file

2009-10-05 Thread Sujith

Thanks for the post-review link. This seems to be really useful I'll
go through it and let you know in case of further problems.

Another thing which I wanted to implement is to add a new button on
new-review-request page and write a python function that would
execute on its click. Can you provide me some help in how to go about
it.

Thanks
Sujith

On Oct 2, 1:02 am, Christian Hammond chip...@chipx86.com wrote:
 Hi,

 I'm not really sure I understand what you mean by an internally generated
 diff and a constant name and path.

 Have you looked into using post-review? We generally recommend this over the
 New Review Request page.

 http://review-board.org/docs/manual/dev/users/tools/post-review/

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.review-board.org
 VMware, Inc. -http://www.vmware.com

 On Thu, Oct 1, 2009 at 3:37 AM, Sujith sujith...@gmail.com wrote:

  Hello ,

  When I click on New review request I get an option of uploading file
  by browsing. Now I have a slightly different requirement I want
  reviewboard to upload and internally generated diff file which would
  have a constant name and path. Can this be done?

  I have a decent understanding of Django and python. I' ll be grateful
  if anybody could guide me how to go about it Or if any of you can
  point me to any useful link.

  Thanks
  Sujith

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Uploading a internally generated diff file

2009-10-05 Thread Christian Hammond
Well, you'd have to become familiar with the Django templates (not a ton of
work), and how Django handles forms. Then you'd have to write custom code in
our form for whatever you're looking to do.

The templates are in reviewboard/templates/reviews, and the form code is in
reviewboard/reviews/forms.py.

I will warn you though that any changes you make to a live tree will be lost
in an upgrade. If you really want to maintain a custom build of Review Board
for this, you'll want to set up a fork on GitHub and keep it up-to-date,
building your own releases from there. For more information on that, see
http://www.review-board.org/docs/codebase/dev/custom-forks/

What would this button do?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Oct 5, 2009 at 1:37 AM, Sujith sujith...@gmail.com wrote:


 Thanks for the post-review link. This seems to be really useful I'll
 go through it and let you know in case of further problems.

 Another thing which I wanted to implement is to add a new button on
 new-review-request page and write a python function that would
 execute on its click. Can you provide me some help in how to go about
 it.

 Thanks
 Sujith

 On Oct 2, 1:02 am, Christian Hammond chip...@chipx86.com wrote:
  Hi,
 
  I'm not really sure I understand what you mean by an internally generated
  diff and a constant name and path.
 
  Have you looked into using post-review? We generally recommend this over
 the
  New Review Request page.
 
  http://review-board.org/docs/manual/dev/users/tools/post-review/
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.review-board.org
  VMware, Inc. -http://www.vmware.com
 
  On Thu, Oct 1, 2009 at 3:37 AM, Sujith sujith...@gmail.com wrote:
 
   Hello ,
 
   When I click on New review request I get an option of uploading file
   by browsing. Now I have a slightly different requirement I want
   reviewboard to upload and internally generated diff file which would
   have a constant name and path. Can this be done?
 
   I have a decent understanding of Django and python. I' ll be grateful
   if anybody could guide me how to go about it Or if any of you can
   point me to any useful link.
 
   Thanks
   Sujith

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Uploading a internally generated diff file

2009-10-01 Thread Sujith

Hello ,

When I click on New review request I get an option of uploading file
by browsing. Now I have a slightly different requirement I want
reviewboard to upload and internally generated diff file which would
have a constant name and path. Can this be done?

I have a decent understanding of Django and python. I' ll be grateful
if anybody could guide me how to go about it Or if any of you can
point me to any useful link.

Thanks
Sujith

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Uploading a internally generated diff file

2009-10-01 Thread Christian Hammond
Hi,

I'm not really sure I understand what you mean by an internally generated
diff and a constant name and path.

Have you looked into using post-review? We generally recommend this over the
New Review Request page.

http://review-board.org/docs/manual/dev/users/tools/post-review/

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Thu, Oct 1, 2009 at 3:37 AM, Sujith sujith...@gmail.com wrote:


 Hello ,

 When I click on New review request I get an option of uploading file
 by browsing. Now I have a slightly different requirement I want
 reviewboard to upload and internally generated diff file which would
 have a constant name and path. Can this be done?

 I have a decent understanding of Django and python. I' ll be grateful
 if anybody could guide me how to go about it Or if any of you can
 point me to any useful link.

 Thanks
 Sujith

 


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---