git short hashes cannot work with remote repository

2013-02-25 Thread agentm
Hello, we have encountered what seems to be a bug in both reviewboard and 
cgit when using rb with a remote git repo via cgit. This is due to a 
migration from local to remote git repos.

Some of our reviews include short git hashes (from uploaded diffs, I 
assume), which rb then complains about:

Diff currently unavailable. *Error:* The revision '1be9c1d' for 'abc isn't 
in a valid format: The SHA1 is too short. Make sure the diff is generated 
with `git diff --full-index`.

I thought this might be easy to fix in rb, but it seems cgit blows up (500) 
on the short hashes, too. 

So, it looks like I have three options:

1) hack rb and cgit to support short hashes
2) use local repos again
3) expand the short hashes to full hashes in the database

Unless there are other suggestions, I would like to investigate option 3. 
Could someone point me to which table in the database I should be looking 
at?

Cheers,
M

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: git short hashes cannot work with remote repository

2013-02-25 Thread David Trowbridge
You'd want to look at the source_revision field in the diffviewer_filediff
table. Alternatively, if you'd like to do it with a management command or
the django shell, it's the source_revision field in the
reviewboard.diffviewer.models.FileDiff model.


-David


On Mon, Feb 25, 2013 at 12:57 PM, age...@themactionfaction.com wrote:

 Hello, we have encountered what seems to be a bug in both reviewboard and
 cgit when using rb with a remote git repo via cgit. This is due to a
 migration from local to remote git repos.

 Some of our reviews include short git hashes (from uploaded diffs, I
 assume), which rb then complains about:

 Diff currently unavailable. *Error:* The revision '1be9c1d' for 'abc
 isn't in a valid format: The SHA1 is too short. Make sure the diff is
 generated with `git diff --full-index`.

 I thought this might be easy to fix in rb, but it seems cgit blows up
 (500) on the short hashes, too.

 So, it looks like I have three options:

 1) hack rb and cgit to support short hashes
 2) use local repos again
 3) expand the short hashes to full hashes in the database

 Unless there are other suggestions, I would like to investigate option 3.
 Could someone point me to which table in the database I should be looking
 at?

 Cheers,
 M

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.