Re: svn question

2010-12-10 Thread Ovidiu Deac
Hi again,

I'm back with more details on this issue.

So the problem is the following: if I upload an svn diff with new
files only everything works fine but if I upload an svn diff which
contains existing files rb complains saying that the files don't exist

I added a couple of logs in scmtools/svn.py in the method get_file to
see what file is it trying to load and my conclusion is that it alters
the path

The original path is https://server.com/my/path/containing%20spaces
and the file that rb is trying to get is:
/my/!svn/bc/40858/path/containing%2520spaces

So the difference is that !svn/bc/40858 part and the %20 is transformed in %2520

ovidiu

On Thu, Dec 9, 2010 at 4:29 PM, Ovidiu Deac  wrote:
> I must have done something wrong before because I did it again and now
> it works. It's funny that I did the same mistake several times.
>
> Anyway it's good that it works. Thanks!
>
> On Thu, Dec 9, 2010 at 8:36 AM, Ovidiu Deac  wrote:
>> The diff was generated by running "svn diff" in the root of the svn
>> repository which i checked out.
>>
>> I checked out the sources like this:
>>
>> $ svn co https://server/mydir
>>
>> $ cd mydir
>>
>> ...change the file
>>
>> $ svn diff > changes.diff
>>
>> ...then upload the diff in RB
>>
>> ovidiu
>>
>> On Thu, Dec 9, 2010 at 6:24 AM, Christian Hammond  
>> wrote:
>>> Does your SVN configuration point to the very root of the SVN repository?
>>>
>>> DId you generate the diff yourself, or use post-review?
>>>
>>> Was the diff generated in the root of the repository, or some
>>> subdirectory (say, /trunk/something/)? Did you pass a Base Path?
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond - chip...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com
>>>
>>>
>>>
>>> On Tue, Dec 7, 2010 at 7:12 AM, Ovidiu Deac  wrote:
 Hi,

 I've just installed rb on a machine, configured an svn repository and
 when I tried to post a diff I got this message:

 "The file '/test.txt' (r40691) could not be found in the repository"

 Any idea about what is wrong?

 thanks,
 ovidiu

 --
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en
>>>
>>> --
>>> Want to help the Review Board project? Donate today at 
>>> http://www.reviewboard.org/donate/
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> -~--~~~~--~~--~--~---
>>> To unsubscribe from this group, send email to 
>>> reviewboard+unsubscr...@googlegroups.com
>>> For more options, visit this group at 
>>> http://groups.google.com/group/reviewboard?hl=en
>>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: svn question

2010-12-09 Thread Ovidiu Deac
I must have done something wrong before because I did it again and now
it works. It's funny that I did the same mistake several times.

Anyway it's good that it works. Thanks!

On Thu, Dec 9, 2010 at 8:36 AM, Ovidiu Deac  wrote:
> The diff was generated by running "svn diff" in the root of the svn
> repository which i checked out.
>
> I checked out the sources like this:
>
> $ svn co https://server/mydir
>
> $ cd mydir
>
> ...change the file
>
> $ svn diff > changes.diff
>
> ...then upload the diff in RB
>
> ovidiu
>
> On Thu, Dec 9, 2010 at 6:24 AM, Christian Hammond  wrote:
>> Does your SVN configuration point to the very root of the SVN repository?
>>
>> DId you generate the diff yourself, or use post-review?
>>
>> Was the diff generated in the root of the repository, or some
>> subdirectory (say, /trunk/something/)? Did you pass a Base Path?
>>
>> Christian
>>
>> --
>> Christian Hammond - chip...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>>
>> On Tue, Dec 7, 2010 at 7:12 AM, Ovidiu Deac  wrote:
>>> Hi,
>>>
>>> I've just installed rb on a machine, configured an svn repository and
>>> when I tried to post a diff I got this message:
>>>
>>> "The file '/test.txt' (r40691) could not be found in the repository"
>>>
>>> Any idea about what is wrong?
>>>
>>> thanks,
>>> ovidiu
>>>
>>> --
>>> Want to help the Review Board project? Donate today at 
>>> http://www.reviewboard.org/donate/
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> -~--~~~~--~~--~--~---
>>> To unsubscribe from this group, send email to 
>>> reviewboard+unsubscr...@googlegroups.com
>>> For more options, visit this group at 
>>> http://groups.google.com/group/reviewboard?hl=en
>>
>> --
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: svn question

2010-12-08 Thread Ovidiu Deac
The diff was generated by running "svn diff" in the root of the svn
repository which i checked out.

I checked out the sources like this:

$ svn co https://server/mydir

$ cd mydir

...change the file

$ svn diff > changes.diff

...then upload the diff in RB

ovidiu

On Thu, Dec 9, 2010 at 6:24 AM, Christian Hammond  wrote:
> Does your SVN configuration point to the very root of the SVN repository?
>
> DId you generate the diff yourself, or use post-review?
>
> Was the diff generated in the root of the repository, or some
> subdirectory (say, /trunk/something/)? Did you pass a Base Path?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
>
> On Tue, Dec 7, 2010 at 7:12 AM, Ovidiu Deac  wrote:
>> Hi,
>>
>> I've just installed rb on a machine, configured an svn repository and
>> when I tried to post a diff I got this message:
>>
>> "The file '/test.txt' (r40691) could not be found in the repository"
>>
>> Any idea about what is wrong?
>>
>> thanks,
>> ovidiu
>>
>> --
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard+unsubscr...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>
> --
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: svn question

2010-12-08 Thread Christian Hammond
Does your SVN configuration point to the very root of the SVN repository?

DId you generate the diff yourself, or use post-review?

Was the diff generated in the root of the repository, or some
subdirectory (say, /trunk/something/)? Did you pass a Base Path?

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Tue, Dec 7, 2010 at 7:12 AM, Ovidiu Deac  wrote:
> Hi,
>
> I've just installed rb on a machine, configured an svn repository and
> when I tried to post a diff I got this message:
>
> "The file '/test.txt' (r40691) could not be found in the repository"
>
> Any idea about what is wrong?
>
> thanks,
> ovidiu
>
> --
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


svn question

2010-12-07 Thread Ovidiu Deac
Hi,

I've just installed rb on a machine, configured an svn repository and
when I tried to post a diff I got this message:

"The file '/test.txt' (r40691) could not be found in the repository"

Any idea about what is wrong?

thanks,
ovidiu

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en