Re: when will reviewboard push the code to the server
Thank you very much for your help. Then after reviewing the code, I have to push the patch manually? On 8月29日, 上午2时31分, Christian Hammond wrote: > Review Board's purpose is to review code. It stays out of the business of > managing code in a repository. It won't submit/merge code in. That's up to > the developer. > > There are a few reasons for this. > > 1. We'd need to keep user credentials/keys for each user in order to submit > for them. That's a security risk on multiple levels, and we don't want to do > that. > > 2. How submission works varies greatly by repositories type. On Git, we'd > need a working clone server-side, and the proper branch to place it in. We > don't have those. > > 3. We in general want to focus on review and not act as the one true > interface for committing code. It's just not part of our goals. > > Christian > > On Aug 28, 2012, at 8:21, zhihang wang wrote: > > > > > > > > > My git repos are managed by gitolite. > > I have installed gitweb on the server so that reviewboard can access > > the repos. > > But when I click submit in reviewboard to submit a patch to the > > server, the server sees doesn't receive this patch. > > I clone the repo from another machine. The patch is not uploaded. > > Why? > > Would someone like to help? > > > Thanks in advance! > > > -- > > Want to help the Review Board project? Donate today > > athttp://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group > > athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: when will reviewboard push the code to the server
Review Board's purpose is to review code. It stays out of the business of managing code in a repository. It won't submit/merge code in. That's up to the developer. There are a few reasons for this. 1. We'd need to keep user credentials/keys for each user in order to submit for them. That's a security risk on multiple levels, and we don't want to do that. 2. How submission works varies greatly by repositories type. On Git, we'd need a working clone server-side, and the proper branch to place it in. We don't have those. 3. We in general want to focus on review and not act as the one true interface for committing code. It's just not part of our goals. Christian On Aug 28, 2012, at 8:21, zhihang wang wrote: > My git repos are managed by gitolite. > I have installed gitweb on the server so that reviewboard can access > the repos. > But when I click submit in reviewboard to submit a patch to the > server, the server sees doesn't receive this patch. > I clone the repo from another machine. The patch is not uploaded. > Why? > Would someone like to help? > > Thanks in advance! > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
when will reviewboard push the code to the server
My git repos are managed by gitolite. I have installed gitweb on the server so that reviewboard can access the repos. But when I click submit in reviewboard to submit a patch to the server, the server sees doesn't receive this patch. I clone the repo from another machine. The patch is not uploaded. Why? Would someone like to help? Thanks in advance! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
