Re: Review Request 49659: Update config update message for Activate HAWQ Standby wizard

2016-07-05 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49659/#review140947 --- Ship it! Ship It! - Lav Jain On July 5, 2016, 9:39 p.m.,

Re: Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-07-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48855/#review140924 --- Ship it! Ship It! - Alejandro Fernandez On July 5, 2016,

Re: Review Request 49677: YARN Summary Panel shows ResourceManager heap incorrectly

2016-07-05 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49677/#review140923 --- Ship it! Ship It! - Zhe (Joe) Wang On July 6, 2016, 1:13

Review Request 49676: Add atlas-application config sections to all services that run Atlas hook, e.g., Hive, Falcon, Storm, Sqoop

2016-07-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49676/ --- Review request for Ambari, Robert Levas, Sumit Mohanty, and Swapan Shridhar.

Review Request 49677: YARN Summary Panel shows ResourceManager heap incorrectly

2016-07-05 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49677/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17574

Re: Review Request 49664: HDFS Summary Panel is not showing the NameNode heap size correctly

2016-07-05 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49664/#review140893 --- Ship it! Ship It! - Zhe (Joe) Wang On July 5, 2016, 11:10

Review Request 49664: HDFS Summary Panel is not showing the NameNode heap size correctly

2016-07-05 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49664/ --- Review request for Ambari, Zhe (Joe) Wang and Xi Wang. Bugs: AMBARI-17572

Review Request 49665: authorizer.class.name not being set on secure kafka clusters

2016-07-05 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49665/ --- Review request for Ambari, Alejandro Fernandez, Srimanth Gunturi, Tim Thorpe,

Review Request 49662: Show gpadmin as hawq service account user on Ambari

2016-07-05 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49662/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs:

Review Request 49659: Update config update message for Activate HAWQ Standby wizard

2016-07-05 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49659/ --- Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. Bugs:

Re: Review Request 49249: AMBARI-17445: Storm metrics sink: expand metrics name to contain additional informations

2016-07-05 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49249/#review140873 --- Ship it! Ship It! - Aravindan Vijayan On July 4, 2016,

Re: Review Request 49645: With wire-encryption enabled, quick links in ambari UI points to incorrect atlas web url

2016-07-05 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49645/#review140870 --- Ship it! Ship It! - Zhe (Joe) Wang On July 5, 2016, 6:42

Re: Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-07-05 Thread Di Li
> On July 5, 2016, 6:01 p.m., Alejandro Fernandez wrote: > > ambari-web/app/controllers/global/cluster_controller.js, line 309 > > > > > > If an upgrade is paused, I believe the state will be ABORTED. Try > >

Re: Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-07-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48855/ --- (Updated July 5, 2016, 7:53 p.m.) Review request for Ambari, Alejandro

Re: Review Request 48628: AMBARI-17184: HBase doesn't start because of lacking of variable

2016-07-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48628/#review140861 --- Ship it! Ship It! - Sid Wagle On July 5, 2016, 4:38 a.m.,

Re: Review Request 49590: While changing NN, DN directories from UI, proper warning should be present for invalid values

2016-07-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49590/#review140859 ---

Re: Review Request 48973: AMBARI-17234. kafka should set zookeeper.set.acl to true when kerberos enabled

2016-07-05 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48973/#review140857 --- Ship it! Ship It! - Robert Levas On June 20, 2016, 6:47

Re: Review Request 48999: Fix Spark2 history server quick link still point to spark1 url

2016-07-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48999/#review140852 --- Ship it! Ship It! - Alejandro Fernandez On June 21, 2016,

Review Request 49645: With wire-encryption enabled, quick links in ambari UI points to incorrect atlas web url

2016-07-05 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49645/ --- Review request for Ambari, Alejandro Fernandez, Zhe (Joe) Wang, and Yusaku Sako.

Re: Review Request 49295: remove spark.driver.extraJavaOptions and spark.yarn.am.extraJavaOptions property in HDP2.5 definition

2016-07-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49295/#review140838 ---

Re: Review Request 48971: AMBARI-17291 zookeeper.quorum in storm-metrics2.properties is broken

2016-07-05 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48971/ --- (Updated July 5, 2016, 6:20 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48971: AMBARI-17291 zookeeper.quorum in storm-metrics2.properties is broken

2016-07-05 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48971/ --- (Updated July 5, 2016, 6:16 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 49507: AMBARI-17520: Update the policy_user property to use storm user principal specified in Storms config

2016-07-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49507/#review140828 --- Ship it! Ship It! - Alejandro Fernandez On July 5, 2016,

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/#review140827 --- Ship it! Ship It! - Jonathan Hurley On July 5, 2016, 12:29

Re: Review Request 49535: Ambari Agent memory Leak fix.

2016-07-05 Thread Jonathan Hurley
> On July 5, 2016, 9:22 a.m., Jonathan Hurley wrote: > > I don't see how this actually fixes the problem; importing gc from > > subprocess would be the same as importing it normally, no? There isn't a > > different gc module that subprocess uses. Also, after you patch it, you > > then

Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack

2016-07-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/#review140825 --- Ship it! Ship It! - Jayush Luniya On June 30, 2016, 11:48

Re: Review Request 49328: AMBARI-17465 - Management packs should be able to install extensions

2016-07-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49328/#review140824 ---

Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

2016-07-05 Thread Prajwal Rao
> On June 24, 2016, 4:54 p.m., Prajwal Rao wrote: > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js, lines > > 128-133 > > > > > > All graphs on HBase-Users have legend hidden. > > > >

Re: Review Request 48855: AMBARI-12697 Rolling upgrade: Ambari UI should be able to display rolling upgrade history

2016-07-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48855/ --- (Updated July 5, 2016, 5:07 p.m.) Review request for Ambari, Alejandro

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/#review140813 --- Ship it! Ship It! - Nate Cole On July 5, 2016, 12:29 p.m.,

Re: Review Request 49618: Hive WebHCat Service Check Fails During Upgrade Due To Missing Configurations Files

2016-07-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49618/#review140812 --- Ship it! Ship It! - Nate Cole On July 4, 2016, 9:02 p.m.,

Re: Review Request 49597: true was removed from stack definition

2016-07-05 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49597/#review140809 --- Ship it! Ship It! - Sumit Mohanty On July 5, 2016, 3:02

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/ --- (Updated July 5, 2016, 7:29 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 49626: NN HA enabling failed at 'Stop all Services' step

2016-07-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49626/#review140805 --- Ship it! Ship It! - Alejandro Fernandez On July 5, 2016, 11

Re: Review Request 49385: Hive and Oozie db displayed incorrectly on the installer review page

2016-07-05 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49385/#review140804 --- Ship it! Ship It! - Andrii Tkach On June 30, 2016, 8:57

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/#review140803 --- Ship it! Ship It! - Alejandro Fernandez On July 5, 2016,

Re: Review Request 49590: While changing NN, DN directories from UI, proper warning should be present for invalid values

2016-07-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49590/#review140801 ---

Re: Review Request 49590: While changing NN, DN directories from UI, proper warning should be present for invalid values

2016-07-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49590/#review140798 --- Ship it! Ship It! - Sid Wagle On July 5, 2016, 2:38 p.m.,

Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, and Sumit Mohanty.

Re: Review Request 49626: NN HA enabling failed at 'Stop all Services' step

2016-07-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49626/#review140797 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 5,

Re: Review Request 49597: true was removed from stack definition

2016-07-05 Thread Dmitro Lisnichenko
> On July 4, 2016, 10:09 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml, > > line 144 > > > > > > Can we say - or simply keep it > >

Re: Review Request 49597: true was removed from stack definition

2016-07-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49597/ --- (Updated July 5, 2016, 6:02 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 49507: AMBARI-17520: Update the policy_user property to use storm user principal specified in Storms config

2016-07-05 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49507/#review140788 --- Ship it! Ship It! - Robert Levas On July 5, 2016, 9:01

Re: Review Request 49393: Incorrect error message for view URL name and short URL validation

2016-07-05 Thread Alexandr Antonenko
> On July 5, 2016, 2:23 p.m., Alexandr Antonenko wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Alexandr. Can you help commit the change. done - Alexandr --- This is an automatically generated e-mail. To reply,

Re: Review Request 49597: true was removed from stack definition

2016-07-05 Thread Sumit Mohanty
> On July 4, 2016, 7:09 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml, > > line 144 > > > > > > Can we say - or simply keep it > >

Re: Review Request 49393: Incorrect error message for view URL name and short URL validation

2016-07-05 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49393/#review140777 --- Ship it! Ship It! - Alexandr Antonenko On June 29, 2016,

Re: Review Request 49597: true was removed from stack definition

2016-07-05 Thread Dmitro Lisnichenko
> On July 4, 2016, 10:09 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml, > > line 144 > > > > > > Can we say - or simply keep it > >

Review Request 49637: Zeppelin: service install failure on Suse due to bash error

2016-07-05 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49637/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar,

Re: Review Request 49597: true was removed from stack definition

2016-07-05 Thread Sumit Mohanty
> On July 4, 2016, 7:09 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml, > > line 144 > > > > > > Can we say - or simply keep it > >

Re: Review Request 49635: Enable simulating logfeeder inputs

2016-07-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49635/#review140772 --- Ship it! Ship It! - Oliver Szabo On July 5, 2016, 1:57

Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack

2016-07-05 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/#review140771 --- Ship it! Ship It! - Sebastian Toader On June 30, 2016, 1:48

Review Request 49635: Enable simulating logfeeder inputs

2016-07-05 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49635/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 49535: Ambari Agent memory Leak fix.

2016-07-05 Thread Andrew Onischuk
> On July 5, 2016, 1:22 p.m., Jonathan Hurley wrote: > > I don't see how this actually fixes the problem; importing gc from > > subprocess would be the same as importing it normally, no? There isn't a > > different gc module that subprocess uses. Also, after you patch it, you > > then

Re: Review Request 49535: Ambari Agent memory Leak fix.

2016-07-05 Thread Andrew Onischuk
> On July 5, 2016, 1:22 p.m., Jonathan Hurley wrote: > > I don't see how this actually fixes the problem; importing gc from > > subprocess would be the same as importing it normally, no? There isn't a > > different gc module that subprocess uses. Also, after you patch it, you > > then

Re: Review Request 49535: Ambari Agent memory Leak fix.

2016-07-05 Thread Andrew Onischuk
> On July 5, 2016, 1:22 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/main.py, lines 30-31 > > > > > > I don't think that subprocess has a different version of gc than normal > > python

Re: Review Request 49535: Ambari Agent memory Leak fix.

2016-07-05 Thread Andrew Onischuk
> On July 5, 2016, 1:22 p.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/main.py, lines 30-31 > > > > > > I don't think that subprocess has a different version of gc than normal > > python

Re: Review Request 49535: Ambari Agent memory Leak fix.

2016-07-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49535/#review140761 --- I don't see how this actually fixes the problem; importing gc

Re: Review Request 49507: AMBARI-17520: Update the policy_user property to use storm user principal specified in Storms config

2016-07-05 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49507/ --- (Updated July 5, 2016, 1:01 p.m.) Review request for Ambari, Alejandro

Re: Review Request 49393: Incorrect error message for view URL name and short URL validation

2016-07-05 Thread Sangeeta Ravindran
> On June 29, 2016, 7:35 p.m., Di Li wrote: > > Ship It! Thanks Di. Hi Alexander, can you please review the changes? Thanks, Sangeeta - Sangeeta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49385: Hive and Oozie db displayed incorrectly on the installer review page

2016-07-05 Thread Sangeeta Ravindran
> On June 30, 2016, 10:52 a.m., Andrii Tkach wrote: > > Hello Andrii, I have updated the patch with the changes suggested. Can you please review the changes. Thanks, Sangeeta - Sangeeta --- This is an automatically generated e-mail.

Re: Review Request 49626: NN HA enabling failed at 'Stop all Services' step

2016-07-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49626/#review140756 --- Ship it! Ship It! - Dmitro Lisnichenko On July 5, 2016, 2

Re: Review Request 49594: 'Restart all' services fails due to dependency on other service components

2016-07-05 Thread Dmytro Sen
> On Июль 4, 2016, 3 п.п., Andrew Onischuk wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json, > > line 46 > > > > > > is this just duplicating 'start' dependencies? Shouldn't we

Re: Review Request 49521: Move service advisor tests for HAWQ and PXF

2016-07-05 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49521/#review140754 --- Ship it! Ship It! - Tim Thorpe On July 4, 2016, 12:33 a.m.,

Review Request 49626: NN HA enabling failed at 'Stop all Services' step

2016-07-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49626/ --- Review request for Ambari and Myroslav Papirkovskyy. Bugs: AMBARI-17559

Re: Review Request 49597: true was removed from stack definition

2016-07-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49597/#review140742 ---