Re: Review Request 49972: Check znode exits with retry during logsearch server setup too (for blueprints)

2016-07-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49972/#review142020 --- Ship it! Ship It! - Sebastian Toader On July 13, 2016, 1:57

Re: Review Request 49977: Zeppelin service: Remove sample notebook downloading shell script

2016-07-12 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49977/#review142017 --- Ship it! Ship It! - Gaurav Nagar On July 13, 2016, 5:38 a.m.

Re: Review Request 49977: Zeppelin service: Remove sample notebook downloading shell script

2016-07-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49977/#review142016 --- Ship it! Ship It! - Pallav Kulshreshtha On July 13, 2016, 5:

Re: Review Request 49897: AMBARI-17617: Set default log level for Ranger KMS to INFO

2016-07-12 Thread Gautam Borad
> On July 13, 2016, 12:25 a.m., Jonathan Hurley wrote: > > So you changed the default level from ALL to INFO ... but you could still > > setup a rolling file appender, right? Wouldn't that also help to curb the > > size of the log file? What if a customer increases the log level for some > > r

Re: Review Request 49977: Zeppelin service: Remove sample notebook downloading shell script

2016-07-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49977/#review142012 --- Ship it! Ship It! - Sumit Mohanty On July 13, 2016, 5:38 a.m

Review Request 49977: Zeppelin service: Remove sample notebook downloading shell script

2016-07-12 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49977/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar,

Re: Review Request 49974: Zeppelin service: wrong principal format in zeppelin kerberos.json

2016-07-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49974/#review142001 --- Ship it! Ship It! - Sumit Mohanty On July 13, 2016, 4:05 a.m

Review Request 49974: Zeppelin service: wrong principal format in zeppelin kerberos.json

2016-07-12 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49974/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar,

Re: Review Request 49971: Misc Atlas fixes, remove conf dir from classpath of Falcon and Storm in HDP 2.5, add more security properties to Atlas Hooks, and delete deprecated configs

2016-07-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49971/#review141996 --- Ship it! Ship It! - Sumit Mohanty On July 12, 2016, 11 p.m.,

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48972/#review141993 --- Ship it! I'm going to +1 this, but I'd still like to know how o

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-12 Thread Jonathan Hurley
> On July 11, 2016, 5:51 p.m., Masahiro Tanaka wrote: > > Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0? That depends; there's no Fix Version on this Jira, so I don't know if it's only going into trunk or if it's going to into branch-2.4. If you get approval to put

Re: Review Request 49640: Identify config changes added to Ambari-2.4.0 and mark them to not get added during Ambari upgrade

2016-07-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49640/#review141990 --- Ship it! Have you tested this in an upgrade scenario to ensure

Re: Review Request 49897: AMBARI-17617: Set default log level for Ranger KMS to INFO

2016-07-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49897/#review141988 --- So you changed the default level from ALL to INFO ... but you coul

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-07-12 Thread Jonathan Hurley
> On June 21, 2016, 4:48 p.m., Jonathan Hurley wrote: > > Ship It! > > Victor Galgo wrote: > Jonathan can please do the honours of helping to commit this patch? Has this been committed yet? If so, please close the review. - Jonathan --

Re: Review Request 49787: AMBARI-17623: Update default values of nimbus.monitor.freq.secs to 10 secs and zookeeper.session.timeout to 30 secs

2016-07-12 Thread Satish Duggana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49787/ --- (Updated July 13, 2016, 12:09 a.m.) Review request for Ambari and Apache Ambari

Review Request 49972: Check znode exits with retry during logsearch server setup too (for blueprints)

2016-07-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49972/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, and

Re: Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services

2016-07-12 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49930/#review141981 --- Ship it! Ship It! - Aravindan Vijayan On July 11, 2016, 10:5

Re: Review Request 49971: Misc Atlas fixes, remove conf dir from classpath of Falcon and Storm in HDP 2.5, add more security properties to Atlas Hooks, and delete deprecated configs

2016-07-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49971/#review141973 --- ambari-common/src/main/python/resource_management/libraries/funct

Review Request 49971: Misc Atlas fixes, remove conf dir from classpath of Falcon and Storm in HDP 2.5, add more security properties to Atlas Hooks, and delete deprecated configs

2016-07-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49971/ --- Review request for Ambari, Madhan Neethiraj, Nahappan Somasundaram, Sumit Mohant

Re: Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.

2016-07-12 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49935/ --- (Updated July 13, 2016, 6:55 a.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 49895: AMBARI-17631: preinstall-check script should use AMBARI-AGENT REST API for the list of agents

2016-07-12 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49895/#review141961 --- Ship it! Ship It! - Juanjo Marron On July 12, 2016, 4:48 p.

Re: Review Request 49927: Atlas HA fails to come up with error finding ids

2016-07-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49927/#review141959 --- Ship it! Ship It! - Sumit Mohanty On July 11, 2016, 9:42 p.m

Re: Review Request 49927: Atlas HA fails to come up with error finding ids

2016-07-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49927/#review141957 --- ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/

Re: Review Request 49953: Storm 1.0 Does Not Support Rolling Upgrades

2016-07-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49953/#review141924 --- Ship it! Ship It! - Nate Cole On July 12, 2016, 10:55 a.m.,

Re: Review Request 49927: Atlas HA fails to come up with error finding ids

2016-07-12 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49927/#review141921 --- ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/

Re: Review Request 49953: Storm 1.0 Does Not Support Rolling Upgrades

2016-07-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49953/#review141914 --- Ship it! Ship It! - Alejandro Fernandez On July 12, 2016, 2:

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-07-12 Thread Masahiro Tanaka
> On July 12, 2016, 5:02 p.m., Andrew Onischuk wrote: > > Committed the patch. Please close the reviewboard. thann you! - Masahiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#revie

Re: Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.

2016-07-12 Thread Masahiro Tanaka
> On July 12, 2016, 3:46 p.m., Andrew Onischuk wrote: > > Ship It! > > Andrew Onischuk wrote: > We have tests for those scripts. Are you sure they pass with your changes? Thank you for reviewing. I'm afraid I didn't check that. I'll check it soon and update. Sorry for that. - Masahiro

Re: Review Request 49902: Storm nimbus server fails to come up with CNF backtype.storm.metric.IClusterReporter error

2016-07-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49902/ --- (Updated Июль 12, 2016, 4:17 п.п.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 49898: ACL support for Logsearch Solr

2016-07-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49898/ --- (Updated July 12, 2016, 3:21 p.m.) Review request for Ambari, Miklos Gergely, R

Review Request 49953: Storm 1.0 Does Not Support Rolling Upgrades

2016-07-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49953/ --- Review request for Ambari, Alejandro Fernandez and Nate Cole. Bugs: AMBARI-1766

Re: Review Request 49898: ACL support for Logsearch Solr

2016-07-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49898/#review141874 --- Ship it! Ship It! - Sebastian Toader On July 11, 2016, 6:33

Re: Review Request 49947: Atlas server fails to stop after ambari upgrade

2016-07-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49947/#review141872 --- Ship it! Ship It! - Dmitro Lisnichenko On July 12, 2016, 10:

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-07-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review141866 --- Committed the patch. Please close the reviewboard. - Andrew Onisc

Review Request 49947: Atlas server fails to stop after ambari upgrade

2016-07-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49947/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-17673 https:

Re: Review Request 49946: Zeppelin service: add default kerberos config for shell interpreter

2016-07-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49946/#review141864 --- Ship it! Ship It! - Pallav Kulshreshtha On July 12, 2016, 6: