Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

2016-10-28 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53283/ --- (Updated Oct. 28, 2016, 9:02 p.m.) Review request for Ambari, Alejandro

Re: Review Request 53283: AMBARI-18744: Ambari-server: REST API changes to GET and PUT credential store information

2016-10-28 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53283/ --- (Updated Oct. 28, 2016, 9 p.m.) Review request for Ambari, Alejandro

Review Request 53283: AMBARI-18742: Ambari-server: Stack definition Object Model changes to support tag changes

2016-10-28 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53283/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole,

Re: Review Request 53276: AMBARI-18742: Ambari-server: Stack definition Object Model changes to support tag changes

2016-10-28 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53276/#review154189 ---

Review Request 53276: AMBARI-18742: Ambari-server: Stack definition Object Model changes to support tag changes

2016-10-28 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53276/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole,

Review Request 53273: Not able to change the default port ambari server listens to

2016-10-28 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53273/ --- Review request for Ambari, Di Li, Tim Thorpe, and Vitalyi Brodetskyi. Bugs:

Re: Review Request 53248: AMBARI-18694. DataNode JVM heap settings should include CMSInitiatingOccupancy

2016-10-28 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53248/#review154185 --- Ship it! Ship It! - Jaimin Jetly On Oct. 28, 2016, 8:15

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

2016-10-28 Thread Sangeeta Ravindran
> On Oct. 24, 2016, 9:37 p.m., Di Li wrote: > > Ship It! Thanks Di. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/#review153743

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

2016-10-28 Thread Sangeeta Ravindran
> On Oct. 28, 2016, 7:09 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Dipayan. Can you please help push the fix? > > DIPAYAN BHOWMICK wrote: > Done, committed to trunk, branch-2.5 Thank you Dipayan. - Sangeeta

Re: Review Request 53248: AMBARI-18694. DataNode JVM heap settings should include CMSInitiatingOccupancy

2016-10-28 Thread XIAOBING ZHOU
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53248/ --- (Updated Oct. 28, 2016, 8:15 p.m.) Review request for Ambari and Jaimin Jetly.

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

2016-10-28 Thread DIPAYAN BHOWMICK
> On Oct. 28, 2016, 7:09 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Dipayan. Can you please help push the fix? Done, committed to trunk, branch-2.5 - DIPAYAN --- This is an automatically

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

2016-10-28 Thread Sangeeta Ravindran
> On Oct. 28, 2016, 7:09 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Thank you Dipayan. Can you please help push the fix? - Sangeeta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

2016-10-28 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/#review154163 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Oct. 27, 2016, 8:24

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154151 --- Ship it! Nice! :) - Robert Levas On Oct. 28, 2016, 12:58

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154146 --- Ship it! Ship It! - Nate Cole On Oct. 28, 2016, 12:58 p.m.,

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154144 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 28, 2016,

Re: Review Request 53215: Ubuntu16 Add Support for Spark on HDP 2.5

2016-10-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53215/#review154142 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 28, 2016,

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/ --- (Updated Oct. 28, 2016, 12:58 p.m.) Review request for Ambari, Nate Cole and

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 39-50 > > > > > > Only a matter of time before someone wants to

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/ --- (Updated Oct. 28, 2016, 12:52 p.m.) Review request for Ambari, Nate Cole and

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
> On Oct. 28, 2016, 11:29 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 72-77 > > > > > > I wonder if there would ever be a need to

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 39-50 > > > > > > Only a matter of time before someone wants to

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
> On Oct. 28, 2016, 11:29 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/upgrade-pack.xsd, line 77 > > > > > > Shouldn't this be of type `security-type` from the definition above? Yes it should :)

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 39-50 > > > > > > Only a matter of time before someone wants to

Re: Review Request 53215: Ubuntu16 Add Support for Spark on HDP 2.5

2016-10-28 Thread Duc Le
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53215/ --- (Updated Oct. 28, 2016, 3:40 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Condition.java, > > lines 39-50 > > > > > > Only a matter of time before someone wants to

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154131 --- Fix it, then Ship it!

Review Request 53265: AMBARI-18729 - Add PDF version of stack, extension and service definitions

2016-10-28 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53265/ --- Review request for Ambari, Sumit Mohanty and Yusaku Sako. Bugs: AMBARI-18729

Re: Review Request 53263: During cluster install, Components get timed out icon while starting

2016-10-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53263/#review154128 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 28, 2016,

Re: Review Request 53263: During cluster install, Components get timed out icon while starting

2016-10-28 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53263/ --- (Updated Oct. 28, 2016, 2:43 p.m.) Review request for Ambari and Vitalyi

Review Request 53263: During cluster install, Components get timed out icon while starting

2016-10-28 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53263/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18728

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/ --- (Updated Oct. 28, 2016, 10:18 a.m.) Review request for Ambari, Nate Cole and

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Jonathan Hurley
> On Oct. 28, 2016, 9:32 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/upgrade-pack.xsd, line 147 > > > > > > Java side doesn't allow for more than one task per execute-stage. Nice catch! > On Oct.

Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154120 --- Fix it, then Ship it!

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

2016-10-28 Thread Sangeeta Ravindran
> On Oct. 28, 2016, 4:04 a.m., Di Li wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js, > > line 98 > > > > > > Will "No messages present" be displayed in the log textarea ? can