Re: Review Request 57579: AMBARI-20400 Yarn should not copy Tez and Slider tar ball if Tez and Sliders are not installed on the cluster

2017-03-29 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57579/ --- (Updated March 30, 2017, 1:49 a.m.) Review request for Ambari and Alejandro

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

2017-03-29 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/ --- (Updated March 29, 2017, 11:57 p.m.) Review request for Ambari, Jayush Luniya,

Review Request 58051: Misc fixes for ambari-server swagger integration prototype

2017-03-29 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58051/ --- Review request for Ambari, Jayush Luniya, Oliver Szabo, and Sumit Mohanty.

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

2017-03-29 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/#review170494 ---

Re: Review Request 58000: Unable to scroll down collapsed navigation bar if it's higher that viewport

2017-03-29 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58000/#review170490 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On March 28,

Review Request 57902: AMBARI-20553 : Ambari script error for ams-hbase while writing to Amazon s3 on a cluster with no HDFS.

2017-03-29 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57902/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 58046: yarn resource manager failed to start after upgrade with unable to construct queue exception.

2017-03-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58046/#review170480 --- Ship it! Ship It! - Jonathan Hurley On March 29, 2017, 4:20

Re: Review Request 58046: yarn resource manager failed to start after upgrade with unable to construct queue exception.

2017-03-29 Thread Jonathan Hurley
> On March 29, 2017, 4:31 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicy.java > > Lines 74-79 (patched) > > > > > > I

Re: Review Request 58046: yarn resource manager failed to start after upgrade with unable to construct queue exception.

2017-03-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58046/#review170477 --- Ship it! Ship It! - Alejandro Fernandez On March 29, 2017,

Re: Review Request 58046: yarn resource manager failed to start after upgrade with unable to construct queue exception.

2017-03-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58046/#review170474 ---

Re: Review Request 58046: yarn resource manager failed to start after upgrade with unable to construct queue exception.

2017-03-29 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58046/#review170473 --- Assuming that the regex pattern is correct, the changes look

Review Request 58045: Cleanup swagger rest api doc for Log Search

2017-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58045/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs:

Review Request 58046: yarn resource manager failed to start after upgrade with unable to construct queue exception.

2017-03-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58046/ --- Review request for Ambari, Jonathan Hurley and Sumit Mohanty. Bugs:

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

2017-03-29 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/#review170446 --- Ship it! Ship It! - Robert Nettleton On March 29, 2017,

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

2017-03-29 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/ --- (Updated March 29, 2017, 5:45 p.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 58019: Display log level, method name from stack_advisor in ambari-server.log

2017-03-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58019/#review170436 --- Ship it! Ship It! - Alejandro Fernandez On March 29, 2017,

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

2017-03-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/#review170433 ---

Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

2017-03-29 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58031/ --- Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58006/#review170429 --- Ship it! Ship It! - Robert Levas On March 29, 2017, 1:06

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58006/ --- (Updated March 29, 2017, 5:06 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 57917: AMBARI-20546 EU/RU service check should skip services that do not have config types

2017-03-29 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57917/#review170426 --- Ship it! Ship It! - Tim Thorpe On March 29, 2017, 3:08

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Robert Levas
> On March 28, 2017, 7:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Aravindan Vijayan
> On March 28, 2017, 11:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Aravindan Vijayan
> On March 28, 2017, 11:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Sumit Mohanty
> On March 28, 2017, 11:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller

Re: Review Request 57945: Log Search Configuration API

2017-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170411 ---

Re: Review Request 57945: Log Search Configuration API

2017-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/#review170409 ---

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-29 Thread Robert Levas
> On March 27, 2017, 11:18 a.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Lines 60-63 (original), 60-63 (patched) > > > > > >

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-29 Thread Balázs Bence Sári
> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Lines 60-63 (original), 60-63 (patched) > > > > > > This

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-29 Thread Balázs Bence Sári
> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Lines 60-63 (original), 60-63 (patched) > > > > > > This

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Robert Levas
> On March 28, 2017, 7:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Aravindan Vijayan
> On March 28, 2017, 11:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller

Re: Review Request 57917: AMBARI-20546 EU/RU service check should skip services that do not have config types

2017-03-29 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57917/ --- (Updated March 29, 2017, 3:08 p.m.) Review request for Ambari, Alejandro

Re: Review Request 57945: Log Search Configuration API

2017-03-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57945/ --- (Updated March 29, 2017, 2:06 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 58022: AMBARI-19149. Code cleanup: redundant type arguments

2017-03-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58022/#review170386 --- Ship it! Ship It! - Nate Cole On March 29, 2017, 7:06 a.m.,

Re: Review Request 58022: AMBARI-19149. Code cleanup: redundant type arguments

2017-03-29 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58022/#review170385 --- Ship it! Ship It! - Sebastian Toader On March 29, 2017,

Re: Review Request 58024: Add hashing support into agent for caches ; add topology and metadata cache

2017-03-29 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58024/#review170383 --- Ship it! Ship It! - Vitalyi Brodetskyi On Березень 29,

Review Request 58024: Add hashing support into agent for caches ; add topology and metadata cache

2017-03-29 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58024/ --- Review request for Ambari and Myroslav Papirkovskyy. Bugs: AMBARI-20620

Re: Review Request 57910: Create a base class for caching in ambari-agent.

2017-03-29 Thread Andrew Onischuk
> On March 27, 2017, 6:26 p.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py > > Lines 36 (patched) > > > > > > Please add a description for all of the params

Re: Review Request 57910: Create a base class for caching in ambari-agent.

2017-03-29 Thread Andrew Onischuk
> On March 27, 2017, 6:26 p.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py > > Lines 62 (patched) > > > > > > Inconsistent return value since not all code

Re: Review Request 58023: JS error on Step6 installer when click "all/none"

2017-03-29 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58023/#review170379 --- Ship it! Ship It! - Denys Buzhor On March 29, 2017, 11:27

Re: Review Request 58022: AMBARI-19149. Code cleanup: redundant type arguments

2017-03-29 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58022/#review170377 --- Ship it! Ship It! - Laszlo Puskas On March 29, 2017, 11:06

Review Request 58022: AMBARI-19149. Code cleanup: redundant type arguments

2017-03-29 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58022/ --- Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor

Re: Review Request 58003: Add disable security option to infra-solr-client

2017-03-29 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58003/#review170371 --- Ship it! Ship It! - Attila Magyar On March 29, 2017, 10:13

Re: Review Request 58003: Add disable security option to infra-solr-client

2017-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58003/ --- (Updated March 29, 2017, 10:13 a.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 58003: Add disable security option to infra-solr-client

2017-03-29 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58003/#review170370 ---

Re: Review Request 58003: Add disable security option to infra-solr-client

2017-03-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58003/#review170369 --- Ship it! Ship It! - Miklos Gergely On March 29, 2017, 9:55

Re: Review Request 58003: Add disable security option to infra-solr-client

2017-03-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58003/ --- (Updated March 29, 2017, 9:55 a.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-29 Thread Robert Levas
> On March 28, 2017, 7:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller

Review Request 58019: Display log level, method name from stack_advisor in ambari-server.log

2017-03-29 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58019/ --- Review request for Ambari, Andrew Onischuk, Nate Cole, and Siddharth Seth.

Re: Review Request 58003: Add disable security option to infra-solr-client

2017-03-29 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58003/#review170367 ---