Re: Review Request 60050: AMBARI-21240. Some topology request data retained after host removed

2017-06-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60050/#review177866 --- ambari-server/src/main/java/org/apache/ambari/server/topology/Per

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Saisai Shao
> On June 13, 2017, 3:18 p.m., Sumit Mohanty wrote: > > One more thing: If user upgrades from HDP-2.6.x to 2.6.2, do you want the > > configs to be added? If yes then that upgrade xml change is needed. > > Saisai Shao wrote: > Yes, I want. So do I only need to change the code under HDP/2.6/

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59992/#review177855 --- Ship it! Ship It! - Sumit Mohanty On June 14, 2017, 1:31 a.m

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Sumit Mohanty
> On June 13, 2017, 3:18 p.m., Sumit Mohanty wrote: > > One more thing: If user upgrades from HDP-2.6.x to 2.6.2, do you want the > > configs to be added? If yes then that upgrade xml change is needed. > > Saisai Shao wrote: > Yes, I want. So do I only need to change the code under HDP/2.6/

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Saisai Shao
> On June 13, 2017, 3:18 p.m., Sumit Mohanty wrote: > > One more thing: If user upgrades from HDP-2.6.x to 2.6.2, do you want the > > configs to be added? If yes then that upgrade xml change is needed. > > Saisai Shao wrote: > Yes, I want. So do I only need to change the code under HDP/2.6/

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Saisai Shao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59992/ --- (Updated June 14, 2017, 1:31 a.m.) Review request for Ambari and Sumit Mohanty.

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Sumit Mohanty
> On June 13, 2017, 3:18 p.m., Sumit Mohanty wrote: > > One more thing: If user upgrades from HDP-2.6.x to 2.6.2, do you want the > > configs to be added? If yes then that upgrade xml change is needed. > > Saisai Shao wrote: > Yes, I want. So do I only need to change the code under HDP/2.6/

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Saisai Shao
> On June 13, 2017, 3:18 p.m., Sumit Mohanty wrote: > > One more thing: If user upgrades from HDP-2.6.x to 2.6.2, do you want the > > configs to be added? If yes then that upgrade xml change is needed. Yes, I want. So do I only need to change the code under HDP/2.6/upgrades? - Saisai --

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59838/ --- (Updated June 13, 2017, 9:56 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

2017-06-13 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/ --- (Updated June 13, 2017, 9:39 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 60055: Support revert for patch upgrades

2017-06-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60055/ --- (Updated June 13, 2017, 5:19 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 60055: Support revert for patch upgrades

2017-06-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60055/#review177793 --- Ship it! Ship It! - Alejandro Fernandez On June 13, 2017, 7:

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-13 Thread Tim Thorpe
> On June 13, 2017, 7:09 p.m., Nate Cole wrote: > > Ship It! Hi Nate, still working on this to fix a deploy with UI issue will hopefully have another patch up soon. Thanks - Tim --- This is an automatically generated e-mail. To reply,

Review Request 60055: Support revert for patch upgrades

2017-06-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60055/ --- Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Jonathan

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59838/#review177782 --- Ship it! Ship It! - Nate Cole On June 7, 2017, 8:26 a.m., Ti

Re: Review Request 60048: Kafka userprincipal to shortname is not using AUTH_TO_LOCAL rules for authorization

2017-06-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60048/#review15 --- Ship it! Ship It! - Alejandro Fernandez On June 13, 2017, 1:

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59992/#review14 --- Ship it! Ship It! - Alejandro Fernandez On June 13, 2017, 5:

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-13 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59951/#review177762 --- ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/a

Review Request 60050: AMBARI-21240. Some topology request data retained after host removed

2017-06-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60050/ --- Review request for Ambari, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.

Re: Review Request 59992: AMBARI-21226. Add two new Spark thrift server related configurations in Spark stack

2017-06-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59992/#review177746 --- One more thing: If user upgrades from HDP-2.6.x to 2.6.2, do you w

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/ --- (Updated June 13, 2017, 2:44 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/ --- (Updated June 13, 2017, 2:38 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/ --- (Updated June 13, 2017, 2:42 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 60049: Ambari leaves a lot of processes from Hive alert on the machine

2017-06-13 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60049/#review177738 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 13, 2017,

Review Request 60049: Ambari leaves a lot of processes from Hive alert on the machine

2017-06-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60049/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-21239 https:

Re: Review Request 60048: Kafka userprincipal to shortname is not using AUTH_TO_LOCAL rules for authorization

2017-06-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60048/#review177736 --- Ship it! Ship It! - Dmitro Lisnichenko On June 13, 2017, 4:1

Review Request 60048: Kafka userprincipal to shortname is not using AUTH_TO_LOCAL rules for authorization

2017-06-13 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60048/ --- Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi Brodets

Re: Review Request 59956: Update Database Access Layer to Support New Database Schema for Improved User Account Management

2017-06-13 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59956/#review177734 --- ambari-server/src/main/java/org/apache/ambari/server/orm/entities

Re: Review Request 60047: Principal placeholder replacement in kerberos.json doesn't work with blueprint installs

2017-06-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60047/#review177733 --- Ship it! Ship It! - Sebastian Toader On June 13, 2017, 2:42

Review Request 60047: Principal placeholder replacement in kerberos.json doesn't work with blueprint installs

2017-06-13 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60047/ --- Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, and S

Re: Review Request 59954: Drop JDK 7 support for Ambari Server and Ambari managed services (AMS, LogSearch, Infra)

2017-06-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59954/ --- (Updated June 13, 2017, 12:14 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 60045: Add validation and recommendation if hive user value is different than hive

2017-06-13 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60045/ --- Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and Sid W

Re: Review Request 60007: Rename userconfig resource to event history in Log Search Portal

2017-06-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60007/#review177728 --- Ship it! Ship It! - Sebastian Toader On June 13, 2017, 12:24

Re: Review Request 59929: Extend Swagger Maven pluging to handle nested API's

2017-06-13 Thread Balázs Bence Sári
> On June 12, 2017, 10:48 a.m., Attila Doroszlai wrote: > > utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java > > Lines 56 (patched) > > > > > > Should be `LOG`, not `logger` Unfortunately, LOG