Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61500/#review182462 --- Ship it! I just had a quick question about the first check

Review Request 61510: AMBARI-21686 : Implement a test driver that provides a set of metric series with different kinds of metric behavior

2017-08-08 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61510/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/#review182428 ---

Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61500/#review182425 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 8, 2017,

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/ --- (Updated Aug. 8, 2017, 5:57 p.m.) Review request for Ambari, Laszlo Puskas,

Re: Review Request 61176: Apply zeppelin.server.kerberos.principal related changes to 0.6.0.3.0

2017-08-08 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61176/#review182411 --- Ship it! Ship It! - Gaurav Nagar On July 27, 2017, 9:09

Re: Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

2017-08-08 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61479/#review182410 --- Ship it! Ship It! - venkat sairam On Aug. 7, 2017, 8:07

Review Request 61503: Service and Patch Upgrade Catalog Changes for 2.6.0

2017-08-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61503/ --- Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.

Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61500/ --- (Updated Aug. 8, 2017, 12:03 p.m.) Review request for Ambari, Dmitro

Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61500/ --- Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. Bugs:

Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

2017-08-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/#review182393 --- Ship it! Ship It! - Jonathan Hurley On Aug. 7, 2017, 6:45

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61490/#review182389 --- Ship it! Ship It! - Nate Cole On Aug. 7, 2017, 11:48 p.m.,

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/#review182388 --- Ship it! Ship It! - Laszlo Puskas On Aug. 8, 2017, 1:40

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Balázs Bence Sári
> On July 21, 2017, 12:41 p.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java > > Lines 81 (patched) > > > > > > Can this be

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Jonathan Hurley
> On Aug. 8, 2017, 1:31 a.m., Dmytro Grinenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > > Line 249 (original), 255 (patched) > > > > > > could we put here

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Jonathan Hurley
> On Aug. 8, 2017, 5:27 a.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > > Lines 326 (patched) > > > > > > cbecks Thanks! Fixed. -

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/ --- (Updated Aug. 8, 2017, 1:40 p.m.) Review request for Ambari, Laszlo Puskas,

Re: Review Request 60668: Fixed outdated index.html generation in ambari-server/target/generated-sources/swagger

2017-08-08 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60668/#review182379 --- Ship it! Ship It! - Sebastian Toader On July 5, 2017, 10:32

Re: Review Request 61490: Upgrade Pre-Checks Should Take PATCH/SERVICE Types Into Account

2017-08-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61490/#review182376 --- Ship it!

Re: Review Request 61456: Create a topic to send alert_definitions

2017-08-08 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61456/ --- (Updated Aug. 8, 2017, 9:10 a.m.) Review request for Ambari, Alejandro

Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

2017-08-08 Thread Aman Poonia
> On Aug. 7, 2017, 6:28 p.m., Alejandro Fernandez wrote: > > What OS'es was this tested on? Tested it on Centos-6.4. Python documentation says "It is available on all Unix versions". - Aman --- This is an automatically generated