---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49455/#review140304
---
Ship it!
Ship It!
- Daniel Gergely
On jún. 30, 2016, 4:15
t's the root cause of more than 1k rows being returned?
> > RU/EU?
>
> Daniel Gergely wrote:
> The number of returned lines is irrelevant here. The problem is the
> number of parameters in the prepared statement. The query above has "task_id
> IN ?1" part
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/49265/#review139611
-------
On jún. 27, 2016, 2:01 du, Daniel Gergely wrote:
>
> ---
> Th
,
Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49260/#review139563
---
Ship it!
Ship It!
- Daniel Gergely
On jún. 27, 2016, 12:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49255/#review139545
---
Ship it!
Ship It!
- Daniel Gergely
On jún. 27, 2016, 9:43
/security/authorization/AmbariLdapBindAuthenticator.java
(line 112)
<https://reviews.apache.org/r/49253/#comment204812>
You can use StringUtils.isEmpty() here.
- Daniel Gergely
On jún. 27, 2016, 9:25 de, Oliver Szabo
use the other tests "pollutes" it.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48266/#review137749
-----------
On jún. 16, 2016, 8:24 de, Daniel Gergely wrote:
>
> -
e3f5b49
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
fd8653c
Diff: https://reviews.apache.org/r/48266/diff/
Testing
---
Succeeded locally
Thanks,
Daniel Gergely
/ambari/server/controller/internal/DeleteSpacesAtTheEndTrimmingStrategy.java
(line 24)
<https://reviews.apache.org/r/48494/#comment202938>
Please swap variable and constant.
- Daniel Gergely
On jún. 15, 2016, 1:30 du, Dmytro Sen
Definer.java
(line 43)
<https://reviews.apache.org/r/48494/#comment202929>
Swap constant and variable
- Daniel Gergely
On jún. 14, 2016, 1:45 du, Dmytro Sen wrote:
>
> ---
> This is
nit tests.
Thanks,
Daniel Gergely
-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
e3f5b49
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
fd8653c
Diff: https://reviews.apache.org/r/48266/diff/
Testing
---
Succeeded locally
Thanks,
Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48413/#review137708
---
Ship it!
Ship It!
- Daniel Gergely
On jún. 15, 2016, 9:24
ate classes, so they cannot be accessed from unit tests.
Thanks,
Daniel Gergely
/server/topology/TopologyManagerTest.java
fd8653c
Diff: https://reviews.apache.org/r/48691/diff/
Testing
---
Thanks,
Daniel Gergely
post an event, I think I
can move the logic there.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48266/#review137477
----------
-----------
On jún. 11, 2016, 6:43 de, Daniel Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48266/
> --
.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48266/#review137326
---
On jún. 11, 2016, 6:43 de, Da
ain/java/org/apache/ambari/server/topology/HostRequest.java
00ecb98
Diff: https://reviews.apache.org/r/48642/diff/
Testing
---
Changes are done in private classes, so they cannot be accessed from unit tests.
Thanks,
Daniel Gergely
> On jún. 9, 2016, 4:05 du, Daniel Gergely wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> > line 343
> > <https://reviews.apache.org/r/48494/diff/1/?file=1412628#file1412628line343>
/internal/BlueprintConfigurationProcessor.java
(line 343)
<https://reviews.apache.org/r/48494/#comment201909>
Please consider cyclomatic complexity in this method.
- Daniel Gergely
On jún. 9, 2016, 3:23 du, Dmytro Sen
/topology/TopologyManager.java
e3f5b49
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
fd8653c
Diff: https://reviews.apache.org/r/48266/diff/
Testing
---
Still running locally...
Thanks,
Daniel Gergely
/ambari/server/topology/TopologyManagerTest.java
fd8653c
Diff: https://reviews.apache.org/r/48266/diff/
Testing
---
Still running locally...
Thanks,
Daniel Gergely
...
Thanks,
Daniel Gergely
/org/apache/ambari/server/topology/TopologyManager.java
e3f5b49
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
fd8653c
Diff: https://reviews.apache.org/r/48266/diff/
Testing
---
Still running locally...
Thanks,
Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47976/#review135472
---
Ship it!
Ship It!
- Daniel Gergely
On máj. 27, 2016, 8:14
> On máj. 27, 2016, 12:09 du, Daniel Gergely wrote:
> >
Just a quiestion: if \n separated string is needed only for the UI, wouldnt it
be better to handle it on the UI side? So UI can do the conversion, since it is
not needed anywhere else. If it is also used somewhere else,
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47946/#review135215
-----------
On máj. 27, 2016, 10:14 de, Daniel Gergely wrote:
>
> --
CESS
[INFO]
[INFO] Total time: 2:45.484s
[INFO] Finished at: Fri May 27 12:05:56 CEST 2016
[INFO] Final Memory: 119M/797M
[INFO]
Thanks,
Daniel Gergely
797M
[INFO]
Thanks,
Daniel Gergely
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review134511
-------
On máj. 23, 2016, 8:20 de, Daniel Gergely wrote:
>
> ---
> Thi
/BlueprintConfigurationProcessorTest.java
073e827
Diff: https://reviews.apache.org/r/47726/diff/
Testing
---
In progress...
Thanks,
Daniel Gergely
; >
> > +1 for Sebastian's comment, a unit test should definitely be added here
> > to verify this change.
>
> Daniel Gergely wrote:
> We were talking about this unit test thing. These are static variables,
> so I can test if all the properties are there in the m
/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
9cabdbb
Diff: https://reviews.apache.org/r/47726/diff/
Testing
---
In progress...
Thanks,
Daniel Gergely
]
Thanks,
Daniel Gergely
/850M
[INFO]
Thanks,
Daniel Gergely
is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if
the resolver itself works correctly.
Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
(failing tests are not related to this issue)
Thanks,
Daniel Gergely
is checked manually.
The blueprint issue is also checked manually, a separated unit test checks if
the resolver itself works correctly.
Tests run: 4312, Failures: 0, Errors: 7, Skipped: 34
(failing tests are not related to this issue)
Thanks,
Daniel Gergely
is also checked manually, a separated unit test checks if
the resolver itself works correctly.
Unit tests are still running locally...
Thanks,
Daniel Gergely
/ambari/server/topology/AmbariContextTest.java
(line 394)
<https://reviews.apache.org/r/47014/#comment195870>
Use 3 separated Asserts to help debugging in case on an error.
- Daniel Gergely
On máj. 5, 2016, 2:12 du, Sebastian Toader
/ambari_agent/ActionQueue.py c5340a0
ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e
Diff: https://reviews.apache.org/r/46889/diff/
Testing
---
I did manual testing to see the output messages on the UI.
Thanks,
Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46695/#review130615
---
Ship it!
Ship It!
- Daniel Gergely
On ápr. 26, 2016, 2:17
/authorization/AmbariAuthentication.java
(line 195)
<https://reviews.apache.org/r/46695/#comment194429>
Why is password assigned to the usernameOrig?
- Daniel Gergely
On ápr. 26, 2016, 1:55 du, Sebastian Toader
)
--
Total run:970
Total errors:0
Total failures:0
OK
Thanks,
Daniel Gergely
-
>
> (Updated ápr. 21, 2016, 3:19 du)
>
>
> Review request for Ambari, Daniel Gergely, Laszlo Puskas, Sandor Magyari,
> Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-16013
> https://issues.apache.org/jira/browse/AMBARI-16013
>
>
>
:0
Total failures:0
OK
Thanks,
Daniel Gergely
.
For DataNodes I made an intentional exception to see if it keeps waiting. (this
is how I ran into the 20 minutes server task timeout)
--
Total run:970
Total errors:0
Total failures:0
OK
Thanks,
Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46403/#review129707
---
Ship it!
Ship It!
- Daniel Gergely
On ápr. 19, 2016, 8:16
(this leads to
an error, correctly)
- removing a stack advisor file that is NOT used in the next version (no error,
correctly)
---
Total run:963
Total errors:0
Total failures:0
OK
Thanks,
Daniel Gergely
]
[INFO] Total time: 1:11:47.762s
[INFO] Finished at: Thu Apr 14 13:40:06 CEST 2016
[INFO] Final Memory: 46M/1060M
[INFO]
Thanks,
Daniel Gergely
/cluster/ClustersTest.java
daf8d12
Diff: https://reviews.apache.org/r/46148/diff/
Testing
---
Thanks,
Daniel Gergely
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46148/#review128689
-------
On ápr. 13, 2016, 3:04 du, Daniel Gergely wrote:
>
>
/test_dir/file.jar):
expected: 1, actual: 0
Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
Thanks,
Daniel Gergely
, actual: 0
Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
Thanks,
Daniel Gergely
):
expected: 1, actual: 0
Tests run: 4202, Failures: 1, Errors: 0, Skipped: 32
Thanks,
Daniel Gergely
, Skipped: 32
Thanks,
Daniel Gergely
---
Still running locally...
Thanks,
Daniel Gergely
://reviews.apache.org/r/46021/diff/
Testing
---
Still running locally...
Thanks,
Daniel Gergely
horization/AmbariAuthorizationFilterTest.java
3dd6b0a
Diff: https://reviews.apache.org/r/45538/diff/
Testing
---
Thanks,
Daniel Gergely
r/security/authorization/AmbariAuthorizationFilterTest.java
3dd6b0a
Diff: https://reviews.apache.org/r/45538/diff/
Testing
---
Thanks,
Daniel Gergely
t is not
checked in the cache for a while, it is cleared.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45538/#review126826
-
it/request/RequestAuditLogModule.java
52ad44c
Diff: https://reviews.apache.org/r/45538/diff/
Testing
---
Thanks,
Daniel Gergely
/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
89e920d
Diff: https://reviews.apache.org/r/45587/diff/
Testing
---
I did an upgrade from 2.2.2 to trunk to verify the fix.
Thanks,
Daniel Gergely
: https://reviews.apache.org/r/45538/diff/
Testing
---
Thanks,
Daniel Gergely
change.
Thanks,
Daniel Gergely
---
Thanks,
Daniel Gergely
18b860a
ambari-server/src/test/java/org/apache/ambari/server/audit/request/DefaultEventCreatorTest.java
5c23059
Diff: https://reviews.apache.org/r/45579/diff/
Testing
---
Auditlog and AuthorizationHelper tests should cover the test cases of the
current change.
Thanks,
Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45544/#review126307
---
Ship it!
Ship It!
- Daniel Gergely
On márc. 31, 2016, 2:28
---
Thanks,
Daniel Gergely
/audit/AuditLoggerDefaultImpl.java
1cfb740
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PermissionHelper.java
ecf2d7a
Diff: https://reviews.apache.org/r/45538/diff/
Testing
---
Thanks,
Daniel Gergely
e added to cover functionality.
All tests passed on local machine.
Thanks,
Daniel Gergely
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/44265/#review125890
-------
On márc. 30, 2016, 12:44 du, Daniel Gergely wrote:
>
> ---
> This is an automatically generated
ucting a new date formatter for every entry?
Moved to ThreadLocal.
- Daniel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44265/#review125892
---------
122542
-------
On márc. 30, 2016, 12:44 du, Daniel Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r
e added to cover functionality.
All tests passed on local machine.
Thanks,
Daniel Gergely
ent187156>
See my comment above
- Daniel Gergely
On márc. 16, 2016, 5:14 du, Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
-jdbc.jar
org.apache.ambari.server.controller.AmbariServer
Thanks,
Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44958/#review124042
-------
On márc. 17, 2016, 2:57 du, Daniel Gergely wrote:
>
> --
://reviews.apache.org/r/44956/diff/
Testing
---
Tests ran without failures. (2016-03-17 13:30)
Thanks,
Daniel Gergely
/HostResourceProviderTest.java
69c570e
Diff: https://reviews.apache.org/r/44956/diff/
Testing
---
Tests ran without failures. (2016-03-17 13:30)
Thanks,
Daniel Gergely
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44509/#review122515
---
Ship it!
Ship It!
- Daniel Gergely
On márc. 8, 2016, 1:42
82 matches
Mail list logo
