Diff: https://reviews.apache.org/r/60575/diff/1/
Testing
---
Manually tested
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53883/#review156325
---
Ship it!
Ship It!
- Lav Jain
On Nov. 18, 2016, 6:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53621/#review155489
---
Ship it!
Ship It!
- Lav Jain
On Nov. 9, 2016, 8:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53584/#review155371
---
Ship it!
Ship It!
- Lav Jain
On Nov. 8, 2016, 8:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53512/#review155174
---
Ship it!
Ship It!
- Lav Jain
On Nov. 5, 2016, 5:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53177/#review153917
---
Ship it!
Ship It!
- Lav Jain
On Oct. 26, 2016, midnight
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53106/#review153764
---
Ship it!
- Lav Jain
On Oct. 21, 2016, 10:46 p.m., Matt wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51754/#review148370
---
Ship it!
Ship It!
- Lav Jain
On Sept. 9, 2016, 1:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51587/#review147680
---
Ship it!
Please include @mithmatt in the review.
- Lav Jain
otal time: 01:01 min
[INFO] Finished at: 2016-08-10T13:20:41-07:00
[INFO] Final Memory: 81M/1275M
[INFO] ----
```
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50777/#review144711
---
Ship it!
Ship It!
- Lav Jain
On Aug. 4, 2016, 1:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50731/#review144709
---
Ship it!
Ship It!
- Lav Jain
On Aug. 4, 2016, 1:11 a.m
you switch from regular mode to secure mode
and vice-versa.
Diffs (updated)
-
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
298513c
Diff: https://reviews.apache.org/r/50545/diff/
Testing
---
In progress.
Thanks,
Lav Jain
you switch from regular mode to secure mode
and vice-versa.
Diffs (updated)
-
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
8c43555
Diff: https://reviews.apache.org/r/50545/diff/
Testing
---
In progress.
Thanks,
Lav Jain
to secure mode
and vice-versa.
Diffs
-
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py
8c43555
Diff: https://reviews.apache.org/r/50545/diff/
Testing
---
In progress.
Thanks,
Lav Jain
---
Tested manually.
Thanks,
Lav Jain
Should line 378 be hosts["items"][2] instead of hosts["items"][3]? Same for
line 390.
- Lav Jain
On July 19, 2016, 7:15 p.m., Matt wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142849
---
Ship it!
Ship It!
- Lav Jain
On July 19, 2016, 7:15 p.m
manually with various combinations
Thanks,
Lav Jain
,
Lav Jain
/service_advisor.py
16e2952
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json
3c8a897
Diff: https://reviews.apache.org/r/50086/diff/
Testing
---
Manually tested
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49659/#review140947
---
Ship it!
Ship It!
- Lav Jain
On July 5, 2016, 9:39 p.m
/configs/pxf_default.json
Diff: https://reviews.apache.org/r/49521/diff/
Testing
---
Total run:1005
Total errors:0
Total failures:0
OK
Thanks,
Lav Jain
/hawq_default.json ebff461
ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json
Diff: https://reviews.apache.org/r/49521/diff/
Testing
---
Total run:1005
Total errors:0
Total failures:0
OK
Thanks,
Lav Jain
/hawq_default.json ebff461
ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json 10cd9a4
Diff: https://reviews.apache.org/r/49521/diff/
Testing
---
Total run:1005
Total errors:0
Total failures:0
OK
Thanks,
Lav Jain
10cd9a4
Diff: https://reviews.apache.org/r/49521/diff/
Testing
---
Total run:1005
Total errors:0
Total failures:0
OK
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49362/#review139977
---
Ship it!
Ship It!
- Lav Jain
On June 29, 2016, 10:04 a.m
ase-env content text'}
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48290/#review136395
---
Ship it!
Ship It!
- Lav Jain
On June 6, 2016, 7:17 p.m
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/48229/#review136240
-------
On June 5, 2016, 10:18 p.m., Lav Jain wrote:
>
> ---
> This is an automat
text'}
ok
test_getServiceConfigurationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
/service_advisor.py
(line 179)
<https://reviews.apache.org/r/48235/#comment201176>
Minor! Line 179 can be moved next to line 212.
- Lav Jain
On June 3, 2016, 10:49 p.m., bhuvnesh chaudhary wrote:
>
> ---
> This is a
/test_service_advisor.py
<https://reviews.apache.org/r/48235/#comment201175>
hawq_rm_nvcore_limit_perseg (same for hawq_rm_memory_limit_perseg) should
be set only when rm_type is none. Any particular reason for removing this test?
- Lav Jain
On June 3, 2016, 10:49 p.m., bhuvnesh chaudhary
ationRecommendations
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
rviceAdvisor) ... ok
--
Ran 9 tests in 0.027s
OK
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48194/#review136025
---
Ship it!
Ship It!
- Lav Jain
On June 3, 2016, 1:10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48091/#review135814
---
Ship it!
Ship It!
- Lav Jain
On May 31, 2016, 8:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47975/#review135306
---
Ship it!
Ship It!
- Lav Jain
On May 27, 2016, 7:48 p.m
.TestUtils) ... ok
--
Ran 53 tests in 0.470s
OK
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47926/#review135116
---
Ship it!
Ship It!
- Lav Jain
On May 26, 2016, 11:24 p.m
ls) ... ok
--
Ran 53 tests in 0.470s
OK
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47840/#review134817
---
Ship it!
Ship It!
- Lav Jain
On May 25, 2016, 7:25 p.m
/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py#L43
- Lav Jain
On May 25, 2016, 6:37 p.m., Matt wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134670
---
Ship it!
Ship It!
- Lav Jain
On May 25, 2016, 12:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47749/#review134490
---
Ship it!
Ship It!
- Lav Jain
On May 23, 2016, 11:44 p.m
/service_advisor.py
(line 56)
<https://reviews.apache.org/r/47642/#comment198845>
return list(ambariServerHost)
- Lav Jain
On May 20, 2016, 8:13 a.m., Matt wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47627/#review134209
---
Ship it!
Ship It!
- Lav Jain
On May 20, 2016, 10:11 p.m
/internal/BlueprintConfigurationProcessorTest.java
(line 7244)
<https://reviews.apache.org/r/47627/#comment198844>
hawqSite.containsKey("hawq_standby_address_host")
- Lav Jain
On May 20, 2016, 2:09 a.m., bhuvnesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47657/#review134207
---
Ship it!
Ship It!
- Lav Jain
On May 20, 2016, 6:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47616/#review134055
---
Ship it!
Ship It!
- Lav Jain
On May 19, 2016, 9:50 p.m
)
<https://reviews.apache.org/r/47379/#comment198679>
App.HostComponentStatus.started instead of 'STARTED' (in case the constant
is updated to include 'STARTING')
- Lav Jain
On May 14, 2016, 12:27 a.m., Goutam Tadi
)
<https://reviews.apache.org/r/47379/#comment198678>
Does it make sense to create isServiceCheckDisabled function here and move
the PXF logic from host_component.js?
- Lav Jain
On May 14, 2016, 12:27 a.m., Goutam Tadi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review134019
---
Ship it!
Ship It!
- Lav Jain
On May 19, 2016, 6:58 p.m
tps://reviews.apache.org/r/47379/#comment198663>
The logic for disabled can be extracted into a separate function.
- Lav Jain
On May 14, 2016, 12:27 a.m., Goutam Tadi wrote:
>
> ---
> This is an automatically generated e-mail.
/src/test/python/stacks or continue to put the common-services
tests under 2.3 stack?
- Lav Jain
On May 19, 2016, 6:11 a.m., Matt wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/test_service_advisor.py (line 29)
<https://reviews.apache.org/r/47580/#comment198646>
Not sure if loading of PXFServiceAdvisor is necessary. The test should call
stackAdvisor directly and that should automatically load PXF service advisor
for the corresponding routines.
- Lav Jain
On May 19, 2016, 6:
Called can be defined using functools.partial
- Lav Jain
On May 18, 2016, 11:28 p.m., Matt wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47277/#review132809
---
Ship it!
Ship It!
- Lav Jain
On May 12, 2016, 1:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47156/#review132557
---
Ship it!
Ship It!
- Lav Jain
On May 10, 2016, 10:22 p.m
te1 -c "SELECT summary_state, error_message FROM gp_master_mirroring"
Not Synchronized##error received sending data to standby master: server
closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
`
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132512
---
Ship it!
Ship It!
- Lav Jain
On May 10, 2016, 7:26 a.m
/step6_controller_test.js
(line 235)
<https://reviews.apache.org/r/47160/#comment196731>
+1 for comprehensive test code
- Lav Jain
On May 10, 2016, 7:26 a.m., Matt wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
monentName (instead of component)
Diffs
-
ambari-server/src/main/resources/stacks/stack_advisor.py 00b9d79
Diff: https://reviews.apache.org/r/47138/diff/
Testing
---
Tested manually
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46996/#review131764
---
Ship it!
Ship It!
- Lav Jain
On May 4, 2016, 11:52 p.m
> On May 2, 2016, 11:07 p.m., Lav Jain wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 644
> > <https://reviews.apache.org/r/44210/diff/6/?file=1367511#file1367511line644>
> >
> > This method is not being called because the corresp
HAWQSEGMENTs start before HAWQMASTER and HAWQSTANDBY starts.
Diffs
-
ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json
da4146a
Diff: https://reviews.apache.org/r/46857/diff/
Testing
---
Tested manually.
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46742/#review131178
---
Ship it!
Ship It!
- Lav Jain
On April 29, 2016, 6:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/#review130865
---
Ship it!
Ship It!
- Lav Jain
On April 27, 2016, 11:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46585/#review130491
---
Ship it!
Ship It!
- Lav Jain
On April 22, 2016, 11:51 p.m
: https://reviews.apache.org/r/46350/diff/
Testing
---
Tested manually
Thanks,
Lav Jain
/resources/common-services/PXF/3.0.0/package/scripts/params.py
ae0c80c
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
fe3c17e
Diff: https://reviews.apache.org/r/46350/diff/
Testing
---
Tested manually
Thanks,
Lav Jain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46359/#review129469
---
Ship it!
Ship It!
- Lav Jain
On April 19, 2016, 1:20 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46283/#review129202
---
Ship it!
Ship It!
- Lav Jain
On April 15, 2016, 10:15 p.m
--
Total run:925
Total errors:0
Total failures:0
OK
Thanks,
Lav Jain
-services/HAWQ/2.0.0/package/alerts/alert_segment_registration_status.py
4d09763
Diff: https://reviews.apache.org/r/46170/diff/
Testing
---
Manually tested.
Thanks,
Lav Jain
/package/scripts/hawqmaster.py
(line 105)
<https://reviews.apache.org/r/46072/#comment191892>
This code is already part of init_component in common.py
- Lav Jain
On April 12, 2016, 6:27 a.m., bhuvnesh chaudhary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46062/#review128285
---
Ship it!
Ship It!
- Lav Jain
On April 11, 2016, 11:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45899/#review127701
---
Ship it!
Ship It!
- Lav Jain
On April 7, 2016, 10:26 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45826/#review127405
---
Ship it!
- Lav Jain
On April 6, 2016, 6:04 p.m., Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45724/#review127037
---
Ship it!
Ship It!
- Lav Jain
On April 5, 2016, 2:38 a.m
-web/app/views/common/configs/service_config_layout_tab_view.js 694e883
Diff: https://reviews.apache.org/r/45566/diff/
Testing
---
Manually tested the UI.
Unit test added for stack advisor.
Thanks,
Lav Jain
/params.py
eed2d18
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py
40e6d6f
Diff: https://reviews.apache.org/r/45252/diff/
Testing
---
Tested manually with and without YARN, with and without security.
Thanks,
Lav Jain
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/45252/#review125170
-------
On March 23, 2016, 10:23 p.m., Lav Jain wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44868/#review123784
---
Ship it!
Ship It!
- Lav Jain
On March 15, 2016, 10:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44574/#review122747
---
Ship it!
Ship It!
- Lav Jain
On March 9, 2016, 5:16 p.m
85 matches
Mail list logo
